Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   05 Oct 2020 08:20:02 +0900
Message-ID: <87eemdr38y.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     <broonie@kernel.org>, <lgirdwood@gmail.com>, <robh+dt@kernel.org>,
        <pierre-louis.bossart@linux.intel.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <alsa-devel@alsa-project.org>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
        <mkumard@nvidia.com>, <viswanathl@nvidia.com>,
        <rlokhande@nvidia.com>, <dramesh@nvidia.com>,
        <atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
        <swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver
In-Reply-To: <25771697-fc85-b377-ae99-a5e0957ba02d@nvidia.com>
References: <1601573587-15288-1-git-send-email-spujar@nvidia.com>
        <1601573587-15288-11-git-send-email-spujar@nvidia.com>
        <87362xkxdv.wl-kuninori.morimoto.gx@renesas.com>
        <25771697-fc85-b377-ae99-a5e0957ba02d@nvidia.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Precedence: bulk


Hi Sameer

> > This is just an idea,
> > but can we use hooks here somehow ?
> > 
> >          .ops_hook_pre
> >          .ops_hook_func
> >          .ops_hook_post
> > 
> >          if (priv->ops_hook_pre->func)
> >                  priv->ops_hook_pre->func_pre(...);
> > 
> >          if (priv->ops_hook_func->func)
> >                  priv->ops_hook_func->func(...); /* driver's function */
> >          else
> >                  graph_func(...);        /* audio-graph function */
> > 
> >          if (priv->ops_hook_post->func)
> >                  priv->ops_hook_post->func(...);
> 
> Right now I just required to populate some flags or structures and do
> not have any specific pre()/post() functions to be called. Can this be
> reserved for later?

Yeah, of course :)

> > These are almost same as graph_probe().
> > Maybe we can separate graph_probe() and export function ?
> 
> Yes possible, I can move more stuff into graph_parse_of() which is
> already an exported function in the current series. This can be
> utilized by both generic audio graph and Tegra audio graph.
> 
> Something like below,
> 
> static int tegra_audio_graph_probe(struct platform_device *pdev)
> {
> ??????? struct tegra_audio_priv *priv;
> ??????? struct device *dev = &pdev->dev;
> ??????? struct snd_soc_card *card;
> 
> ??????? priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> ??????? if (!priv)
> ??????????????? return -ENOMEM;
> 
> ??????? card = simple_priv_to_card(&priv->simple);
> 
> ??????? card->owner = THIS_MODULE;
> ??????? card->dev = dev;
> ??????? card->probe = tegra_audio_graph_card_probe;
> 
> ??????? /* graph_parse_of() depends on below */
> ??????? card->component_chaining = 1;
> ??????? priv->simple.ops = &tegra_audio_graph_ops;
> ??????? priv->simple.force_dpcm = 1;
> 
> ??????? return graph_parse_of(&priv->simple);
> }

I think graph side can handle card->owner / card->dev,
but, it looks good to me

Thank you for your help !!

Best regards
---
Kuninori Morimoto