Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michael Brunner <Michael.Brunner@kontron.com>
To:     "lee.jones@linaro.org" <lee.jones@linaro.org>
CC:     "mibru@gmx.de" <mibru@gmx.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: kempld-core: Mark kempld-acpi_table as
 __maybe_unused
Thread-Topic: [PATCH] mfd: kempld-core: Mark kempld-acpi_table as
 __maybe_unused
Thread-Index: AQHWl9idDQYeZ/9tfUC7Hluf7RcAM6mD5AgAgAS4vwA=
Date:   Mon, 5 Oct 2020 07:07:52 +0000
Message-ID: <b7fb20174aa7fd8a15132b6de679498fe0b18fd1.camel@kontron.com>
References: <37c55c13f9042dde06fd67c829b06765286d0580.camel@kontron.com>
         <20201002070134.GR6148@dell>
In-Reply-To: <20201002070134.GR6148@dell>
Accept-Language: de-DE, en-US
Content-Language: en-US
user-agent: Evolution 3.36.4-0ubuntu1 
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <A997409E7AB53842B1C25905A336EE8D@EURPRD10.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: af943da7-a77c-492f-b98b-08d868fd605b
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2020 07:07:52.4464
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZEw2qwYsyRhhRkkf7OlezDeoXqP4vxK/yIeEhVh+cw+yUxZIrdpy/5Qte54Ucsx1Xwg23YekPdll/5Ur9KA09Qh0mJpdTsIVsRQDEehT0Sk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB2955
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2020-10-02 at 08:01 +0100, Lee Jones wrote:
> On Thu, 01 Oct 2020, Michael Brunner wrote:
>=20
> > The Intel 0-DAY CI Kernel Test Service reports an unused variable
> > warning when compiling with clang for PowerPC:
> >=20
> > > > drivers/mfd/kempld-core.c:556:36: warning: unused variable
> > > > 'kempld_acpi_table' [-Wunused-const-variable]
> >    static const struct acpi_device_id kempld_acpi_table[] =3D {
> >=20
> > The issue can be fixed by marking kempld_acpi_table as
> > __maybe_unused.
> >=20
> > Fixes: e8299c7313af ("[PATCH] mfd: Add ACPI support to Kontron PLD
> > driver")
> >=20
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
> > ---
> >  drivers/mfd/kempld-core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
> > index 1dfe556df038..273481dfaad4 100644
> > --- a/drivers/mfd/kempld-core.c
> > +++ b/drivers/mfd/kempld-core.c
> > @@ -553,7 +553,7 @@ static int kempld_remove(struct platform_device
> > *pdev)
> >  	return 0;
> >  }
> > =20
> > -static const struct acpi_device_id kempld_acpi_table[] =3D {
> > +static const struct acpi_device_id __maybe_unused
> > kempld_acpi_table[] =3D {
> >  	{ "KEM0001", (kernel_ulong_t)&kempld_platform_data_generic },
> >  	{}
> >  };
>=20
> This is not the right fix.  Better just to compile it out completely
> in these circumstances.  I already have a fix for this in soak.

Ok - thank you for the other fix you submitted!

But just out of curiosity - in process/coding-style.rst is written that
__maybe_unused should be preferred over wrapping in preprocessor
conditionals, if a function or variable may potentially go unused in a
particular configuration. So why is my patch not the right one here? At
least in my tests it seemed to solve the issue.

Thanks,
  Michael