Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3093602pxk; Mon, 5 Oct 2020 00:28:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiqtVaDF/tfdUmCqWhj8kI2WZKWrtZwiqe6LdMiZ5qOkYH4DL5N+5ZJ67YUXKCcNW5pjCM X-Received: by 2002:a05:6402:1298:: with SMTP id w24mr7480865edv.280.1601882881939; Mon, 05 Oct 2020 00:28:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601882881; cv=none; d=google.com; s=arc-20160816; b=lxc7M1OV7EHj1YGlbdauNIJmbBzBjnH3VB7uzLllGeNIUGnt1JMhn1609QycgEa5eC m+/08QNPNpfNAGME6Q7bJbJHcogD5G+Ga4i16XmB2skvL7+XDJaO3YIT4TBUvVI/qjGH Evx7aWkXXevjUMgOIsUoGHOgU9CYqqHXGzo+6JExT6mos04H9zEUjulO5Hj9LSChVS93 q2Dr3prPSTr4exUSDsmJrTcG47DstV4QSSsaJ3BGK1A4oDuFr6bAYK70EN7efL627zfI 1JDBgdN3fcJQ8Jr0rkSwamffQSaW1ZWe5+Q5YoyG+sr8LjVo1eNvieEpy8ictom55NCW n96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5sM6+fPAuGy2swhfps1Vh088uPyk+Nclxk6vr8avp4U=; b=Ej2ZpRAyGvDjSjGswg8nzeVe0Ev5GYuAjL6NsxCO3IYpVoPbnPa13Lpj1qr8b1FdhL WR4ngmtVYq3abjqJdajrJ/XlPe0vxoSljMBavudh9lMsp1E/nFULOymvh2pFa4e1/635 4lVP5RvA96T763IDRc3lSItJSkqbXPk83bSpFsk20/orquFiOibQSVDFQtSNVEA0xmJb 8otxNEbuGQab9RpJrEoQe3DpizD/54ZRY9OTbVfMx2g/s3Yl194Wlz+j7Wp/vt2AjF9p TR6qB7Sdd66NqiOFKwOcK7XlWj+e77JD0+weM0N3NnYr0UX6zacDlZQQBjMPNZrsyGh+ 1htw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=gZ3le+Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 20si6363744edx.435.2020.10.05.00.27.37; Mon, 05 Oct 2020 00:28:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=gZ3le+Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725911AbgJEH0A (ORCPT + 99 others); Mon, 5 Oct 2020 03:26:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbgJEH0A (ORCPT ); Mon, 5 Oct 2020 03:26:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73A33C0613CE; Mon, 5 Oct 2020 00:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5sM6+fPAuGy2swhfps1Vh088uPyk+Nclxk6vr8avp4U=; b=gZ3le+BrS/YBFbsfqY9n0gSqSd GdTnl+ZXSnKjByjsumxnE3yMQpa4pnT0q+YzM3hDXAmmcLFC4gDTkaQKwOYueuDPDl65KzXOWQCd3 onUw2Xb3pcYhvLgGNsQSDdzx+rlsE3HisgN0jtBA6l36wUgtWnjF+a6KR3Q8Hqn01z4a0kthN19UV 3MCG+Oi7SWO8sEgYWdVeK0S3SNXsjMKrI2dwdk1CzR+qf7HmapjOJGOtmLz3q4b/vxb/qUtdTR53A BSkJqC/kwPWCXwS5gEyo1qr+6UYJjR3qIOb/t23QdQXqkdnUo7W/8OIRJMQXQ+bH9QlvmQTejpW9B X4SuaQgg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPKsf-0004UC-VK; Mon, 05 Oct 2020 07:25:58 +0000 Date: Mon, 5 Oct 2020 08:25:57 +0100 From: Christoph Hellwig To: "Gustavo A. R. Silva" Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook Subject: Re: [PATCH][next] block: scsi_ioctl: Avoid the use of one-element arrays Message-ID: <20201005072557.GB14204@infradead.org> References: <20201002231033.GA6273@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002231033.GA6273@embeddedor> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 06:10:33PM -0500, Gustavo A. R. Silva wrote: > One-element arrays are being deprecated[1]. Replace the one-element array > with a simple object of type compat_caddr_t: 'compat_caddr_t unused'[2], > once it seems this field is actually never used. They are only deprecated when abused as variable length array. That is not the case here.