Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3102328pxk; Mon, 5 Oct 2020 00:44:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjdmfsgiVh/YVII0zQx53+dhs+cGVXTDysWChem0Fuuhmz4TxntFU+/bClqZl+GVuHZnt1 X-Received: by 2002:a50:cf8a:: with SMTP id h10mr15988790edk.43.1601883861757; Mon, 05 Oct 2020 00:44:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601883861; cv=none; d=google.com; s=arc-20160816; b=dKYiTuM241BpxxNUvz6ExbdNnDhuDClb9mL9pZTfolrzE1DGVqYtLknj61MQrSGwre Y57wUfzBTGGBlwmbC5b4x+mz6lKUJftwxK0OVn1jcP8LIr7mxGlzPRLcgXLwC5odnniG fNnacO9kU0EfaoUUAg/Pl24+Qt8VQ2r5rHkVSf60l5iuhtCRoD/Sp2vX2KCtwr4ViF1t 1PIXl4/zTANB4JE28DcSLwERT/cRQmJr7eHwvKWb+WhOq4BtYwhvtgGXdpCtMUyFdpsx tPRZYhKrbRkiXUev8R/LoVIPVpDt7bHVwF8xpxR5up/KwuDheMsMwBi5MC4q09koWpBY pKag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=DpNN07CM7/FN2cNcmZHgo66ZHx1AW0Wl6ChsaLeWRVQ=; b=fCeTAlSYCL1SCa2p36+EPDSxZKt4DxewzE2fBnyjlWgmkzM3Y5zRPsKBMs5MTzK1zH /zGR/wVvekgSCOxyWOQNjpE20/3OojV7SJh10VyAlhR/yz0kb+VPrnHPbhn7nH/GFRri mE1txRr7JFP86Qe+f0HgmorltRzv2GD8OuU06WXRotW2VwEdTZ8FJAC/5Xpf2Ho3C0N4 QY2iqx2xAG+PfcHzXObooVu/OHgalGJD0Y/061pkk7FqY4zbB5seeZFIrik7QBD5CSI8 23gIUOYw4yM2/ttiFIiGZeVA/Iy+fOMpojcoGCrVb0Yl1nDeGldnHH2XOG/4fg/dyqS1 zcIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si2015792edr.460.2020.10.05.00.43.58; Mon, 05 Oct 2020 00:44:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725909AbgJEHm5 (ORCPT + 99 others); Mon, 5 Oct 2020 03:42:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:39398 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHm4 (ORCPT ); Mon, 5 Oct 2020 03:42:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 28728ACBA; Mon, 5 Oct 2020 07:42:55 +0000 (UTC) Date: Mon, 5 Oct 2020 09:42:54 +0200 From: Daniel Wagner To: Nilesh Javali , Arun Easi Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qla2xxx: Do not consume srb greedily Message-ID: <20201005074254.2f5vgauk5tfwad35@beryllium.lan> References: <20200929073802.18770-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929073802.18770-1-dwagner@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 09:38:02AM +0200, Daniel Wagner wrote: > qla2xx_process_get_sp_from_handle() will clear the slot which the > current srb is stored. So this function has a side effect. Therefore, > we can't use it in qla24xx_process_mbx_iocb_response() to check > for consistency and later again in qla24xx_mbx_iocb_entry(). > > Let's move the consistency check directly into > qla24xx_mbx_iocb_entry() and avoid the double call or any open coding > of the qla2xx_process_get_sp_from_handle() functionality. > > Fixes: 31a3271ff11b ("scsi: qla2xxx: Handle incorrect entry_type entries") > Signed-off-by: Daniel Wagner > --- > Hi, > > Brown bag for me please. My test patch had an open coded version of > qla2xx_process_get_sp_from_handle() which didn't consume the srb. When > I prepared it for sending it out, I 'cleaned' it up by using > qla2xx_process_get_sp_from_handle() twice. Ping.