Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/3] nvmem: qfprom: Don't touch certain fuses
To:     Evan Green <evgreen@chromium.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Douglas Anderson <dianders@chromium.org>,
        Stephen Boyd <swboyd@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20200929205807.2360405-1-evgreen@chromium.org>
 <20200929135741.3.I1bb1b0e94be3b792804e08831d6a55481e162d63@changeid>
 <8f467220-3ac8-c8fc-33fe-8d86904571fe@linaro.org>
 <CAE=gft5FoWpscS_9CfuCNSZxsq_CUu_AShQ=tLiW=NGL8YG5tQ@mail.gmail.com>
 <d79de840-25cc-0e8e-15e6-3cc2fda2e38b@linaro.org>
 <CAE=gft4eDRBSuAQmiZQs3LegVyERWAJSmvmHKEY1N=z5HSViJQ@mail.gmail.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <14b62a74-4b4f-42b9-6043-ab8445a3f627@linaro.org>
Date:   Mon, 5 Oct 2020 10:12:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CAE=gft4eDRBSuAQmiZQs3LegVyERWAJSmvmHKEY1N=z5HSViJQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 01/10/2020 22:49, Evan Green wrote:
> Oh no, I realized this isn't nearly as beautiful when I try to move it
> into the core. The low level read/write interface between the nvmem
> core and the driver is a range. So to move this into the core I'd have
> to implement all the overlap computation logic to potentially break up
> a read into several small reads in cases where there are many little
> keepout ranges. It was much simpler when I could just check each byte
> offset individually, and because I was doing it in this one
> rarely-used driver I could make that performance tradeoff without much
> penalty.
> 
> I could do all range/overlap handling if you want, but it'll be a
> bigger change, and I worry my driver would be the only one to end up
> using it. What do you think?

I still think this should go in to core. core should be able to avoid 
checking by the presence of any restricted range, so it should not be a 
overhead for other non-users. regmap has similar feature we can take 
some inspiration from that code!!


--srini


> -Evan