Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Oct 2020 11:21:45 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: allwinner: h6: add eMMC voltage property
 for Beelink GS1
Message-ID: <20201005092145.wdu4m4pwxydv76ou@gilmour.lan>
References: <20201003092001.405238-1-peron.clem@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="c4ix5n55lrdh2mia"
Content-Disposition: inline
In-Reply-To: <20201003092001.405238-1-peron.clem@gmail.com>
Precedence: bulk


--c4ix5n55lrdh2mia
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Cl=E9ment,

On Sat, Oct 03, 2020 at 11:20:01AM +0200, Cl=E9ment P=E9ron wrote:
> Sunxi MMC driver can't distinguish at runtime what's the I/O voltage
> for HS200 mode.

Unfortunately, that's not true (or at least, that's not related to your pat=
ch).

> Add a property in the device-tree to notify MMC core about this
> configuration.
>=20
> Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 bo=
ard")
> Signed-off-by: Cl=E9ment P=E9ron <peron.clem@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/ar=
ch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 049c21718846..3f20d2c9bbbb 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -145,6 +145,7 @@ &mmc2 {
>  	vqmmc-supply =3D <&reg_bldo2>;
>  	non-removable;
>  	cap-mmc-hw-reset;
> +	mmc-hs200-1_8v;
>  	bus-width =3D <8>;
>  	status =3D "okay";
>  };

I'm not really sure what you're trying to fix here, but as far as MMC
goes, eMMC's can support io voltage of 3.3, 1.8 and 1.2V. Modes up until
HS DDR (50MHz in DDR) will use an IO voltage of 3.3V, higher speed modes
(HS200 and HS400) supporting 1.8V and 1.2V.

The mmc-hs200-1_8v property states that the MMC controller supports the
HS200 mode at 1.8V. Now, I can only assume that since BLDO2 is set up at
1.8V then otherwise, the MMC core will rightfully decide to use the
highest supported mode. In this case, since the driver sets it, it would
be HS-DDR at 3.3V, which won't work with that fixed regulator.

I can only assume that enabling HS200 at 1.8V only fixes the issue you
have because otherwise it would use HS-DDR at 3.3V, ie not actually
fixing the issue but sweeping it under the rug.

Trying to add mmc-ddr-1_8v would be a good idea

Maxime

--c4ix5n55lrdh2mia
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3rlqQAKCRDj7w1vZxhR
xZMxAQDNyd1ZGwKGk+fSv4NeOTTL+ZLS6HM+lF1zM9gDmNYgVQD7BKqG2TFD8s6y
Wl/7bqwW+9JdvOkXwEoqfyACLdYuRQQ=
=JJEw
-----END PGP SIGNATURE-----

--c4ix5n55lrdh2mia--