Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3207774pxk; Mon, 5 Oct 2020 04:09:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtNeTRMzAxYV9cMSY0VmOQYsdUdbn7/C71AfqscxAABPoWALwXUMbGcgjUKuC8JlK44DUQ X-Received: by 2002:a50:bf47:: with SMTP id g7mr16578684edk.26.1601896163714; Mon, 05 Oct 2020 04:09:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601896163; cv=none; d=google.com; s=arc-20160816; b=zhtJlpnc0bkfyl2hQ+QdI1ElsO/V/zqhQeNwdTPCZEQ0jkK+h/DM20LPbHO8caZDgt On9vwsAAzBUF0nXvHIdv88Fb1x4oYiXEFmeVPJJiKg4JTgi13lGJ5O3gKeYrbabAZM1Z CGN6eBvaAQZrrDUCtl2+TYObU0c8lHdHrYu0awsqbxPfnQky4UzdyKNbaY6osCaQff2u Qzq5KNbwveqM6YN6abnVlf4Zk4O0yHZYn5beiaYZv9uMgcUfcnMLW4XWzBJ6Wx0WWbpg EvzrLLmIYrHXpG9lAZ3A8Cwp7liWWJJJc3rdaPabxXgz6E9umrb9Kza/tf0eJ5Lzbago 9tZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=VFkdDdTfDmfnnaXSh9EawylA/MHj8dBcyiOyNCe9cFA=; b=rzn+fXRSvc1TFF4/2A9ebb2XdeF0osDL/a3B3ZwlsN0hApb4tuYjvjS8M2VOEAYjR6 cZ9+T9TRtn+QkUvyc+QI9bnXaYMDQOOOBD12BjIpFSjbICUe52Wqd/VAzdRk21GZyQBp aVghBI37Ui/RcdF+CJA+ipKf0n2bWFUea/Y9hNDwvmzFEAKChTw0A0K31owsveH4MEbf sGO5v2ea3kUazuDrY4rB0IwGMgc02MmU3oSY9+dtpklpJfk2B80foICMOaaQtwASR5ue Vy4B5XFh1qTXfWe41vSbaCwA4h8cms3zaM2Ty56F1XCz5vQ6Foot5a4Fk2NKpJuAEVCd Stpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g11si6684380eds.232.2020.10.05.04.09.00; Mon, 05 Oct 2020 04:09:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726073AbgJELHa (ORCPT + 99 others); Mon, 5 Oct 2020 07:07:30 -0400 Received: from mga09.intel.com ([134.134.136.24]:22140 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgJELH0 (ORCPT ); Mon, 5 Oct 2020 07:07:26 -0400 IronPort-SDR: Hl5Q02DD5lngTsL/Rv0fYnPGIyTMd9mah+hfhnH/QWFFrWmHhaShliafZvyOPVfMYHWE17XMk7 socz/5/Bto7g== X-IronPort-AV: E=McAfee;i="6000,8403,9764"; a="164225480" X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="164225480" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 04:07:24 -0700 IronPort-SDR: MbbapK5I+cnXEdDPbNqLEG1OtYLKK524tJ9A1r6870P9S2FrhFm4IFBjSrSiFF/gXkEnzqNDlJ 05PAFJJZ74YA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="516688856" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.190]) ([10.237.72.190]) by fmsmga005.fm.intel.com with ESMTP; 05 Oct 2020 04:07:21 -0700 Subject: Re: [PATCH 1/2] scsi: ufs: Add DeepSleep feature To: Avri Altman , "Martin K . Petersen" , "James E . J . Bottomley" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alim Akhtar References: <20201002124043.25394-1-adrian.hunter@intel.com> <20201002124043.25394-2-adrian.hunter@intel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 5 Oct 2020 14:06:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/20 12:51 pm, Avri Altman wrote: >> >> >> On 5/10/20 11:02 am, Avri Altman wrote: >>> HI, >>> >>>> Drivers that wish to support DeepSleep need to set a new capability flag >>>> UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing >>>> ->device_reset() callback. >>> I would expect that this capability controls sending SSU 4, but it only controls >> the sysfs entry? >> >> The sysfs entry is the only way to request DeepSleep. > Some chipset vendors use their own modules, or even the device tree > to set their default rpm_lvl / spm_lvl. I would not expect them to set it wrongly but what are you suggesting?