Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Oct 2020 13:15:47 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Nicolin Chen <nicoleotsuka@gmail.com>, joro@8bytes.org,
        vdumpa@nvidia.com, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()
Message-ID: <20201005111547.GQ425362@ulmo>
References: <20201002060807.32138-1-nicoleotsuka@gmail.com>
 <20201002060807.32138-3-nicoleotsuka@gmail.com>
 <b1a195cf-0127-0531-f6d1-835367511f57@gmail.com>
 <0c66bab9-0132-d3fb-ea4e-de1278cf2b04@gmail.com>
 <20201005095351.GI425362@ulmo>
 <ae48aaaf-fe10-6de4-06bb-2afbde799168@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="kZU6r8y0YpRwyDfh"
Content-Disposition: inline
In-Reply-To: <ae48aaaf-fe10-6de4-06bb-2afbde799168@gmail.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--kZU6r8y0YpRwyDfh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 05, 2020 at 01:36:55PM +0300, Dmitry Osipenko wrote:
> 05.10.2020 12:53, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Fri, Oct 02, 2020 at 05:50:08PM +0300, Dmitry Osipenko wrote:
> >> 02.10.2020 17:22, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >>>>  static int tegra_smmu_of_xlate(struct device *dev,
> >>>>  			       struct of_phandle_args *args)
> >>>>  {
> >>>> +	struct platform_device *iommu_pdev =3D of_find_device_by_node(args=
->np);
> >>>> +	struct tegra_mc *mc =3D platform_get_drvdata(iommu_pdev);
> >>>>  	u32 id =3D args->args[0];
> >>>> =20
> >>>> +	of_node_put(args->np);
> >>>> +
> >>>> +	if (!mc || !mc->smmu)
> >>>> +		return -EPROBE_DEFER;
> >>> platform_get_drvdata(NULL) will crash.
> >>>
> >>
> >> Actually, platform_get_drvdata(NULL) can't happen. I overlooked this.
> >=20
> > How so? It's technically possible for the iommus property to reference a
> > device tree node for which no platform device will ever be created, in
> > which case of_find_device_by_node() will return NULL. That's very
> > unlikely and perhaps worth just crashing on to make sure it gets fixed
> > immediately.
>=20
> The tegra_smmu_ops are registered from the SMMU driver itself and MC
> driver sets platform data before SMMU is initialized, hence device is
> guaranteed to exist and mc can't be NULL.

Yes, but that assumes that args->np points to the memory controller's
device tree node. It's obviously a mistake to do this, but I don't think
anyone will prevent you from doing this:

	iommus =3D <&{/chosen} 0>;

In that case, since no platform device is created for the /chosen node,
iommu_pdev will end up being NULL and platform_get_drvdata() will crash.

That said, I'm fine with not adding a check for that. If anyone really
does end up messing this up they deserve the crash.

I'm still a bit undecided about the mc->smmu check because I haven't
convinced myself yet that it can't happen.

Thierry

--kZU6r8y0YpRwyDfh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl97AGMACgkQ3SOs138+
s6EFMhAArB0+w3SsuWOHgLNkY+cFC6nn9FHzozivUKxgv7oSV8svQmcqrUMlfk1C
ZFlyT3HtM1POgbubhOVdybFepULnAvsKut9TD5J8EFvzHZJwYqjyVwwD0VqVry2c
a/zGLATS4nqtMIfgCHQ9hzlNMQa+/S59RO68oLpZdHwRSst+D1fwi6gY+dFn3HoJ
G2x94K10487l1O+wQjN5kQWu9gxzv4tuauLz1OHE+WvP75la9tDjcXMFwH/Jutsa
F7W1H97dD6+YGeNbEKtQ6WkI04D1WIh/9WaryJLDUzvuuw2JyEHEGLdyd9wtfABE
WWvctvwP9lDkLaRz1yOBQBHVWFE+dr6/mHmf3goKN0r4UilDRbpWFsOEEj4BF5Dd
MsiWEayh7MMRzmH66nmfR/ZeJYE05pE7hth/JSmfYVVMTiuOb2ZS2CFk9llO8png
9x6Hy+XrCDqfAoldTfGHiytYIcWEB1nMMRa1SqDqRtVgPxsDmtWXda5eAYqJVjRq
jwgdOPF07B1Y1q+Q9Xn/MQdSlbVK5S4nc3kz3ltmUB9ktVsUetBJs4Xqsr5jwhO5
7+BGIyn/e/y6k5SHQj6rMc87ByIBNrtGooZiPxVgYbKlI/ASye/ZQgY1kO93d+zK
XJ31HMNds7kT5gIaqmtZqUsAdkWHSeQKJqdLsGal3zY8Y62cahE=
=l8C/
-----END PGP SIGNATURE-----

--kZU6r8y0YpRwyDfh--