Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3249483pxk; Mon, 5 Oct 2020 05:15:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyogEMA7L4nb/lusTRsvnM/ATVVa6aDqYzRg1V8bh7L3Dvw1VxHdlJDXxHCmp/u/DY8X2gM X-Received: by 2002:a17:906:bce5:: with SMTP id op5mr16378881ejb.500.1601900143076; Mon, 05 Oct 2020 05:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601900143; cv=none; d=google.com; s=arc-20160816; b=JFFXuFVs6a1ExREZys49UR7nWMxw3CqRTBj1MexOrCrr3O+hJI5aaVvc49udghZrQW 98GhYt0OKF1i8LaSCFIQ1W3v/CPeRWiZzCFy6PB6P6FdgopmsRR6prrry3zr6tGGo96A Lenjm9kB6OhPL70Kce33ATi5axLxT3iMXp4b24v73y0v5v+HiIfTT8CwgkuRmfH6+yk0 qCy1nevKCfKXdI7TvUXLZBjZNHPeGyQPaoCFOADI0txs5TDg7+X/gH58mAQ+lpolIpr+ kIydvQSAQrYC+OJirCu92dWMk0iHNVUrw+aQ/EtnEDXfCHwehazBt9qpP71PyCase8hF fm4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5DWf2uImD2iG1GlnH5SdhXI5OTrpo2xSLstZL/L3GPo=; b=yGKXY4OLckPAdb+3dr+NsYySnl7qvWBkCUa8gDR+GsDPQYC0Q7g4T0Ja8KJFeEJHOx t648s9skwt29z7WYB31ws7j1Lgp24Bbs8Rf+a63WMAdyr7WEXj1ZLWE90YoSfgL2llP/ ZiRNA8yjBBrElD7YWU0xBkYI73lZN4I3TMjRQsJj2NNhxIGRI1nf0jtMyabdW7EnGDle UypfMs1tseP6J6wUEhzEcvSV+GSODNyPq3U8SscXltX4CN7WibY91SeH4YyWoq9Kld9L bLdGRmTOf7alTiXELOUTD4sJsOc51ucROamH4ko/RRryoFxXQb8VONShzusvFuJRYGIP Vayg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si4130313ejw.392.2020.10.05.05.15.20; Mon, 05 Oct 2020 05:15:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbgJEMNh (ORCPT + 99 others); Mon, 5 Oct 2020 08:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbgJEMMf (ORCPT ); Mon, 5 Oct 2020 08:12:35 -0400 Received: from smtp2-2.goneo.de (smtp2.goneo.de [IPv6:2001:1640:5::8:33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAA0DC0613A7 for ; Mon, 5 Oct 2020 05:12:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.goneo.de (Postfix) with ESMTP id B5A11241A54; Mon, 5 Oct 2020 14:12:33 +0200 (CEST) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.985 X-Spam-Level: X-Spam-Status: No, score=-2.985 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=-0.085, BAYES_00=-1.9] autolearn=ham Received: from smtp2.goneo.de ([127.0.0.1]) by localhost (smtp2.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6SnMfvbkiRsT; Mon, 5 Oct 2020 14:12:31 +0200 (CEST) Received: from lem-wkst-02.lemonage.de. (hq.lemonage.de [87.138.178.34]) by smtp2.goneo.de (Postfix) with ESMTPA id 8C92C241509; Mon, 5 Oct 2020 14:12:31 +0200 (CEST) From: poeschel@lemonage.de To: Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org (open list) Cc: Lars Poeschel , Willy Tarreau Subject: [PATCH v3 20/32] auxdisplay: cleanup unnecessary hd44780 code in charlcd Date: Mon, 5 Oct 2020 14:11:48 +0200 Message-Id: <20201005121200.3427363-21-poeschel@lemonage.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005121200.3427363-1-poeschel@lemonage.de> References: <20201005121200.3427363-1-poeschel@lemonage.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Poeschel This cleans up now unnecessary hd44780 specific code from charlcd. We obsoleted this with the last three patches. So another chunk of hd44780 code can be dropped. Reviewed-by: Willy Tarreau Signed-off-by: Lars Poeschel --- drivers/auxdisplay/charlcd.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c index b099897e101b..c04aaa4d66a5 100644 --- a/drivers/auxdisplay/charlcd.c +++ b/drivers/auxdisplay/charlcd.c @@ -26,11 +26,6 @@ #define LCD_BL_TEMPO_PERIOD 4 /* LCD commands */ -#define LCD_CMD_DISPLAY_CTRL 0x08 /* Display control */ -#define LCD_CMD_DISPLAY_ON 0x04 /* Set display on */ -#define LCD_CMD_CURSOR_ON 0x02 /* Set cursor on */ -#define LCD_CMD_BLINK_ON 0x01 /* Set blink on */ - #define LCD_CMD_FUNCTION_SET 0x20 /* Set function */ #define LCD_CMD_DATA_LEN_8BITS 0x10 /* Set data length to 8 bits */ #define LCD_CMD_TWO_LINES 0x08 /* Set to two display lines */ @@ -419,17 +414,7 @@ static inline int handle_lcd_special_code(struct charlcd *lcd) if (oldflags == priv->flags) return processed; - /* check whether one of B,C,D flags were changed */ - if ((oldflags ^ priv->flags) & - (LCD_FLAG_B | LCD_FLAG_C | LCD_FLAG_D)) - /* set display mode */ - hdc->write_cmd(hdc, - LCD_CMD_DISPLAY_CTRL | - ((priv->flags & LCD_FLAG_D) ? LCD_CMD_DISPLAY_ON : 0) | - ((priv->flags & LCD_FLAG_C) ? LCD_CMD_CURSOR_ON : 0) | - ((priv->flags & LCD_FLAG_B) ? LCD_CMD_BLINK_ON : 0)); - /* check whether one of F,N flags was changed */ - else if ((oldflags ^ priv->flags) & (LCD_FLAG_F | LCD_FLAG_N)) + if ((oldflags ^ priv->flags) & (LCD_FLAG_F | LCD_FLAG_N)) hdc->write_cmd(hdc, LCD_CMD_FUNCTION_SET | ((hdc->ifwidth == 8) ? LCD_CMD_DATA_LEN_8BITS : 0) | -- 2.28.0