Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3254387pxk; Mon, 5 Oct 2020 05:23:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxL7xXdVzDamXC9UvHqStalxhIyt+48fMy3rgXLkl35n+fnqhjO0RGYNhTmRbFazy0j/VoL X-Received: by 2002:aa7:d9c9:: with SMTP id v9mr17163205eds.103.1601900611260; Mon, 05 Oct 2020 05:23:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601900611; cv=none; d=google.com; s=arc-20160816; b=dSxoWt9Ke++AD0bdTVvmRNza9ud130Sv4p1bTu3BmYwavIpovt27ohwuSmzZVSDy0Y cL1/j4JXqjynX52pTZpqMiNVlxRT6BRveDgXk9JEF1EKsrO0mZbK9M3AEPVJxlUmJQQE mCEinhsHadsr9Km6RvzG92NgEkyq/jV9oDgF7a0oqXk+zsZXCLqdEc8ugWIAy+Gz0+b0 sNLdMPzWg85LSpz7sc52CUecxgmLYZIUCeo9lYP8Me8+Zy+mTLkCJGntXl7R8STtddDd 7RN0VhZOFx2CqPOwTtYyBA8U1caojS3mSx2A9APRahndN0a1+FpDE/EuDbjqOBGD6dt4 nQfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=+Kb7s0+T+7Dcwng7PbskdsRUPhXNDD+FmTLsUPshx1M=; b=wXBYJYXb+69vHhvNUklbhsSwE5CGc0suiew/1kTg8iamvXjXMyqPamibCigXAlBA7Z 9CtrP+dtwtHKV2Q8Vo+1QKGyndr/TLSVwbCiaYlpnpp0F67lsgZpKIb9yY2qMyq6Vw9Z +JP7j5f8muWtJUcotQXYodytLNRxPuOJEopEEnOawHEqJOfWFEVtZBiWOqqAsjgRqoyq KvcDi/ulnay5QuJkT7DU1CaMPHmEsjNsZRbAJCbV7aw8EAi4tkIwV8eMq4KWZxG4ER1W KgzpIMj9HZ97hI6yFxvg1rszf84SDeJRqCDB1pmEpOQZZkRqYX4A5HtMFyZwTw7TQQMx u/nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=T5+I83Hq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si2534694eds.36.2020.10.05.05.23.08; Mon, 05 Oct 2020 05:23:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=T5+I83Hq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbgJEMTw (ORCPT + 99 others); Mon, 5 Oct 2020 08:19:52 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:11748 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgJEMTw (ORCPT ); Mon, 5 Oct 2020 08:19:52 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 05 Oct 2020 05:18:03 -0700 Received: from [10.25.74.112] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 5 Oct 2020 12:19:38 +0000 Subject: Re: [PATCH 0/2] PCI: dwc: Add support to handle prefetchable memory separately To: Lorenzo Pieralisi CC: Gustavo Pimentel , "jingoohan1@gmail.com" , "bhelgaas@google.com" , "amurray@thegoodpenguin.co.uk" , "robh@kernel.org" , "thierry.reding@gmail.com" , "jonathanh@nvidia.com" , , , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kthota@nvidia.com" , "mmaddireddy@nvidia.com" , "sagar.tv@gmail.com" References: <20200602100940.10575-1-vidyas@nvidia.com> <389018aa-79c8-4a1e-5379-8b8e42939859@nvidia.com> <20200907171006.GD10272@e121166-lin.cambridge.arm.com> From: Vidya Sagar Message-ID: <81c9c1d7-db0e-d7b6-34cc-093ad79268bb@nvidia.com> Date: Mon, 5 Oct 2020 17:49:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: <20200907171006.GD10272@e121166-lin.cambridge.arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601900284; bh=+Kb7s0+T+7Dcwng7PbskdsRUPhXNDD+FmTLsUPshx1M=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=T5+I83Hq88Iv0G+ePpVXzICaAUUSNrkgPFrN4k3Ml62Am/fLpOJ2/iYASzqpyRytw 7y04cAhkvY/tNQx+2XrS+GABh/BlGxDQrN6voXS1zhbrUzWPRJeDoLLI1rD5SSoTR6 eDuSEUMoB+d0+dW9VE3V6YdUq4Pvt3m/mf2QxIllw375o3DdHwsfxHXQIxlnowMEUe t488gtsCOJ//KBZ0T3BfxdoEJDHjeny1NqRI45eiRTDvbesxUwt8/mzlM0dTCQdKPp ZbPiX0v4JH77DOyUDRZjUy5K1h4JHfh3/7Rn5kTp03N3Fl0cY9tGyTXh/5xzSVakZg 2YC9JzAFsG5PQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/2020 10:40 PM, Lorenzo Pieralisi wrote: > External email: Use caution opening links or attachments > > > On Mon, Jul 06, 2020 at 10:05:06AM +0530, Vidya Sagar wrote: >> >> >> On 18-Jun-20 12:26 AM, Vidya Sagar wrote: >>> >>> >>> On 02-Jun-20 10:37 PM, Gustavo Pimentel wrote: >>>> External email: Use caution opening links or attachments >>>> >>>> >>>> On Tue, Jun 2, 2020 at 11:9:38, Vidya Sagar wrote: >>>> >>>>> In this patch series, >>>>> Patch-1 >>>>> adds required infrastructure to deal with prefetchable memory region >>>>> information coming from 'ranges' property of the respective >>>>> device-tree node >>>>> separately from non-prefetchable memory region information. >>>>> Patch-2 >>>>> Adds support to use ATU region-3 for establishing the mapping >>>>> between CPU >>>>> addresses and PCIe bus addresses. >>>>> It also changes the logic to determine whether mapping is >>>>> required or not by >>>>> checking both CPU address and PCIe bus address for both prefetchable and >>>>> non-prefetchable regions. If the addresses are same, then, it is >>>>> understood >>>>> that 1:1 mapping is in place and there is no need to setup ATU mapping >>>>> whereas if the addresses are not the same, then, there is a need >>>>> to setup ATU >>>>> mapping. This is certainly true for Tegra194 and what I heard >>>>> from our HW >>>>> engineers is that it should generally be true for any DWC based >>>>> implementation >>>>> also. >>>>> Hence, I request Synopsys folks (Jingoo Han & Gustavo Pimentel >>>>> ??) to confirm >>>>> the same so that this particular patch won't cause any >>>>> regressions for other >>>>> DWC based platforms. >>>> >>>> Hi Vidya, >>>> >>>> Unfortunately due to the COVID-19 lockdown, I can't access my development >>>> prototype setup to test your patch. >>>> It might take some while until I get the possibility to get access to it >>>> again. >>> Hi Gustavo, >>> Did you find time to check this? >>> Adding Kishon and Alan as well to take a look at this and verify on >>> their platforms if possible. >> Hi Kishon and Alan, did you find time to verify this on your respective >> platforms? > > Yes please. I would like to merge this code, in preparation for that > to happen mind rebasing the series against my pci/dwc branch with > Rob's suggested changes implemented ? Hi, Apologies for the delay in reply. I was on leave and couldn't really look into it. I pushed a new patch on top of your pci/dwc branch at http://patchwork.ozlabs.org/project/linux-pci/patch/20201005121351.32516-1-vidyas@nvidia.com/ @Rob and @Lorenzo, please review it. Since I changed the subject, I pushed it as a new patch and not as V2 of the previous patch set. I hope this is fine. Thanks, Vidya Sagar > > Thanks a lot, > Lorenzo >