Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200922190807.6830-1-qiangqing.zhang@nxp.com>
 <20200922190807.6830-2-qiangqing.zhang@nxp.com> <20200929155201.GA665464@bogus>
 <20201003084656.GA29917@gofer.mess.org>
In-Reply-To: <20201003084656.GA29917@gofer.mess.org>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 5 Oct 2020 08:36:39 -0500
Message-ID: <CAL_JsqKEqG_Xous_gf=t9LTY8ZGzwcCYNjMDEGt8bA17JUgW-g@mail.gmail.com>
Subject: Re: [PATCH V3 1/2] bindings: media: gpio-ir-receiver: add
 linux,autosuspend-period property
To:     Sean Young <sean@mess.org>
Cc:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 3, 2020 at 3:46 AM Sean Young <sean@mess.org> wrote:
>
> On Tue, Sep 29, 2020 at 10:52:01AM -0500, Rob Herring wrote:
> > On Wed, Sep 23, 2020 at 03:08:06AM +0800, Joakim Zhang wrote:
> > > Add linux,autosuspend-period property for gpio ir receiver. Some cpuidle
> > > systems wake from idle may take a bit long time, for such case, need
> > > disable cpuidle temporarily.
> > >
> > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > > ---
> > > ChangeLogs:
> > > V1->V2:
> > >     * New add.
> > > V2->V3:
> > >     * linux,autosuspend-period = 125; -> linux,autosuspend-period = <125>;
> > > ---
> > >  Documentation/devicetree/bindings/media/gpio-ir-receiver.txt | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
> > > index 58261fb7b408..e1447c9b0e26 100644
> > > --- a/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
> > > +++ b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
> > > @@ -7,6 +7,8 @@ Required properties:
> > >  Optional properties:
> > >     - linux,rc-map-name: see rc.txt file in the same
> > >       directory.
> > > +        - linux,autosuspend-period: autosuspend delay time,
> > > +          the unit is milisecond.
> >
> > What makes this linux specific?
>
> Good point. "linux,autosuspend-period" does not say what is being
> suspended either. How about "cpuidle-suspend-period" instead?

'cpuidle' is a Linuxism. And you also need a unit suffix.

I'm not clear on how autosuspend which is generally how long a
peripheral is idle before runtime suspending it relates to this which
seems to be concerned with cpu wakeup latency. I'm assuming you need
to wake up within a certain time period to capture GPIO edges. Don't
you know what this time would be based on IR data rates and can
provide that constraint to cpuidle?

Also, we can set autosuspend times from sysfs. Why do you need to do
this from DT?

Rob