Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Oct 2020 09:03:28 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Vasily Gorbik <gor@linux.ibm.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        David Laight <David.Laight@aculab.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Julien Thierry <jthierry@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian
 cross compiles
Message-ID: <20201005140328.hpbpkfpx3hmpuapt@treble>
References: <20201002160114.7yb7z7aeijhchpwl@treble>
 <cover.thread-a8def4.your-ad-here.call-01601818410-ext-7687@work.hours>
 <patch-4.thread-a8def4.git-a8def4f04016.your-ad-here.call-01601818410-ext-7687@work.hours>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <patch-4.thread-a8def4.git-a8def4f04016.your-ad-here.call-01601818410-ext-7687@work.hours>
Precedence: bulk

On Sun, Oct 04, 2020 at 04:30:54PM +0200, Vasily Gorbik wrote:
> @@ -77,8 +78,9 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry,
>  	if (entry->feature) {
>  		unsigned short feature;
> 
> -		feature = *(unsigned short *)(sec->data->d_buf + offset +
> -					      entry->feature);
> +		feature = bswap_if_needed(*(unsigned short *)(sec->data->d_buf +
> +							      offset +
> +							      entry->feature));
>  		arch_handle_alternative(feature, alt);
>  	}
> ---
>  arch/x86/include/asm/orc_types.h              | 10 +++++
>  tools/arch/x86/include/asm/orc_types.h        | 10 +++++
>  .../arch/x86/include/arch_endianness.h        |  9 +++++
>  tools/objtool/check.c                         |  5 ++-
>  tools/objtool/endianness.h                    | 38 +++++++++++++++++++
>  tools/objtool/orc_dump.c                      |  5 ++-
>  tools/objtool/orc_gen.c                       |  3 ++
>  tools/objtool/special.c                       |  6 ++-
>  8 files changed, 80 insertions(+), 6 deletions(-)
>  create mode 100644 tools/objtool/arch/x86/include/arch_endianness.h
>  create mode 100644 tools/objtool/endianness.h
> 
> diff --git a/arch/x86/include/asm/orc_types.h b/arch/x86/include/asm/orc_types.h
> index fdbffec4cfde..5a2baf28a1dc 100644

This patch is misformatted.  Almost like it was concatenated with
itself?

-- 
Josh