Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3356344pxk; Mon, 5 Oct 2020 07:45:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4o7HSuuXb0fCfjzmBuz8cCe9iqeZ8rgTrW9B1NPaoRet+K9DaUiJV3Iuas+/UdX5wcfxv X-Received: by 2002:a05:6402:b53:: with SMTP id bx19mr18198764edb.161.1601909144166; Mon, 05 Oct 2020 07:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601909144; cv=none; d=google.com; s=arc-20160816; b=ChVG/umOI0HTmNdZfg/bboL2+yz5j+HQHjF6AQQ519CB1xP2ejLKPwFCb0/csiPgTx RRG1982W9NgqYPxXUh4orBi62HpfbJF9HsP5FTEkv7W32Oqz38r+sVkMKB4eoCvlwDwq CCbjj0vd8zPe0rM5NqslOdVHHtf1x4atlHST8RY2oJI+l52r5oOYPCJdBVUg9SLKLI2q WRR8vTW7z/Lqmt4Tx+cR3z7TqPOiHBakoQP2Hr95RNsoTjdXZF4tSlsq4ySQBE5OhSir eJJn/vloozoZgfUxKbNKBQmSMzD3xy+ojkUvSss2XllBKAgDU76q4PY2oc1UpOcd+pdR RdKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=F2fRX3F6phFrNzXyEO5ny8eJjv4EnilGQEx3qSo1EYA=; b=e1rTbMaFP6pbkRqHk4QSIhJjCYOvtHIJ1TDzjj9l4lY4S7G6OjyzjoASV5oaY9wEKn TCAdGT4Le9RV6oCHhIEgc7ruPL3ZmwtAixaBWBlbsJ+2wVpplg/QDAHNrTnemPXAAjyt LApoeLPTs/6fBUG46+Cfp/pc49PFYyDngt2NXXfCqHgTG7fEGt8MYhFQ1v48qK2+Ut+Q zFJP3nVoryHxAezz2yyOD43v6Ak4haQIErNWThSGwYe/CqOhLWDiaFY+1Ehs9a0xgzfQ dGOdjf47Nr0cGnwZ69uKTaoxo6A2iRyPI3RTGX2slKPJ1QHwi4UWj9BNW+PaSV4DcadH Bg/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=u7RAyaTF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p13si88032edh.353.2020.10.05.07.45.20; Mon, 05 Oct 2020 07:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=u7RAyaTF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgJEOmA (ORCPT + 99 others); Mon, 5 Oct 2020 10:42:00 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44812 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbgJEOl7 (ORCPT ); Mon, 5 Oct 2020 10:41:59 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 095EfJoK107006; Mon, 5 Oct 2020 09:41:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601908879; bh=F2fRX3F6phFrNzXyEO5ny8eJjv4EnilGQEx3qSo1EYA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=u7RAyaTFMVOMPDuG4pThU3VF9HyHIiDH+8qFYw9HnWTAVHq/1vqjfTzMYyrX4Vcv7 AcyKS7LW3VZcHb0nNU8BVgA59C04FAp6pE3QUcKmMzO3lloroRKp9JreSEjQO9VueI BBpZv4qknhXwikkIR1iFTwRI8xoZHnrqt+qeheOM= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 095EfJQX092644 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Oct 2020 09:41:19 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 5 Oct 2020 09:41:19 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 5 Oct 2020 09:41:19 -0500 Received: from [10.250.71.177] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 095EfHYV099554; Mon, 5 Oct 2020 09:41:17 -0500 Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access To: CC: Marek Behun , Pavel , Linux Kernel , Linux Leds References: <20201005141334.36d9441a@blackhole.sk> <3c5fce56-8604-a7d5-1017-8a075f67061e@ti.com> From: Dan Murphy Message-ID: <966c3f39-1310-dd60-6f33-0d9464ed2ff1@ti.com> Date: Mon, 5 Oct 2020 09:41:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gabriel On 10/5/20 9:38 AM, ultracoolguy@tutanota.com wrote: > I understand. So I should leave it like it was and do the rename in another patch? You should do the fix in one patch and leave the structure name alone. The structure naming if fine and has no benefit and actually will make it more difficult for others to backport future fixes. Unless Pavel finds benefit in accepting the structure rename. Dan