Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3392122pxk; Mon, 5 Oct 2020 08:33:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8BNvjfUUPVepCVt2b58PPnoGcfAhLE8+il9LdDqEptkTrAysKDwCgyqjChuItPVzeBaFu X-Received: by 2002:a17:906:2ac5:: with SMTP id m5mr308560eje.210.1601911992457; Mon, 05 Oct 2020 08:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601911992; cv=none; d=google.com; s=arc-20160816; b=dm3Vo7kicb/eGNZ+Udz8z+oUo84fXLALF1+/G3DYcVHB+13VHO6sPlSDSWF/spQnOy l2cv5/qyjaoHBhizvOcEjBlVog2/dL9EZ0S8m8G0x/4iD+AwoRbBxxOEEjBxb/uAfupv T5EN4JZTau1C29SBnu1vCpRvm7dUrKkyxm514gBVJtj8f976rPpZkCG4r5GzJnQ/Pj9Y d2A+oSM4/1tJkpR61u49h1Llmxd/ks1OaZqHbruQI3MzIW6SRT07ZxcNTS4AFaEydf4Z d0LuWpis7yYmhoYoU3lUi6np/niYgiqCCpVqR/iyshfCM6C3JULQOln4q0V/CtpsCcdO eejw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=zJlBMZLVQK99uxF6XScuil+96wjg9IWjq8L2Wv9P0jc=; b=mQ2V3bipWc2Wwt7rcPu0XsQZ8awhaEkREwMyZWrKjVQNJ66XteJYDLi3KxocRrRKYI tRi8mHFo9Sqct1F2GJnjEjLd2Yme3adyH2MnbWz+6OhGMIFOKtbfU6+jfOKk3lVhQ8BD cATq9wMyz0/Yjl2odDDH+YzJtDYyvEgRVUnyJsp1VSy/NpYgo0ImXbRIu0gbnkZr3hBr GWpgvCG/x3kwE0sKebb3yD5ai1H16wGPuau5MwjUuvB357mwxoc7JuOpd7Z1wNugs63W mPfFAhJSwI2HlgOxJyMjfFYNx2ZmsQ9ZD2uxMR8uxZyDYiGwEleRyT8DCKTOdy/BZqyx 3r+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="PbIuzA/a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y25si201464edu.509.2020.10.05.08.32.48; Mon, 05 Oct 2020 08:33:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="PbIuzA/a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbgJEPad (ORCPT + 99 others); Mon, 5 Oct 2020 11:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727765AbgJEPa1 (ORCPT ); Mon, 5 Oct 2020 11:30:27 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F08F4C0613CE; Mon, 5 Oct 2020 08:30:26 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id n61so8976357ota.10; Mon, 05 Oct 2020 08:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zJlBMZLVQK99uxF6XScuil+96wjg9IWjq8L2Wv9P0jc=; b=PbIuzA/aJIOaI17xWfF5gRvOaSslfutC3A+Ni7GIY81Aw9ExJjq5aVnJ/0TfKeqpJM MtzjHjKCjGLOQ9EZCXeQlkVFaz3hi84RCiKRPTFE8dwkV2ahlIlCtJyHwsHgMcxhzJlc 64O1iXzefN5CK+ZpfT5SSMceN4btNkivU8mCy4aM2YktAeK2M1aXvBdC6I440aRAVgw6 V5bV8EYJRhZlzVEYV3eDZOS8ZrHfrPPzaZhLRzxfxjUgqafrwLvtt2yCuYZwiB08dmmP Q3upGYRW4wz4A8oTn0VLz8GN5syYZs3uBbiL+i1G77BYM9poO/1v72PSCOmnUkKNc+CS Z43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zJlBMZLVQK99uxF6XScuil+96wjg9IWjq8L2Wv9P0jc=; b=bGF7QsL6ASDSnwM4H9VR4vNCtBR31ATQDOl5V0oHU/rxnvG/pMoDNQBoulsdQHakau wfQdFsiocl0O5ctvvC4QA430STAmOAf1Y+Nnm5W/mgM/290GzZfqqKk1Mln5aLwyorFx xQTDOkNTVOa3PXEMAq+1y9MDnilsMinCWwxlUFyagZ9tLJy3GxqTpu9IfYLhnjCTZzRl D/peazpG9mUSAaxk5abyvTSpfaKHY2GPMloA6lzop3iXqePVpVuOKgl1LjRiiSVFAYfq HC7ie5A7pcFIQRBSPieAzTmViInfpAK3ogRhjXuq0wVeCoEiWi7uhCHeMIJTGURMPAf8 Hvlg== X-Gm-Message-State: AOAM532LqMVR5Nwx/ycEWckE3EI+0jMJGRHhF98UQlCGvO2lZ4hvyOe8 PgcaNKhQsaa2GaJ/LNYXTAirOO2BKJg= X-Received: by 2002:a9d:3ee5:: with SMTP id b92mr12321966otc.156.1601911826378; Mon, 05 Oct 2020 08:30:26 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id f26sm570otq.50.2020.10.05.08.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 08:30:25 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue To: Greg KH Cc: ChiYuan Huang , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, cy_huang References: <1599060933-8092-1-git-send-email-u0084500@gmail.com> <20200902165713.GG56237@roeck-us.net> <63c7f5e4-eff2-1420-30a5-a0b98a7815e0@roeck-us.net> <20201002133145.GA3384841@kroah.com> <20201005110808.GA298743@kroah.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <88586992-650f-a4a1-2fa0-8cef313380fb@roeck-us.net> Date: Mon, 5 Oct 2020 08:30:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201005110808.GA298743@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/20 4:08 AM, Greg KH wrote: [ ... ] >>> What ever happened with this patch, is there still disagreement? >>> >> >> Yes, there is. I wouldn't have added the conditional without reason, >> and I am concerned that removing it entirely will open another problem. >> Feel free to apply, though - I can't prove that my concern is valid, >> and after all we'll get reports from the field later if it is. > > Ok, can I get an ack so I know who to come back to in the future if > there are issues? :) > Not from me, for the reasons I stated. I would be ok with something like: - if (tcpm_port_is_disconnected(port)) + if (tcpm_port_is_disconnected(port) || + (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2))) to narrow down the condition. Guenter