Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030245AbWHHT6I (ORCPT ); Tue, 8 Aug 2006 15:58:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030279AbWHHT6I (ORCPT ); Tue, 8 Aug 2006 15:58:08 -0400 Received: from smtp.osdl.org ([65.172.181.4]:47489 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030245AbWHHT6H (ORCPT ); Tue, 8 Aug 2006 15:58:07 -0400 Date: Tue, 8 Aug 2006 12:58:03 -0700 From: Andrew Morton To: Magnus Damm Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] i386: mark two more functions as __init Message-Id: <20060808125803.9aac260f.akpm@osdl.org> In-Reply-To: <20060808081756.334.46571.sendpatchset@cherry.local> References: <20060808081756.334.46571.sendpatchset@cherry.local> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 23 On Tue, 8 Aug 2006 17:17:00 +0900 (JST) Magnus Damm wrote: > i386: mark two more functions as __init > > cyrix_identify() should be __init because transmeta_identify() is. > tsc_init() is only called from setup_arch() which is marked as __init. > > These two section mismatches have been detected using running modpost on > a vmlinux image compiled with CONFIG_RELOCATABLE=y. > > -static void cyrix_identify(struct cpuinfo_x86 * c) > +static void __init cyrix_identify(struct cpuinfo_x86 * c) Are we sure? We end up putting a pointer to this into arch/i386/kernel/cpu/common.c:cpu_devs[], and that gets used from __cpuinit code. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/