Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3400261pxk; Mon, 5 Oct 2020 08:44:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYgPmn+pDaXuQFDiVMpc+0G478NpDoCKpVSTvt1BV26HCrCQb80OeRZns897fnxcq7ypGA X-Received: by 2002:aa7:d484:: with SMTP id b4mr259164edr.288.1601912699146; Mon, 05 Oct 2020 08:44:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601912699; cv=none; d=google.com; s=arc-20160816; b=PybAv+WoT3LvT0xIFW8KTwtBZA0cIKuAbRNKe6uqjTSGtpcCIrgLFq3NNLjTIvp0lN a4Z+qNvfoRwDnzjZ3i4CuJdwFE9yO7FHqpUV4bIlVo99FgK+AM69lvoGpMiEr7cOdPe9 xgHodpUGVQeArpYjOFs9fPBNI6X9D2IVg9+5phMW7bfMba0dhu9WFNKix1zG4560iQKU O8baQlbJrVyRoqeNvhc627BP0sTAMnV7Ey6xB9Q2sDtMSZcH+dJqH8C7EWNH1FwZ4tb2 yjPmQR3wIxS7gEEv13mm3p39R+o4yTEivlC7lm3+HMLlkgWml94MfDxCCJ21Y4vWtfcq l6wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=q2UhLRbeoGZUkswhmo4oFWT89ZkpFHcNHEtTToYnahI=; b=fKghgSG6xHzwPoMJFtK/eoMvUPyOjZxA6rWGOzC/TJyksczz+uJq1EX4EtqzFn4cdC V+0QhvefP+7TSvHwu31tPnFdK2MMTzHz5/WCVzhv3iAhulbipO4xfrf1RR9PKRsLtZcp O4KfLw6xUwQle9+RDLE/U1p4S+TzwKQ/HMeCeEA8Kr0/t8vIdC+YJkDkv5fpslqRvIU0 YT9ST0T35N05MMUZVmzq/xdB08HXqfBH/Qw7qXCaMYf6HfNYSsEmT9UGBElGkNnLQgXn BQWRR0Xq/KYt87RElk1DdmdAlyhUJ3jzx4drTzwx540AdX+Ztf10GE45kUn/iPfj5iNm n3yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=A2si45zd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si339ejb.40.2020.10.05.08.44.35; Mon, 05 Oct 2020 08:44:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=A2si45zd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbgJEPlw (ORCPT + 99 others); Mon, 5 Oct 2020 11:41:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:53718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbgJEP2j (ORCPT ); Mon, 5 Oct 2020 11:28:39 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 997DB20637; Mon, 5 Oct 2020 15:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601911719; bh=qOQeV9RGEa4LUUa7YjUZi3sJdySKG8IIz7seCuhc5jI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A2si45zdIDbh5cgl41ZMdFfsZgp15xCOIYAL/zzvVjHh/ir447p4XY9QgJo5XzzmR GeqANLXGBJV3BSQfdnUasUz2TDs1BvW66RF2BCOI4gE0ImjmTpRjLjV3QKkGGsZC4c bAVPW/iXHVsNXq8zbjrAs4IOHi+q26OD7Mm94pgw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, u.kleine-koenig@pengutronix.de, Ahmad Fatoum , Bartosz Golaszewski Subject: [PATCH 5.4 04/57] gpio: siox: explicitly support only threaded irqs Date: Mon, 5 Oct 2020 17:26:16 +0200 Message-Id: <20201005142110.016866225@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005142109.796046410@linuxfoundation.org> References: <20201005142109.796046410@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ahmad Fatoum commit 45ccf6556720293323c20cda717756014ff63007 upstream. The gpio-siox driver uses handle_nested_irq() to implement its interrupt support. This is only capable of handling threaded irq actions. For a hardirq action it triggers a NULL pointer oops. (It calls action->thread_fn which is NULL then.) Prevent registration of a hardirq action by setting gpio_irq_chip::threaded to true. Cc: u.kleine-koenig@pengutronix.de Fixes: be8c8facc707 ("gpio: new driver to work with a 8x12 siox") Cc: stable@vger.kernel.org Signed-off-by: Ahmad Fatoum Acked-by: Uwe Kleine-König Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-siox.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpio/gpio-siox.c +++ b/drivers/gpio/gpio-siox.c @@ -245,6 +245,7 @@ static int gpio_siox_probe(struct siox_d girq->chip = &ddata->ichip; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_level_irq; + girq->threaded = true; ret = devm_gpiochip_add_data(dev, &ddata->gchip, NULL); if (ret)