Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3449634pxk; Mon, 5 Oct 2020 09:55:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt3qunwekxpeX5BpGtjHBpQh7uH+rWTnTj/CG+qjIZp470w4GJJkjqNVspL4GEpIPlOKqB X-Received: by 2002:a50:9d0a:: with SMTP id v10mr616242ede.144.1601916937335; Mon, 05 Oct 2020 09:55:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601916937; cv=none; d=google.com; s=arc-20160816; b=RJN3ImX4KR02HE4HSys+Qa806E+TAodoFJherMwcb/4mEnuPTs3tZFPV4rBP67THfc pCEzeyMaKr/XY+6bVFtwpDkQINVvRoyQqMjPjR/Bo0/9AD5NbtT7Qtp/qNmEgZU95vDo RUvkmIN/IFtlIzXkvgjKcbzzlE4pEydnqDN4MRNCeUrtOzhgEErrPQ8onaU/X5wTATOP tvUFRnq0lUQQK8szc83oni1uprxFChkiTPQgWMjjWJvIVyJQ8h6dNNADyVDRXRy1Bj8y Pg6xhn4vLL/ZcQeJgieaT22S8VwJZjNxiAQXNSh76Ig4bQXqxcsg20EogIP/KH+vE6hM gWMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nAXjRv5p6xxj/y8bVYpvNSMDJXwOQHZIzVNqqKv+n3o=; b=sq7/hEYHosVDvxLFszZF6WCZGrkjmqtmneXNGOsdW2PhvalsnyoYvq+032TPwXYj0A cXBr7EQdxtcCPe90o+PV8PQ3D7NG52X9nFqJkzbC9rkppSaKSOkByyz/OJM20ByHbNIa oHc4jaXrcUQnLlNcrcfRRydWjy5hctLudNrGdg+8Qh63Z8PeRtqCgiL6sdEIIFQoQL3i ifJZjtlDpmYeLDXls4RGEm0U2S586VXB+xzRyI0RDZtixHiDdkVa8bIaam2pAcuCozBg ekuX+DF2l4l//LspdyTm0UR1SDZQ5gKmf/tXSKlTEkucekHU0EfEkAGtORpMCLOxwVY3 lbwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tdR/pyEe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si120034ejt.416.2020.10.05.09.55.13; Mon, 05 Oct 2020 09:55:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tdR/pyEe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727671AbgJEP3n (ORCPT + 99 others); Mon, 5 Oct 2020 11:29:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:55410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727611AbgJEP32 (ORCPT ); Mon, 5 Oct 2020 11:29:28 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0178620637; Mon, 5 Oct 2020 15:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601911768; bh=+xqO1hIRMT1BzyNoJJJ5hXgnkxkNhskRD9Xuy98+iq4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tdR/pyEeb7qDugbuno3GTeihQ63M7eh9o0dUPiqdAiW3BhgCHY1ZieKWf8Y0LuiaD nyGc8Ow38na8L+VSPJmRQQZ/SQPQe+ROF1rwSV0cPZDZnWGC/X5KWEWCj5pxagS3Qv moaKHq8NunMG+OElhCNsSAWYjdzy/3zar2t1HHaM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Packham , Mark Brown , Sasha Levin Subject: [PATCH 5.4 30/57] spi: fsl-espi: Only process interrupts for expected events Date: Mon, 5 Oct 2020 17:26:42 +0200 Message-Id: <20201005142111.253261848@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005142109.796046410@linuxfoundation.org> References: <20201005142109.796046410@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Packham [ Upstream commit b867eef4cf548cd9541225aadcdcee644669b9e1 ] The SPIE register contains counts for the TX FIFO so any time the irq handler was invoked we would attempt to process the RX/TX fifos. Use the SPIM value to mask the events so that we only process interrupts that were expected. This was a latent issue exposed by commit 3282a3da25bd ("powerpc/64: Implement soft interrupt replay in C"). Signed-off-by: Chris Packham Link: https://lore.kernel.org/r/20200904002812.7300-1-chris.packham@alliedtelesis.co.nz Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-fsl-espi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index f20326714b9d5..215bf6624e7c3 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -555,13 +555,14 @@ static void fsl_espi_cpu_irq(struct fsl_espi *espi, u32 events) static irqreturn_t fsl_espi_irq(s32 irq, void *context_data) { struct fsl_espi *espi = context_data; - u32 events; + u32 events, mask; spin_lock(&espi->lock); /* Get interrupt events(tx/rx) */ events = fsl_espi_read_reg(espi, ESPI_SPIE); - if (!events) { + mask = fsl_espi_read_reg(espi, ESPI_SPIM); + if (!(events & mask)) { spin_unlock(&espi->lock); return IRQ_NONE; } -- 2.25.1