Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3451742pxk; Mon, 5 Oct 2020 09:59:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0Dh/PsmMwltY4++dg0sd+BKnBjc0qGrSOtn74kxR95ojVWP/KAwRzwjMj5lk9PGBiNj2e X-Received: by 2002:a17:906:3aca:: with SMTP id z10mr627714ejd.419.1601917155650; Mon, 05 Oct 2020 09:59:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601917155; cv=none; d=google.com; s=arc-20160816; b=SWjiZJECN1cMurMLjMKRZS8/ipJJSty1LlULlPk+p8RlTausSezpbnFOUFzmf6Egns FFHROqvEF2lboP8P0JPbKXWZrQm81SEFrhOcIXa0Vl+cdSL6GI6idGx145XJNuAdc8WB yl2wAWWH2J3SnhvbgYSugcNG1rWJ2zh61eJ+9o3y7cAlrasgPey6EMDeIPTSDjvJRBAe IKB6++Qa7oOxZwKKQCIDPRLd8pegydlxtnmLcbrbYXZLGeIVGmD8lI15kHK22ueb0jyh XCuZ140v6cCYB95lKCL4om6dZCt8UWW44Wjx+0bHWMTRjYgewXhPLwIEpOQn5cj+28Jj xaZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OjfWNGBFsyUCHvU9DA+5k3rGdZwYFPOWFWahX7OdzMs=; b=rEA+m2km/CGBENqz0tb8+NOTUEsU1CzuaTbTr2FkuY0EM9prv36t+talvDcdL5CWZR 3DuZ/j/OsUTxwVyAZVFOPQegeyCHq5BcVGhHAOH2pyNB5hOK/sICwI5BR0xg8nN6aasV ELhvJ2cm/YS+9xW0Zkjq24Oc+ST0bInGbzTmfSsAIbcG1wLKvgil9n42oYSVzKjmvioe R9cUc4azChrI/ez0DLTCG44gyu6fjOLF4tl6Vtulpmgc8N0S4tH0mdA849V60r4SyUJA txoI699xizO+NFU+EprJ5OP84j3XJgeI/UEIdbAxLYFaSz+zJbEFfV9VZsE0Vgh3UCxP XavQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dQYtqG2d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x1si409592edc.73.2020.10.05.09.58.52; Mon, 05 Oct 2020 09:59:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dQYtqG2d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728734AbgJEPkO (ORCPT + 99 others); Mon, 5 Oct 2020 11:40:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:55642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbgJEP3g (ORCPT ); Mon, 5 Oct 2020 11:29:36 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4EEE20637; Mon, 5 Oct 2020 15:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601911776; bh=T/R0tIidZY84WWFveEGhxfzHZ8KfK/SjINpJJbe+YBc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dQYtqG2d1KaNEhOto19xRobfNFc3/azWq2z/pCz90R1Hf7C4wP3BuI2MF5UBkXs4h lx2geicU65MUavCUs2FU4j4EgCee2pyKbGsYlvBnvH4ZmckP//VRLDDfTwrEPIFXUv nXuW8N2Khj/OxzcRBjYxPReGZsAVNyFko+TATgZk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Taiping Lai , Chunyan Zhang , Baolin Wang , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.4 33/57] gpio: sprd: Clear interrupt when setting the type as edge Date: Mon, 5 Oct 2020 17:26:45 +0200 Message-Id: <20201005142111.401645914@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005142109.796046410@linuxfoundation.org> References: <20201005142109.796046410@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Taiping Lai [ Upstream commit 5fcface659aab7eac4bd65dd116d98b8f7bb88d5 ] The raw interrupt status of GPIO maybe set before the interrupt is enabled, which would trigger the interrupt event once enabled it from user side. This is the case for edge interrupts only. Adding a clear operation when setting interrupt type can avoid that. There're a few considerations for the solution: 1) This issue is for edge interrupt only; The interrupts requested by users are IRQ_TYPE_LEVEL_HIGH as default, so clearing interrupt when request is useless. 2) The interrupt type can be set to edge when request and following up with clearing it though, but the problem is still there once users set the interrupt type to level trggier. 3) We can add a clear operation after each time of setting interrupt enable bit, but it is redundant for level trigger interrupt. Therefore, the solution is this patch seems the best for now. Fixes: 9a3821c2bb47 ("gpio: Add GPIO driver for Spreadtrum SC9860 platform") Signed-off-by: Taiping Lai Signed-off-by: Chunyan Zhang Reviewed-by: Baolin Wang Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-sprd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-sprd.c b/drivers/gpio/gpio-sprd.c index d7314d39ab65b..36ea8a3bd4510 100644 --- a/drivers/gpio/gpio-sprd.c +++ b/drivers/gpio/gpio-sprd.c @@ -149,17 +149,20 @@ static int sprd_gpio_irq_set_type(struct irq_data *data, sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0); sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0); sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 1); + sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1); irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_FALLING: sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0); sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0); sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 0); + sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1); irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_BOTH: sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0); sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 1); + sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1); irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_LEVEL_HIGH: -- 2.25.1