Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [EXTERNAL] Re: [PATCH v5 2/2] power: supply: bq256xx: Introduce
 the BQ256XX charger driver
To:     Sebastian Reichel <sre@kernel.org>
CC:     <robh+dt@kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dmurphy@ti.com>
References: <20201001214034.5925-1-r-rivera-matos@ti.com>
 <20201001214034.5925-3-r-rivera-matos@ti.com>
 <20201003105448.eqeyfpr7dugsp4in@earth.universe>
From:   Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Message-ID: <8ff0ba7b-d310-f7e3-bfcb-3bb2079344d2@ti.com>
Date:   Mon, 5 Oct 2020 12:33:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201003105448.eqeyfpr7dugsp4in@earth.universe>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Sebastian,

On 10/3/20 5:54 AM, Sebastian Reichel wrote:
> Hi Ricardo,
>
> On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote:
>> The BQ256XX family of devices are highly integrated buck chargers
>> for single cell batteries.
>>
>> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
>>
>> v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset() calls
>> ---
> changes look good, but you are still missing
> usb_unregister_notifier() calls on drival removal.
ACK, I will add a driver removal function and make the appropriate 
usb_unregister_notifier() calls.
>
> -- Sebastian
Ricardo