Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3487895pxk; Mon, 5 Oct 2020 10:55:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPJiSHlFUAFDGLDoc0OuprNzMLfSg3atBQbRRXbWkfv/BkiWqUoR7HHo4cFDWxaGnPnLgj X-Received: by 2002:a17:906:a282:: with SMTP id i2mr908788ejz.39.1601920518261; Mon, 05 Oct 2020 10:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601920518; cv=none; d=google.com; s=arc-20160816; b=zKtmyr+bntMnpC08QIKDgKMV3Jviab+Na51o2b2FAnibCpQiMUKVF6Y1IPPCmyPWiM z2lYgSL0pElJ+J3UAs+y3KLlqMXje3dm2NVBOuoJUvNIh+2ND7jAiNpE+u6sCB+7JDb9 4cU7swySKKD78Xi3IZO3QvHjjiQA4p0rPBlGqNu+xAGDpB5w5d4ZxreFpqXeySJN9uSg 7Ls74mTsjQR2xduK8tWayddH/4ndtZEzV4spwoj0aUrTsjgbnsO/E/RrKXESwlBHEv/7 MdBF/GB/EWlLwgSpG80HRcfYB4ANtgK/H7x/1l/QgUmOspFuVfcybCwBmYI/EBMsOBV0 iOzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7wBHOKqAVY/TIwlQLiaf/bCoDDVvVqftXBrsOnYNkZE=; b=iF1rJHIsRxK7uFPdSYyXzlJlZ/P4UvmCVzmKL6eGbpYoKEWWMng8YNWCB898a/48fY 5+NFts3SWnpmuuVwScmhLpCwSFT2qWyUR3ta+24yVIaG8EV4tk1y3wGzhkx389QRlpny KXLu74P/jNIvsHUaVvAAmEUCRKCMh34Dpt3aZNg9I9FSqT24PCHI+O6BLvjeOhXbyy8o 7dE39aCTNJrOTOT+Fiu40l27CnfInhhi/61h8UsqJelDUE74Xjj4HhcdtXrxNblj+i9t /xisx8Zsaz54iZawRW2u6s6HIGgWpCngWkl1SUMi1FQ0c/DBJqYibPNG6kXPjuMd8b1L ZQfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=duDwl6Ib; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v20si499008edy.422.2020.10.05.10.54.55; Mon, 05 Oct 2020 10:55:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=duDwl6Ib; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728116AbgJEP42 (ORCPT + 99 others); Mon, 5 Oct 2020 11:56:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:10926 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbgJEP42 (ORCPT ); Mon, 5 Oct 2020 11:56:28 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 095FWqNn151652; Mon, 5 Oct 2020 11:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=7wBHOKqAVY/TIwlQLiaf/bCoDDVvVqftXBrsOnYNkZE=; b=duDwl6Ibbxk26vimL0lz2EZHOUuXHGQwP08119IoMqH9M5hMhw4hv0vSx5YP+4ONB1fD J7ZPlwpuc71WlDlH7xIdO4ZeVZNfht1tA40zDUM4opHiGPRcx/BSiHXUswKWx1w1y0xL 2UmWiAuQCnGjS5x97ijAcoLY+LCngLxMd8sfh2stiy6I9cPRUgmd4Kk6qLDEgL+y+SuG Gzf4G+DSJTNe0LIxfL3rxGskJrIFDjp7NVrYxMQIM2tsaYcxnoopaJ13gDiUiPG/ZsOB tReyXQFIRZADrBOwkGNu57I05+mhWlltyKDgB8MfFJQOPY25wUdhKngOkPDLxrhYyTgn AA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 340527uenc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Oct 2020 11:56:15 -0400 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 095FXFQ4154233; Mon, 5 Oct 2020 11:56:15 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 340527uemn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Oct 2020 11:56:14 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 095FlP66028100; Mon, 5 Oct 2020 15:56:13 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma04ams.nl.ibm.com with ESMTP id 33xgx82b61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Oct 2020 15:56:12 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 095FuAdR25887062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Oct 2020 15:56:10 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D576711C05C; Mon, 5 Oct 2020 15:56:10 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B51711C04A; Mon, 5 Oct 2020 15:56:10 +0000 (GMT) Received: from localhost (unknown [9.145.67.211]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 5 Oct 2020 15:56:10 +0000 (GMT) Date: Mon, 5 Oct 2020 17:56:08 +0200 From: Vasily Gorbik To: Josh Poimboeuf Cc: Peter Zijlstra , Thomas Gleixner , Masami Hiramatsu , David Laight , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Miroslav Benes , Alexandre Chartre , Julien Thierry , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian cross compiles Message-ID: References: <20201002160114.7yb7z7aeijhchpwl@treble> <20201005140328.hpbpkfpx3hmpuapt@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201005140328.hpbpkfpx3hmpuapt@treble> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-05_10:2020-10-05,2020-10-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 suspectscore=1 priorityscore=1501 mlxlogscore=901 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010050115 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2020 at 09:03:28AM -0500, Josh Poimboeuf wrote: > On Sun, Oct 04, 2020 at 04:30:54PM +0200, Vasily Gorbik wrote: > > @@ -77,8 +78,9 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry, > > if (entry->feature) { > > unsigned short feature; > > > > - feature = *(unsigned short *)(sec->data->d_buf + offset + > > - entry->feature); > > + feature = bswap_if_needed(*(unsigned short *)(sec->data->d_buf + > > + offset + > > + entry->feature)); > > arch_handle_alternative(feature, alt); > > } > > --- > > arch/x86/include/asm/orc_types.h | 10 +++++ > > tools/arch/x86/include/asm/orc_types.h | 10 +++++ > > .../arch/x86/include/arch_endianness.h | 9 +++++ > > This patch is misformatted. Almost like it was concatenated with > itself? Indeed. I wonder how that could have happened. Sorry for that. I've resent patches with rebased patch "objtool: avoid ../ headers includes and name clashes" on top. This time I checked patches could be applied from outgoing mailbox before sending it.