Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3560841pxk; Mon, 5 Oct 2020 12:58:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjiplPl7qiMA+6/ibCBm4DOvZuBuQsRuLqjM0xbBpcr4DiVb1npoWCn9ob5HFd7jQIR7x8 X-Received: by 2002:a17:906:53d7:: with SMTP id p23mr1457077ejo.232.1601927907920; Mon, 05 Oct 2020 12:58:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601927907; cv=none; d=google.com; s=arc-20160816; b=zyeAmLdp5c2oIagWQRbtemDXnGCQiW5MLiRA3H1FCbYjfa1w8tj17EgJ+ZXok7eYgg CTZpO9R3o14EL0ILaPjz8EgUZ6O8+ZBenaDBYnD7p37Lq49KlPlENUJ1zCn61iRzeBnl 94bgwIQ5HlWI9apxB1mCla/gxhafjPlYUtIo4P8+NV3PLyTu1g1N3KJsWC5jg6L799bW k2iUVlLO0bnvgjMaJqg8sW1mQQ9jRNe3bkmOKJfVXcSI2gxKxJ4bcfm5uxIk/9ZFB6HG 6Z3CNpLtM00SHgSwTbb6pE24B8Xbf2TSOwH6orl5NsPPRafqeT1yZ8UFGZDsOGMOUHHr 3a0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=ovX9YsSxewu/w+FCBYir0ZxD+dcBAO9/UrZTlR2RAj8=; b=qTfIeYTGyJbpgqomaPmFRc7qLCvFwUpIO0ReT7k6lokwIg7QhsZgu6u2UJJjYGbG4U HAsiacwl18t4ApUVputwhiLMyb1UI3qU9z91qSP0mUGpPYfRy5aQYK0MTxgQThAcFvKs ITUSqvj/A4gI+yImnm7CM/DQGFTVcYxN6sqFq8Vi1v0JRMk3Cjx42HgGn/40gO85WGT3 SGn0q2yTIKEHN/vyRHLHZBdGElZDL/AZp5hD+9i4Cn+Gc7LZPTiEL/qfjWJXA1KojxyM tQk/7FoStGEuN8KP2z0ZwHrOd2ZmUTvcDDAA2L5348A5Np7kTz9p+ViVsbJ2P8uIW1Qu JUhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si513115ejc.668.2020.10.05.12.58.03; Mon, 05 Oct 2020 12:58:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729531AbgJETz7 (ORCPT + 99 others); Mon, 5 Oct 2020 15:55:59 -0400 Received: from mga01.intel.com ([192.55.52.88]:42027 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729489AbgJETzy (ORCPT ); Mon, 5 Oct 2020 15:55:54 -0400 IronPort-SDR: oOb/qjoUubOY4mdg4Jm46SdoBitMgepHPkMNo3nb8wXlqDA/JtsIdCeqT+teDGqHnUuhVh9AOd UfGxuB607UFg== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="181660130" X-IronPort-AV: E=Sophos;i="5.77,340,1596524400"; d="scan'208";a="181660130" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 12:55:38 -0700 IronPort-SDR: Qn6dcXyLS9GLxdy9yfod/VbkNOasp1nJSKcc4UGx8m5yfFHOpyna3foH/aVvptK8KO5ec9W/oh YLRX3kjIi0AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,340,1596524400"; d="scan'208";a="353550141" Received: from sjchrist-coffee.jf.intel.com ([10.54.74.160]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2020 12:55:36 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Graf , Aaron Lewis , Peter Xu Subject: [PATCH 0/2] KVM: VMX: x2APIC + APICV MSR fix and cleanup Date: Mon, 5 Oct 2020 12:55:30 -0700 Message-Id: <20201005195532.8674-1-sean.j.christopherson@intel.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch 1 is an unofficial patch from Peter to fix x2APIC MSR interception on non-APICV systems. As Peter suggested, it really should be squashed with commit 3eb900173c71 ("KVM: x86: VMX: Prevent MSR passthrough when MSR access is denied"). Without the fix, KVM is completely busted on non-APICV systems. Patch 2 is a cleanup of sorts to revert back to the pre-filtering approach of initializing the x2APIC MSR bitmaps for APICV. Note, I haven't tested on an APICV system. My APICV system appears to have crashed over the weekend and I haven't yet journeyed back to the lab to kick it. Peter Xu (1): KVM: VMX: Fix x2APIC MSR intercept handling on !APICV platforms Sean Christopherson (1): KVM: VMX: Ignore userspace MSR filters for x2APIC when APICV is enabled arch/x86/kvm/vmx/vmx.c | 45 ++++++++++++++++++++++++++++-------------- 1 file changed, 30 insertions(+), 15 deletions(-) -- 2.28.0