Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Oct 2020 16:35:00 -0700
From:   dmitry.torokhov@gmail.com
To:     Kenny Levinsen <kl@kl.wtf>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: evdev - per-client waitgroups
Message-ID: <20201005233500.GM1009802@dtor-ws>
References: <20200429184126.2155-1-kl@kl.wtf>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200429184126.2155-1-kl@kl.wtf>
Precedence: bulk

Hi Kenny,

On Wed, Apr 29, 2020 at 08:41:26PM +0200, Kenny Levinsen wrote:
> All evdev clients share a common waitgroup. On new input events, this
> waitgroup is woken once for every client that did not filter the events,

I am having trouble parsing the changelog (I think I agree with the
change itself).  Did you mean to say "this waitqueue wakes up every
client, even ones that requested to filter out events that are being
delivered, leading to duplicated and unwanted wakeups"?

> leading to duplicated and unwanted wakeups.
> 
> Split the shared waitgroup into per-client waitgroups for more
> fine-grained wakeups.
> 

Thanks.

-- 
Dmitry