Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: xN80ggBTnk2s+KXO5FLY7yVwonqfKLMFI5Dsw5rLSNdum/UJ7p63JInxyAbq1eH0K7h0pQ1xPo
 9GHCc5F2dmaw==
IronPort-SDR: pT9iXre9Jqwzyx6zuAsQfhPx3bEqXFkkKIL4mEgKcjLdyNe/mSG7p/dE9kOIGIjWcNDXUHh7nL
 p+PQlh7fGJ4g==
From:   "Cao, Bingbu" <bingbu.cao@intel.com>
To:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] media: ov2740: select regmap
Thread-Topic: [PATCH] media: ov2740: select regmap
Thread-Index: AQHWlsbwPyG+AAYGwUOM+lO0BRzte6mJ8jCw
Date:   Tue, 6 Oct 2020 03:22:35 +0000
Message-ID: <DM6PR11MB3995D488E86C6AD842AF090E990D0@DM6PR11MB3995.namprd11.prod.outlook.com>
References: <20200930011322.97179-1-sergey.senozhatsky@gmail.com>
In-Reply-To: <20200930011322.97179-1-sergey.senozhatsky@gmail.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: caa0805f-ec47-4a90-a8a6-08d869a71210
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 03:22:35.5072
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: epEuPEeRu9uyzR4k17WPI37XQjN9CctccEvzj+AaPKlyHno7/3GO5rfjHoSEuQi7n2VtlevWmGsBWwe3Gk7Rmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3292
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sergey, thanks for your patch.

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

________________________
BRs, =20
Bingbu Cao                         =20


> -----Original Message-----
> From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Sent: Wednesday, September 30, 2020 9:13 AM
> To: Mauro Carvalho Chehab <mchehab@kernel.org>; Cao, Bingbu
> <bingbu.cao@intel.com>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>; linux-media@vger.kernel.=
org;
> linux-kernel@vger.kernel.org; Sergey Senozhatsky
> <sergey.senozhatsky@gmail.com>
> Subject: [PATCH] media: ov2740: select regmap
>=20
> Fix OV2740 build breakage by selecting REGMAP_I2C config:
>=20
> ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_conf=
ig'
>         struct regmap_config regmap_config =3D { };
>                              ^
> ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
>         struct regmap_config regmap_config =3D { };
>                ^
> ov2740.c:1028:11: error: implicit declaration of function
> 'devm_regmap_init_i2c'
>         regmap =3D devm_regmap_init_i2c(client, &regmap_config);
>=20
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
>  drivers/media/i2c/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index
> 878f66ef2719..c64326ca331c 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -877,6 +877,7 @@ config VIDEO_OV2740
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select V4L2_FWNODE
> +	select REGMAP_I2C
>  	help
>  	  This is a Video4Linux2 sensor driver for the OmniVision
>  	  OV2740 camera.
> --
> 2.28.0