Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201005183830.486085-1-robh@kernel.org> <20201005183830.486085-2-robh@kernel.org>
In-Reply-To: <20201005183830.486085-2-robh@kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 6 Oct 2020 09:37:43 +0200
Message-ID: <CAMuHMdXjBSzbs4yAPJ-XUTBRZWKN61hO8vQ1-nGN5nAo7JnV-w@mail.gmail.com>
Subject: Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'
To:     Rob Herring <robh@kernel.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        USB list <linux-usb@vger.kernel.org>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linux PWM List <linux-pwm@vger.kernel.org>,
        linux-iio@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Sebastian Reichel <sre@kernel.org>, linux-ide@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Pavel Machek <pavel@ucw.cz>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        Lee Jones <lee.jones@linaro.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        linux-leds@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
        linux-rtc@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        Marc Zyngier <maz@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        linux-input@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        linux-hwmon@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
        Jason Cooper <jason@lakedaemon.net>,
        Linux PM list <linux-pm@vger.kernel.org>,
        linux-can@vger.kernel.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Jens Axboe <axboe@kernel.dk>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Linux MMC List <linux-mmc@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux I2C <linux-i2c@vger.kernel.org>,
        Vinod Koul <vkoul@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Richard Weinberger <richard@nod.at>,
        dmaengine <dmaengine@vger.kernel.org>,
        MTD Maling List <linux-mtd@lists.infradead.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jonathan Cameron <jic23@kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob,

On Mon, Oct 5, 2020 at 8:39 PM Rob Herring <robh@kernel.org> wrote:
> This doesn't yet do anything in the tools, but make it explicit so we can
> check either 'unevaluatedProperties' or 'additionalProperties' is present
> in schemas.
>
> 'unevaluatedProperties' is appropriate when including another schema (via
> '$ref') and all possible properties and/or child nodes are not
> explicitly listed in the schema with the '$ref'.
>
> This is in preparation to add a meta-schema to check for missing
> 'unevaluatedProperties' or 'additionalProperties'. This has been a
> constant source of review issues.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

>  Documentation/devicetree/bindings/bus/renesas,bsc.yaml       | 2 ++
>  .../bindings/memory-controllers/renesas,rpc-if.yaml          | 2 ++
>  Documentation/devicetree/bindings/net/renesas,ether.yaml     | 2 ++
>  Documentation/devicetree/bindings/serial/renesas,hscif.yaml  | 2 ++
>  Documentation/devicetree/bindings/serial/renesas,sci.yaml    | 2 ++
>  Documentation/devicetree/bindings/serial/renesas,scif.yaml   | 2 ++
>  Documentation/devicetree/bindings/serial/renesas,scifa.yaml  | 2 ++
>  Documentation/devicetree/bindings/serial/renesas,scifb.yaml  | 2 ++
>  Documentation/devicetree/bindings/spi/renesas,hspi.yaml      | 2 ++
>  Documentation/devicetree/bindings/spi/renesas,rspi.yaml      | 2 ++
>  Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml  | 2 ++

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
> @@ -85,6 +85,8 @@ required:
>    - clocks
>    - pinctrl-0
>
> +unevaluatedProperties: false

This one has received an "additionalProperties: false" in commit
41506bff84f1563e ("dt-bindings: net: renesas, ether: Improve schema validation")
in net-next, which you probably want to remove.

> +
>  examples:
>    # Lager board
>    - |

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds