Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp102365pxu; Tue, 6 Oct 2020 01:40:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLVDw54iGalS2PaSyQhOQBJI7Bc27UjvJU3IzfQBhG/pEtRRq48N14nNLTaH21Lkz5lgSN X-Received: by 2002:a17:906:7fcb:: with SMTP id r11mr3801494ejs.519.1601973630309; Tue, 06 Oct 2020 01:40:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601973630; cv=none; d=google.com; s=arc-20160816; b=ErHHPczq7OArmV+1Xz5yf69SJH0nWEK9G/3LXAnyA9CmbepvtlEg+1WxSNq2q3Wys1 ldY7K337kofRAi9JrR7PxsiN7T/3sjuzT+69lgbePOxEdY4sSk+9l25QDKxqRs49YeIr reTLuc1CwGXXIB9jI6NQiE8kwdlzXKCIPEvWsCQTikF7jtS6BpAkeuahCUjvl9fZopXg RPSdsBSuGMP+Z4pgsoNl9EAYb2RFR8Df10JMx8p4dC2PSoGyKAOOnxxYTB7R3eB8ya32 qxi2xl/ovW8wuttMRUulE86SFNdhHPAwNRROIw4aEBvhk4oYezPGGbuXFTorHjvyAuoZ LqSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gWs/lPE2i/OF/DrPdvnJHXbiH0OnG2x6H7UkOFuk3vw=; b=rhmIsi6iDVakKIf2E2eqWsoCFaoE8Yli3QzEx8LBsGHKJjTILAD1hmnVV21T90vgJV o9m4EjXHktFCjbPzyfr8FQXMFTntCnNxnA4s0Urknb4ukS8H5TH1UBS6W1szX+KHmHFb t/FcRt01uA6TzM5OlJOugo7pauRds5nK1+cJUwcnredYlNcRAjqVIh2xZWGsnFuaGCOF piVGUo/o3NF0myhT+O9CP9ObcCL70eXTnOVBWJACfaBfH9emzT8GYv1OxfGVbNRhqMIe QtsX0K1zpW8zIyrXhJJ+OgPZpdtbIgm9oKTFWjFYxS3Vxpzgacq0Cy0SWUOxptmtqzku B4zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Wp5R9pGn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu15si1930443edb.481.2020.10.06.01.40.07; Tue, 06 Oct 2020 01:40:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Wp5R9pGn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726000AbgJFIfD (ORCPT + 99 others); Tue, 6 Oct 2020 04:35:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgJFIfD (ORCPT ); Tue, 6 Oct 2020 04:35:03 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63C0C061755 for ; Tue, 6 Oct 2020 01:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gWs/lPE2i/OF/DrPdvnJHXbiH0OnG2x6H7UkOFuk3vw=; b=Wp5R9pGnwR6MqXSTvsoSJGAp3X Wes0zsq6DJzOqzpjw+W+DDDqs1w82SHDjdYsFbPSXtcLm0B3lASHEh6itZTwTnVWI/Pq3v/Fiyv/O IT42zlvS7SxlQ7/pcpxR46oQTQ+KwrcyAUOO0lvD+KYk1gjLrTpZl1D0DmKZ2cEG8vNvhWuBvgwQL fTusFM+SIffRyRzmqLSjHstDYyFbg0SobobZCF3Xv5/z9wAIsohzjFNymahe71Y3e/0bhYI/50muf 5EXkZlxedkoRx7M9lgoSogELNDyaT9TkgLxZL3U92W4kwim4py8MJCztpSoxIYdcmcerzJoc/+kb3 yMvbLIbg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPiQK-0008Mh-3I; Tue, 06 Oct 2020 08:34:16 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AEACA300B22; Tue, 6 Oct 2020 10:34:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7252C28B30F6A; Tue, 6 Oct 2020 10:34:15 +0200 (CEST) Date: Tue, 6 Oct 2020 10:34:15 +0200 From: Peter Zijlstra To: Andy Lutomirski Cc: x86@kernel.org, LKML , "Christopherson, Sean J" Subject: Re: [PATCH 2/2] x86/entry/32: Remove leftover macros after stackprotector cleanups Message-ID: <20201006083415.GO2628@hirez.programming.kicks-ass.net> References: <1469babd36eb342aaa5e274a73a49293fad75272.1601925251.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469babd36eb342aaa5e274a73a49293fad75272.1601925251.git.luto@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2020 at 12:30:04PM -0700, Andy Lutomirski wrote: > .macro SAVE_ALL pt_regs_ax=%eax switch_stacks=0 skip_gs=0 unwind_espfix=0 > cld > .if \skip_gs == 0 > - PUSH_GS > + pushl $0 > .endif > pushl %fs > Is there a good reason not to just push gs into it? It might be nice if pt_regs is complete.