Subject: Re: [PATCH] CONFIG_RELOCATABLE modpost fix
From: Magnus Damm <magnus@valinux.co.jp>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, fastboot@lists.osdl.org,
       ebiederm@xmission.com
In-Reply-To: <20060808183954.GA8300@mars.ravnborg.org>
References: <20060808083307.391.45887.sendpatchset@cherry.local>
	 <20060808183954.GA8300@mars.ravnborg.org>
Content-Type: text/plain
Date: Wed, 09 Aug 2006 10:32:36 +0900
Message-Id: <1155087156.4341.66.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1265
Lines: 33

Hi again Sam,

On Tue, 2006-08-08 at 20:39 +0200, Sam Ravnborg wrote:
> On Tue, Aug 08, 2006 at 05:32:11PM +0900, Magnus Damm wrote:
> > CONFIG_RELOCATABLE modpost fix
> > 
> > Run modpost on vmlinux regardless of CONFIG_MODULES.
> Below is my take on this one.
> - Dropped -rR since this is default now
> - Dropped subdir- assignment in scripts/Makefile since it is redundant
> - Always pass vmlinux ti modpost so we have full updated info
> - Print out number of modules being mod posted to distingush from
>   vmlinux one
> - use vmlinux as target name to enable nicer quiet command print

Your patch seems to work as expected if I add a return 0 at the end of
modpost.c:secref_whitelist(). I like how you printed out the number of
modules being processed. I have one minor comment about your patch:

Modpost seems to get run twice on vmlinux if the kernel is built with
"make all". I think it would be best to run modpost on vmlinux only when
vmlinux is built - never when modules are processed.

Thanks,

/ magnus


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/