Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Oct 2020 01:08:21 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Shreyas Joshi <shreyas.joshi@biamp.com>, rostedt@goodmis.org,
        shreyasjoshi15@gmail.com, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] printk: handle blank console arguments passed in.
Message-ID: <20201006160821.GA430@jagdpanzerIV.localdomain>
References: <MN2PR17MB31979437E605257461AC003DFCF60@MN2PR17MB3197.namprd17.prod.outlook.com>
 <20200522065306.83-1-shreyas.joshi@biamp.com>
 <20200522100046.GH3464@linux-b0ei>
 <20201006025935.GA597@jagdpanzerIV.localdomain>
 <f19c18fd-20b3-b694-5448-7d899966a868@roeck-us.net>
 <20201006065907.GA528@jagdpanzerIV.localdomain>
 <20201006095435.GC32369@alley>
 <20201006133319.GA178176@jagdpanzerIV.localdomain>
 <7d512002-e33c-198f-52df-a89a30bc665b@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7d512002-e33c-198f-52df-a89a30bc665b@roeck-us.net>
Precedence: bulk

On (20/10/06 07:22), Guenter Roeck wrote:
> On 10/6/20 6:33 AM, Sergey Senozhatsky wrote:
> > On (20/10/06 11:54), Petr Mladek wrote:
> >> On Tue 2020-10-06 15:59:07, Sergey Senozhatsky wrote:
> >>> On (20/10/05 20:35), Guenter Roeck wrote:
> >>>> On a side note, I don't see the problem presumably fixed with this
> >>>> patch in any of my tests.
> >>>
> >>> Hmm. This is rather interesting. Empty console= certainly oops-es my laptop,
> >>
> >> Just by chance. Do you have any log with the Oops? Or does it die
> >> silently?
> > 
> > The laptop in question has fbdev and no serial. It dies with blank screen.
> > I'll try to dig it and get some backtrace or anything useful.
> > 
> 
> Some versions of systemd (and possibly other distributions) apparently
> react allergic if no console is present. See [1]. Maybe that is what
> happens with your laptop ?

Seems to be crashing before /init

> That exchange leads to the question what should be done with /dev/console
> if there is no console. On Chromebooks we see an error when trying
> to open it if I recall correctly.

A wild guess:

Devices that you test, do they have 'blah blah  console=  blah blah'
command line? If so, does anything change if you revert the patch in
question and change kernel boot command line to 'blah blah console='?

	-ss