Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp647797pxu; Tue, 6 Oct 2020 15:47:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyB/28QKBY5AWmUH4LX9TukHT3EioULBz+QM62NaWZhbxe3bb0cJOLM5WtywTzvzYLtK0d2 X-Received: by 2002:a17:906:494:: with SMTP id f20mr273452eja.285.1602024470845; Tue, 06 Oct 2020 15:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602024470; cv=none; d=google.com; s=arc-20160816; b=YvPWGq4ouqStuGTzlgBBOZQy3rocG8wCO2Xxl7CO7KHwwtbHVtDeMTIf+EFhe/jCTB 2zhV40FH0wD0TTTcrZoA7MDwQGEaeggwS60yFfIJiI65F30IT1Us1MBnWwBNH30ONVWG RNKEFx29VtMq6NaNgP1vL8OgwSSw90BhtcPBWb7b+6F9Se+ftu/IhHDoP27eOf+F7f+c gLGEjMy8dg3XyiVjqTPWV1LxT/WQ9jYtWlV9ZVbQhfMMwk4fE66RDm90XekEPsJnrGBU 7TMCi0gt6ArLIcOKtp/Bkk5OMxEuzs5ZljQPF+259IcK+/mf9SzmpltRU34oC1bq3VLg rRFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:from:cc:to:subject:ironport-sdr :ironport-sdr; bh=RTSuiL7Y8NdfKHp3nYMWNOWrCi2E3oL8gJ9imUG/iZQ=; b=s+Cf15m2Cw+dUve507e2CriyG+IyYCTGorZt8+8nnc4dhSiAEK9jlaMv92OzjlUGjs 7pj9s9iSikEGrtDPCO8fQPkwGKl/KL8eYR6DFi9LCeEdgtWqNhQvsLy8W804/DhAH4D3 PiH+BzNM/SNHdim3atrkCY/cc7V52gnFdkt8++kgkQwijNYxGfFkgODqww7SghO6S8IU 2XCPRzFNc909I92LQXu9ko7vL30iPl7ZfS85ywKzUgfU68EQPQVdwBGqH0hoVi6/wrF3 sudCRXXSJAHaMZiDOaoQwiEDEr7b+xQ+FggvvizWcQh6ghYHFrwSbq/1+6V4hY/ytpOP HgDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id wp8si95786ejb.752.2020.10.06.15.47.27; Tue, 06 Oct 2020 15:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727328AbgJFUvL (ORCPT + 99 others); Tue, 6 Oct 2020 16:51:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:19137 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727293AbgJFUvL (ORCPT ); Tue, 6 Oct 2020 16:51:11 -0400 IronPort-SDR: ZhAjQPtXEp7AhraDP0n8Wk0e+9ZiIy7tjkVsW4NmaUCZqezHWC5kw5xXn5eyqKbCBp27yZ6up1 iHlVSxhwZY7w== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="152454171" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="152454171" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 13:51:08 -0700 IronPort-SDR: 6MRuPVv54ufhdqMKoRfgdP755q19MLAqZ7dy+90lhG8ZFdp0YZpjBX2Y3q62KmXwHWiwM959PQ uoWjHZKWSioA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="297299459" Received: from viggo.jf.intel.com (HELO localhost.localdomain) ([10.54.77.144]) by fmsmga008.fm.intel.com with ESMTP; 06 Oct 2020 13:51:07 -0700 Subject: [RFC][PATCH 00/12] mm: tweak page cache migration To: linux-kernel@vger.kernel.org Cc: Dave Hansen , npiggin@gmail.com, akpm@linux-foundation.org, willy@infradead.org, yang.shi@linux.alibaba.com, linux-mm@kvack.org From: Dave Hansen Date: Tue, 06 Oct 2020 13:51:03 -0700 Message-Id: <20201006205103.268F74A9@viggo.jf.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First of all, I think this little slice of code is a bit under-documented. Perhaps this will help clarify things. I'm pretty confident the page_count() check in the first patch is right, which is why I removed it outright. The xas_load() check is a bit murkier, so I just left a warning in for it. Cc: Nicholas Piggin Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: Yang Shi Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org