Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0yJV3eUJIP2OPn/k3noIcE05oaeZszklwdGgO0+mRKP/YJCalQj2lNArIRtZlTd3scl0xMShcW
 XbulUw3pA7KbrwQPMeotsF/QzHjCz4gooijnTbQr8g8pTPhpnk8MaAgKoxkmVQhZDpV0qCCWKQ
 mUozB9NP4VHje1mIsr+B1c0NPmRLYGG7IhZenMQOioFRnHCvKUm3dBRycewckZYQRJUoNtFrxk
 Yf0kWYI19M3QVQm2ylXdXzdFgp3ff8PXYqa0+Gv0+6OJZgkl6qBg+HCnFzUdAAHwXk5Wwiitr2
 RXI=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Logan Gunthorpe <logang@deltatee.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Omar Sandoval <osandov@osandov.com>
CC:     Sagi Grimberg <sagi@grimberg.me>,
        Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH blktests v2 03/11] common/xfs: Create common helper to
 verify block device with xfs
Thread-Topic: [PATCH blktests v2 03/11] common/xfs: Create common helper to
 verify block device with xfs
Thread-Index: AQHWl1stoRmb/0l14EOVdSF8HArmFA==
Date:   Tue, 6 Oct 2020 23:50:37 +0000
Message-ID: <BYAPR04MB4965C2DDD4A5FBD86A128FE9860D0@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20200930185422.11494-1-logang@deltatee.com>
 <20200930185422.11494-4-logang@deltatee.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a4670a2a-39a5-4733-7e07-08d86a529fd0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 23:50:37.2879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oiEZao0T3FZvxOCSy/8ZMvTyNsJ1sOn3Oh554OSJRa+ekn+QW2/Nr4d8tSiaDhgc159HOuw3pBmYOtC8RK+GLfsfNrU28+JMLweffRYDdAY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4871
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/30/20 11:54, Logan Gunthorpe wrote:=0A=
> Make a common helper from the code in tests nvme/012 and nvme/013=0A=
> to run an fio verify on a XFS file system backed by the=0A=
> specified block device.=0A=
>=0A=
> While we are at it, all the output is redirected to $FULL instead of=0A=
> /dev/null.=0A=
>=0A=
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>=0A=
> ---=0A=
>  common/xfs     | 22 ++++++++++++++++++++++=0A=
>  tests/nvme/012 | 14 +-------------=0A=
>  tests/nvme/013 | 14 +-------------=0A=
>  3 files changed, 24 insertions(+), 26 deletions(-)=0A=
=0A=
The common namespace is getting cluttered. Can you please create=0A=
=0A=
a subdirectory common/fs/xfs ?=0A=
=0A=
>=0A=
> diff --git a/common/xfs b/common/xfs=0A=
> index d1a603b8c7b5..210c924cdd41 100644=0A=
> --- a/common/xfs=0A=
> +++ b/common/xfs=0A=
> @@ -9,3 +9,25 @@=0A=
>  _have_xfs() {=0A=
>  	_have_fs xfs && _have_program mkfs.xfs=0A=
>  }=0A=
> +=0A=
> +_xfs_mkfs_and_mount() {=0A=
> +	local bdev=3D$1=0A=
> +	local mount_dir=3D$2=0A=
> +=0A=
> +	mkdir -p "${mount_dir}"=0A=
> +	umount "${mount_dir}"=0A=
> +	mkfs.xfs -l size=3D32m -f "${bdev}"=0A=
> +	mount "${bdev}" "${mount_dir}"=0A=
> +}=0A=
> +=0A=
> +_xfs_run_fio_verify_io() {=0A=
> +	local mount_dir=3D"/mnt/blktests"=0A=
=0A=
The mount dir should be a parameter and not the hardcode value=0A=
=0A=
to make it reusable.=0A=
=0A=
> +	local bdev=3D$1=0A=
> +=0A=
> +	_xfs_mkfs_and_mount "${bdev}" "${mount_dir}" >> "${FULL}" 2>&1=0A=
> +=0A=
> +	_run_fio_verify_io --size=3D950m --directory=3D"${mount_dir}/"=0A=
> +=0A=
> +	umount "${mount_dir}" >> "${FULL}" 2>&1=0A=
> +	rm -fr "${mount_dir}"=0A=
> +}=0A=
> diff --git a/tests/nvme/012 b/tests/nvme/012=0A=
> index 1d8d8e3cc271..a13cd08ce6bf 100755=0A=
> --- a/tests/nvme/012=0A=
> +++ b/tests/nvme/012=0A=
> @@ -26,12 +26,9 @@ test() {=0A=
>  	local port=0A=
>  	local nvmedev=0A=
>  	local loop_dev=0A=
> -	local mount_dir=3D"/mnt/blktests"=0A=
>  	local file_path=3D"${TMPDIR}/img"=0A=
>  	local subsys_name=3D"blktests-subsystem-1"=0A=
>  =0A=
> -	mkdir -p "${mount_dir}" > /dev/null 2>&1=0A=
> -=0A=
>  	truncate -s 1G "${file_path}"=0A=
>  =0A=
>  	loop_dev=3D"$(losetup -f --show "${file_path}")"=0A=
> @@ -47,15 +44,7 @@ test() {=0A=
>  	cat "/sys/block/${nvmedev}n1/uuid"=0A=
>  	cat "/sys/block/${nvmedev}n1/wwid"=0A=
>  =0A=
> -	umount ${mount_dir} > /dev/null 2>&1=0A=
> -=0A=
> -	mkfs.xfs -l size=3D32m -f /dev/"${nvmedev}n1" > /dev/null 2>&1=0A=
> -=0A=
> -	mount /dev/"${nvmedev}n1" "${mount_dir}"=0A=
> -=0A=
> -	_run_fio_verify_io --size=3D950m --directory=3D"${mount_dir}/"=0A=
> -=0A=
> -	umount "${mount_dir}" > /dev/null 2>&1=0A=
> +	_xfs_run_fio_verify_io "/dev/${nvmedev}n1"=0A=
>  =0A=
>  	_nvme_disconnect_subsys "${subsys_name}"=0A=
>  =0A=
> @@ -66,7 +55,6 @@ test() {=0A=
>  	losetup -d "${loop_dev}"=0A=
>  =0A=
>  	rm "${file_path}"=0A=
> -	rm -fr "${mount_dir}"=0A=
>  =0A=
>  	echo "Test complete"=0A=
>  }=0A=
> diff --git a/tests/nvme/013 b/tests/nvme/013=0A=
> index 3819a2730d9b..1ac725ea83f2 100755=0A=
> --- a/tests/nvme/013=0A=
> +++ b/tests/nvme/013=0A=
> @@ -24,13 +24,10 @@ test() {=0A=
>  =0A=
>  	local port=0A=
>  	local nvmedev=0A=
> -	local mount_dir=3D"/mnt/blktests/"=0A=
>  	local file_path=3D"${TMPDIR}/img"=0A=
>  =0A=
>  	local subsys_name=3D"blktests-subsystem-1"=0A=
>  =0A=
> -	mkdir -p "${mount_dir}" > /dev/null 2>&1=0A=
> -=0A=
>  	truncate -s 1G "${file_path}"=0A=
>  =0A=
>  	_create_nvmet_subsystem "${subsys_name}" "${file_path}" \=0A=
> @@ -44,15 +41,7 @@ test() {=0A=
>  	cat "/sys/block/${nvmedev}n1/uuid"=0A=
>  	cat "/sys/block/${nvmedev}n1/wwid"=0A=
>  =0A=
> -	umount ${mount_dir} > /dev/null 2>&1=0A=
> -=0A=
> -	mkfs.xfs -l size=3D32m -f /dev/"${nvmedev}n1" > /dev/null 2>&1=0A=
> -=0A=
> -	mount /dev/"${nvmedev}n1" "${mount_dir}"=0A=
> -=0A=
> -	_run_fio_verify_io --size=3D800m --directory=3D"${mount_dir}/"=0A=
> -=0A=
> -	umount "${mount_dir}" > /dev/null 2>&1=0A=
> +	_xfs_run_fio_verify_io "/dev/${nvmedev}n1"=0A=
>  =0A=
>  	_nvme_disconnect_subsys "${subsys_name}"=0A=
>  =0A=
> @@ -61,7 +50,6 @@ test() {=0A=
>  	_remove_nvmet_port "${port}"=0A=
>  =0A=
>  	rm "${file_path}"=0A=
> -	rm -fr "${mount_dir}"=0A=
>  =0A=
>  	echo "Test complete"=0A=
>  }=0A=
=0A=
rest looks good=0A=
=0A=