Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp9351pxu; Tue, 6 Oct 2020 17:03:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL+QkQgv8iLnEXzbH6tnGJqI5fWnZBxh8vbh8eOK4sODCD3kn8q+tMOZfxvk5P6ncGBMwl X-Received: by 2002:aa7:d689:: with SMTP id d9mr716889edr.128.1602029008957; Tue, 06 Oct 2020 17:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602029008; cv=none; d=google.com; s=arc-20160816; b=keIhsIguN47K4S2cDzaTFOdWnQ7b7znBNz1aoqifQSXraY58HFg8dYMQ/2Lrva/UBg aexxM75+nfoxACR751KMboQ3Egtml6RQtvsyw4lb3uucy1UabwNc9il3Uwvt9oVby6hB On3k8ncAgv+q4QMFtUumoq2GGTmGV7Z2gayqaCIrw8mah79ZbhNwZ97bUgrjpcY/FNmp zPZm5PSzPBnJEaXS9V6FdvpMlDill7h4aZM5/mbqeHJPFnzINqMi5oGDh2Ivowfa9q1T sExh6O3EWlYtqbQbLgIDsdYCEv1WDDaXlkXiX3ilHfuDsU6WYsapU+RiAllPb2KXMlkM Lxng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:dkim-signature; bh=hUEDYTtYWRLTZhUJ1PsnTG6DKx8J9AiKmozhxnd9g4Y=; b=X+SMJay6JWv87BnojrXMwjqTY6owGWsNOLLOdBzv0LI1nzT/Z8sqPx41SVmc59o+Z0 DpwKIA2yL8TZ78pnbFTK16KDsjIPhDZTpB1zmDXrVDCWYKm9N8uu4r9cMImeKhPHaGC1 auVB/5Wmj9ExUMUUzYF5kF46HQFxoGt2suI0XenB65q3MNObBeMNS5KQUX5lrjHtLrDM WD5+Hg3JEgG8se3ZKBdWE25BBcUfZ3yn7aPfsfAG4smneq1uYpfyS7zKuJNjQfBeTjSD fFs8cvDcSj+HXxZ6+K2io3ECvCm1WFkpShq241vOY5r7D+ut9kWTTMEjFop6USBF+6kK pgCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@deltatee.com header.s=20200525 header.b=WomVnvTx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si131615edv.217.2020.10.06.17.02.58; Tue, 06 Oct 2020 17:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@deltatee.com header.s=20200525 header.b=WomVnvTx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbgJFXvc (ORCPT + 99 others); Tue, 6 Oct 2020 19:51:32 -0400 Received: from ale.deltatee.com ([204.191.154.188]:32770 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgJFXvc (ORCPT ); Tue, 6 Oct 2020 19:51:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hUEDYTtYWRLTZhUJ1PsnTG6DKx8J9AiKmozhxnd9g4Y=; b=WomVnvTxGhGIUQZu62C6lncFUu W/EtMAVRX4r5X2yCavZqOW/QOtThugT/K6DAWw+hbKyAl5tBV+P2Z51HP2X19GPw652+tB9w3iGMg 6YGVy+e33IEhaOmr1vKnHWF4NROcNJzeikdaR65s/8LLn+YYy36RYoEBqSVRF48uizjJyjuL5kRP0 GikLOIGvasauzQVTy+nTD3m+Gi2CrRHLhd+FcTm142tYKDyNxhA1mjBXXhLB98SBi74UQ6OPfV/V7 O4hHkrvHx8DXhuy0+t+CkUatb8nrM5A+vWoZ3LRCIEyvhDio6gzuEBaDaMU2FZpaa2WK/tioAwhiU yJ9ydGQA==; Received: from [172.16.1.162] by ale.deltatee.com with esmtp (Exim 4.92) (envelope-from ) id 1kPwjn-0006fK-Tc; Tue, 06 Oct 2020 17:51:20 -0600 To: Chaitanya Kulkarni , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , Omar Sandoval Cc: Sagi Grimberg , Stephen Bates References: <20200930185422.11494-1-logang@deltatee.com> <20200930185422.11494-3-logang@deltatee.com> From: Logan Gunthorpe Message-ID: Date: Tue, 6 Oct 2020 17:51:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: sbates@raithlin.com, sagi@grimberg.me, osandov@osandov.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Chaitanya.Kulkarni@wdc.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-06 5:44 p.m., Chaitanya Kulkarni wrote: > On 9/30/20 11:54, Logan Gunthorpe wrote: >> >> requires() { >> _nvme_requires >> - _have_program mkfs.xfs && _have_fio >> + _have_xfs >> + _have_fio > Can you make _have_xfs return true false ? so it can be used with && ? _have_xfs() does return true/false and can be used with && or in a conditional. Per [1], my opinion is that using && in the requires() function where the return value is ignored is confusing so I prefer not to do it in new code. If we want to reconsider this we, should add a check to ensure the return value of requires() matches the expectation of the global variable it uses. Logan [1] https://lore.kernel.org/linux-block/92478e6f-622a-a1ae-6189-4009f9a307bc@deltatee.com/