Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: lzonD3ADaAweDDA8oUGjyHCKomte3Bu/pE4smydq9Eea1oPgzu1OMATtVa3kukQuBoWU5RUIvv
 z3KJmFA9BNTjlRxpjz5BOR5eo7N9F82EUrCnnp7DRhKShJ+YRJUHRLKv4uBmylDQOBeF2+Iwl1
 qjQlUlcqg5yKpGQEiStiWkvej1XPWVd89zQXqWZMu0tjjkbYR1/q1vpgUNrbJ1Y6n659Mk4sZC
 EeyOpAB2UR+d6FYqwb6KY86cEaNog/VTvcbV35JTjmKM7xOX8jDNdXsGFX1Ux/86rusR9CIoBC
 3x8=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Logan Gunthorpe <logang@deltatee.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Omar Sandoval <osandov@osandov.com>
CC:     Sagi Grimberg <sagi@grimberg.me>,
        Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH blktests v2 05/11] nvme: Add common helpers for passthru
 tests
Thread-Topic: [PATCH blktests v2 05/11] nvme: Add common helpers for passthru
 tests
Thread-Index: AQHWl1wk5ovaYXCvmkSyan6E05rb7g==
Date:   Wed, 7 Oct 2020 00:02:09 +0000
Message-ID: <BYAPR04MB49654DCBAD729B05759EB6FF860A0@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20200930185422.11494-1-logang@deltatee.com>
 <20200930185422.11494-6-logang@deltatee.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 45edad90-7299-4181-7371-08d86a543c7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 00:02:09.6127
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3TBpTNX0tchE/OO5Nqa1ZbbidNnhtkT6S9RI8yv2W/K6EuENFzrmq5e+mF4gxA/GC56aid9eGnxoVQnhBeh+m3I0JpdFcMy73g8P4M0RXvA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4037
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/30/20 12:01, Logan Gunthorpe wrote:=0A=
> Add some simple helpers to setup a passthru target that passes through=0A=
> to a nvme test device.=0A=
>=0A=
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>=0A=
> ---=0A=
>  tests/nvme/rc | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++=
=0A=
>  1 file changed, 76 insertions(+)=0A=
>=0A=
> diff --git a/tests/nvme/rc b/tests/nvme/rc=0A=
> index dfa57a299625..1ea23308a3f7 100644=0A=
> --- a/tests/nvme/rc=0A=
> +++ b/tests/nvme/rc=0A=
> @@ -73,6 +73,17 @@ _require_nvme_trtype_is_fabrics() {=0A=
>  	return 0=0A=
>  }=0A=
>  =0A=
> +_test_dev_nvme_ctrl() {=0A=
> +	local dev=0A=
> +=0A=
> +	dev=3D$(cat "${TEST_DEV_SYSFS}/device/dev")=0A=
 can you initialize dev this at the time of declaration ?=0A=
> +	echo "/dev/char/${dev}"=0A=
> +}=0A=
> +=0A=
> +_test_dev_nvme_nsid() {=0A=
> +	cat "${TEST_DEV_SYSFS}/nsid"=0A=
> +}=0A=
> +=0A=
>  _cleanup_nvmet() {=0A=
>  	local dev=0A=
>  	local port=0A=
> @@ -257,6 +268,27 @@ _remove_nvmet_subsystem() {=0A=
>  	rmdir "${subsys_path}"=0A=
>  }=0A=
>  =0A=
> +_create_nvmet_passthru() {=0A=
> +	local nvmet_subsystem=3D"$1"=0A=
> +	local subsys_path=3D"${NVMET_CFS}/subsystems/${nvmet_subsystem}"=0A=
> +	local passthru_path=3D"${subsys_path}/passthru"=0A=
> +=0A=
> +	mkdir -p "${subsys_path}"=0A=
> +	printf 1 > "${subsys_path}/attr_allow_any_host"=0A=
> +=0A=
> +	printf "%s" "$(_test_dev_nvme_ctrl)" > "${passthru_path}/device_path"=
=0A=
> +	printf 1 > "${passthru_path}/enable"=0A=
=0A=
can you please echo in general and printf only when it is needed ?=0A=
=0A=
I know existing code is a bit inconsistent I'll send a clenup to make it=0A=
uniform.=0A=
=0A=
> +}=0A=
> +=0A=
> +_remove_nvmet_passhtru() {=0A=
> +	local nvmet_subsystem=3D"$1"=0A=
> +	local subsys_path=3D"${NVMET_CFS}/subsystems/${nvmet_subsystem}"=0A=
> +	local passthru_path=3D"${subsys_path}/passthru"=0A=
> +=0A=
> +	printf 0 > "${passthru_path}/enable"=0A=
> +	rmdir "${subsys_path}"=0A=
> +}=0A=
> +=0A=
>  _add_nvmet_subsys_to_port() {=0A=
>  	local port=3D"$1"=0A=
>  	local nvmet_subsystem=3D"$2"=0A=
> @@ -292,6 +324,50 @@ _find_nvme_dev() {=0A=
>  	done=0A=
>  }=0A=
>  =0A=
> +_find_nvme_passthru_loop_dev() {=0A=
> +	local subsys=3D$1=0A=
> +	local nsid=0A=
> +	local dev=0A=
> +=0A=
> +	dev=3D$(_find_nvme_dev "${subsys}")=0A=
> +	nsid=3D$(_test_dev_nvme_nsid)=0A=
> +	echo "/dev/${dev}n${nsid}"=0A=
> +}=0A=
> +=0A=
> +_nvmet_passthru_target_setup() {=0A=
> +	local subsys_name=3D$1=0A=
> +=0A=
> +	_create_nvmet_passthru "${subsys_name}"=0A=
> +	port=3D"$(_create_nvmet_port "loop")"=0A=
> +	_add_nvmet_subsys_to_port "${port}" "${subsys_name}"=0A=
> +=0A=
> +	echo "$port"=0A=
> +}=0A=
> +=0A=
> +_nvmet_passthru_target_connect() {=0A=
> +	local trtype=3D$1=0A=
> +	local subsys_name=3D$2=0A=
> +=0A=
> +	_nvme_connect_subsys "${trtype}" "${subsys_name}"=0A=
> +	nsdev=3D$(_find_nvme_passthru_loop_dev "${subsys_name}")=0A=
> +=0A=
> +	# The following tests can race with the creation=0A=
> +	# of the device so ensure the block device exists=0A=
> +	# before continuing=0A=
> +	while [ ! -b "${nsdev}" ]; do sleep 1; done=0A=
> +=0A=
> +	echo "${nsdev}"=0A=
> +}=0A=
> +=0A=
> +_nvmet_passthru_target_cleanup() {=0A=
> +	local port=3D$1=0A=
> +	local subsys_name=3D$2=0A=
> +=0A=
> +	_remove_nvmet_subsystem_from_port "${port}" "${subsys_name}"=0A=
> +	_remove_nvmet_port "${port}"=0A=
> +	_remove_nvmet_passhtru "${subsys_name}"=0A=
> +}=0A=
> +=0A=
>  _filter_discovery() {=0A=
>  	sed -n -r -e "s/Generation counter [0-9]+/Generation counter X/" \=0A=
>  		  -e '/Discovery Log Number|Log Entry|trtype|subnqn/p'=0A=
=0A=
=0A=