Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030466AbWHIEiN (ORCPT ); Wed, 9 Aug 2006 00:38:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030467AbWHIEiN (ORCPT ); Wed, 9 Aug 2006 00:38:13 -0400 Received: from ns2.suse.de ([195.135.220.15]:9694 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1030466AbWHIEiM (ORCPT ); Wed, 9 Aug 2006 00:38:12 -0400 To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Prasanna S Panchamukhi , Anil S Keshavamurthy , Jim Keniston Subject: Re: [PATCH 2/3] Kprobes: Define retval helper References: <20060807115537.GA15253@in.ibm.com> <20060807120024.GD15253@in.ibm.com> <20060808162559.GB28647@infradead.org> From: Andi Kleen Date: 09 Aug 2006 06:37:59 +0200 In-Reply-To: <20060808162559.GB28647@infradead.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 15 Christoph Hellwig writes: > On Mon, Aug 07, 2006 at 05:30:24PM +0530, Ananth N Mavinakayanahalli wrote: > > From: Ananth N Mavinakayanahalli > > > > Add the KPROBE_RETVAL macro to help extract the return value on > > different architectures, while using function-return probes. > > Good idea. You should add parentheses around regs, otherwise the C > preprocessor might bite users. Also the shouting name is quite ugly. > In fact it should probably go to asm/system.h or similar The other macros like this (instruction_pointer etc) are in asm/ptrace.h -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/