Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp98362pxu; Tue, 6 Oct 2020 20:20:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz03HEOxjMMbQnqj0Mo7Fl0X0k17YyX3adyZX1D9YqyOYJpxsgf9bffY604gJye0BW1f4LP X-Received: by 2002:a17:906:eb59:: with SMTP id mc25mr1239669ejb.34.1602040857358; Tue, 06 Oct 2020 20:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602040857; cv=none; d=google.com; s=arc-20160816; b=G0Ug4TethdxYFkrvVXkUIw5CLVIO7VuhuUxkdvCcIDHCWxGVAzRATn4Cw3mOOqhzbR MIqEQoLVKW9bUx2dNyXl/p49F5FJnbSqWeGRtMzgsXzxWAV1Msm6GCWV+HbZs52Xt5+N 6vc1oKomarFxOtd1TvOZrfNAQ08vP5b6R0EC0lLfnHoAwZYqiSl9BowoMVTOhTDaFh41 DMVZUUWf8wqzi6jD8Aq2lns9yUBQ7sB0VSIV9B1XLVECVLw1sW8o3AlWhyLLgMIvHUSP hqjVc2Ssz6iVTVPZ0bYDwn2tRJ+kdu+ctxJz4p6I4JPnSdaFECqRq0CfgPBtu8RM3YLZ QCsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2nHndZKwwfOOj5bwaqodAdSawGiEECEuWU/h1JxfIjE=; b=vmxrokAmoZCpK9WUekRYL1lhVHrM6LT/pNez0fEbDa9utmMwLA8awEin2uy9SWu4Vm pheBSzrGtPjMlgrYCMxcF3ZePgpf5f8sIn/x/PeJTTgVraq14JRTA4tFVN3nANgv2Mb3 oxkILbdy99EBlrMCFXJ26rSiCsmWm6dH1CCfxFGGeHmf7lRIUP3nZYyKJTtIk3imF4Lg 6ZZXR4VE89J/+Ba57A0T75OI4xec7hAlbW9L1ew8U65foK/Cff7f9sEbXJJNc7DaZ8jT czZUI4uU595Ml4q05xq3qEf2ulMOSwoDtw8ETjcweNe0e9hLtlaci+FgumPwrPFZ9W5e Oj8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=tAplSRDr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 33si465927edr.606.2020.10.06.20.20.34; Tue, 06 Oct 2020 20:20:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=tAplSRDr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbgJGDQw (ORCPT + 99 others); Tue, 6 Oct 2020 23:16:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbgJGDQv (ORCPT ); Tue, 6 Oct 2020 23:16:51 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B07EC0613D2 for ; Tue, 6 Oct 2020 20:16:51 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id b26so531897pff.3 for ; Tue, 06 Oct 2020 20:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2nHndZKwwfOOj5bwaqodAdSawGiEECEuWU/h1JxfIjE=; b=tAplSRDrpqc0bLhzdVINXo66tsmyG4077hKzUat22H5dF7Vj//0RV7AArxOdQoESc2 Pc1oXj5o1aBDxEsXhyFT5DUjos3yqJdciaIWy9R7gRRGZ3bi//gyke/tUgu5dAYfEGni xfH9eipKOHyy0sVf76ROJzb0besS5j3UyYOzr1UUM/kkUuaSuETXstNK3e9bku88JvMc pOa/pbNOepvAIcA7Zij2sTe3d08qjaUHOpnkXnWpGeghOWKktvhXZd66o5IYI9tTjAwz rHyMxgYjLvQvepUW0rMgxFRZtwjga7DYckXPZg367rZiMg3h3mDNWFMIR0AlwCDy5lzx UMnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2nHndZKwwfOOj5bwaqodAdSawGiEECEuWU/h1JxfIjE=; b=H0Jc59f7ZS/j3OO1D+oiGu/7fAGKS8RGYSlDcQBh7mFS3zvwvL0RwTQMsP2sqWVcca 8IKWKgUZdPXlcOMe5jrI5bLf6o991Mmy2AuI819sRgKvr9m3WD2BSfHNbfs0cq13M8Uf 9mb1wi9FwJLVe109Wo+uxgwKt3TNxuIEpp7Fv09/fuXnCXYp4ES/S0zd3BrXJtKFk5wM tolbHnzhL4ORkjfxUlkd2F1dOxY0HRAOXPB51gQQEjwEKgA6nz4zhBZCYOE7zoJkeF5D odkNLtNqc5/asayThZBgfiHA6GZbRN5AG1e+VjG4pFXoqsiTHI/O2p3y44OOgnT7YHiq E3ow== X-Gm-Message-State: AOAM533YaX0iMFnUA0G6o2TCEc5T48O8rrRYuHtMOn+dauwk7r+t6JXR nWFgcfEfVmXg+fOwQLcfflCa9w== X-Received: by 2002:a63:705c:: with SMTP id a28mr1165305pgn.266.1602040610841; Tue, 06 Oct 2020 20:16:50 -0700 (PDT) Received: from localhost.localdomain ([103.136.221.72]) by smtp.gmail.com with ESMTPSA id e1sm729094pfd.198.2020.10.06.20.16.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2020 20:16:50 -0700 (PDT) From: Muchun Song To: axboe@kernel.dk, viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhuyinyin@bytedance.com, Muchun Song Subject: [PATCH v3 0/4] io_uring: Fix async workqueue is not canceled on some corner case Date: Wed, 7 Oct 2020 11:16:31 +0800 Message-Id: <20201007031635.65295-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should make sure that async workqueue is canceled on exit, but on some corner case, we found that the async workqueue is not canceled on exit in the linux-5.4. So we started an in-depth investigation. Fortunately, we finally found the problem. The commit: 1c4404efcf2c ("io_uring: make sure async workqueue is canceled on exit") did not completely solve this problem. This patch series to solve this problem completely. And there's no upstream variant of this commit, so this patch series is just fix the linux-5.4.y stable branch. changelog in v3: 1. Merge patch-4 to patch-1. changelog in v2: 1. Fix missing save the current thread files 2. Fix double list add in io_queue_async_work() Muchun Song (4): io_uring: Fix missing smp_mb() in io_cancel_async_work() io_uring: Fix remove irrelevant req from the task_list io_uring: Fix missing save the current thread files io_uring: Fix double list add in io_queue_async_work() Yinyin Zhu (1): io_uring: Fix resource leaking when kill the process fs/io_uring.c | 59 +++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 20 deletions(-) -- 2.11.0