Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Oct 2020 10:41:28 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Linux PM <linux-pm@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: schedutil: Simplify sugov_fast_switch()
Message-ID: <20201007051128.odqiwuex3vqwxumo@vireshk-i7>
References: <1869109.WhRmcVd4D2@kreacher>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1869109.WhRmcVd4D2@kreacher>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 06-10-20, 14:01, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Drop a redundant local variable definition from sugov_fast_switch()
> and rearrange the code in there to avoid the redundant logical
> negation.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> The code reads a bit easier after this change IMV.
> 
> linux-next material.
> 
> ---
>  kernel/sched/cpufreq_schedutil.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> Index: linux-pm/kernel/sched/cpufreq_schedutil.c
> ===================================================================
> --- linux-pm.orig/kernel/sched/cpufreq_schedutil.c
> +++ linux-pm/kernel/sched/cpufreq_schedutil.c
> @@ -114,12 +114,8 @@ static bool sugov_update_next_freq(struc
>  static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time,
>  			      unsigned int next_freq)
>  {
> -	struct cpufreq_policy *policy = sg_policy->policy;
> -
> -	if (!sugov_update_next_freq(sg_policy, time, next_freq))
> -		return;
> -
> -	cpufreq_driver_fast_switch(policy, next_freq);
> +	if (sugov_update_next_freq(sg_policy, time, next_freq))
> +		cpufreq_driver_fast_switch(sg_policy->policy, next_freq);
>  }
>  
>  static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time,

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh