Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp215885pxu; Wed, 7 Oct 2020 00:48:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAQIXXmnQgvJGcaS8x5/+w9DsM0+C0/MFE3M0gGlyzSKb2MfRS8giQwgpL39Ru7CP330pl X-Received: by 2002:a05:6402:21c5:: with SMTP id bi5mr2220049edb.380.1602056919944; Wed, 07 Oct 2020 00:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602056919; cv=none; d=google.com; s=arc-20160816; b=aoTxXjw0oViIESNsF/+x09B/b3Rg65dHMroQ3NyhpIe6c90uOIF/1PjmKF3ou7Yi8z chgfCco0Cg3SD2fjpqJhbIZqQGtoaB2d1rTtEmnAqJgfGHIyWAu58IR9ezmMAgCNcKtk 4F4+z7KK0JOCRhxbvqP2WZ250sBliGHLUmOkVq/Co5ybWTLL29Isn88XiKT9TpfNL7Bh 323PWzlXMzZrDc5Jh97Z6okxTlodqWh8yUaxG50PVL6+taPF7WM1wtgk1FxXrDudRzGX nAzimmpaeAeCn+oNhxRSjU0/yHA/NGKBq82YktHS9gc9hy7oIppzpvuaPvJlhMkdwm6H fJ7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=T5w3wlZs7GiCeNAwGorLnkLJGPJqc1kvuERAz9MaIuU=; b=TqnWAT7IrSE23W1+5ufbxZfuUQG4B76oIi8o7w1A9OT52ZC96E2Or9qgnVKxRUgrbL 5GirQXd/RBj2XglatR08cDHmcdGMy0N9TP+ozQjco9GgmHBE7kpyjbY94eQWcBvAeWIl yS6tiEqLoT9KFBRdzEmcPWalfIbl9wvk0ZOZ7REjse9BuzHU7BE+SSBKMY2N/wh+/iPM oiFyzA8UcfeYpStR/rmp5GkAmXtI06A5qX+sSj3Xel87tsjH3ORIcVZ11SHit+6Hq880 Rn6d7R4mYmQ/SLJ7ScS8C/8bzCBPDy7QXw7LbC9EJ3zuCjT+TCR4ZVFqY5msGoNknkpD Yv7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x3m4w3Pf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sa27si989397ejb.546.2020.10.07.00.48.16; Wed, 07 Oct 2020 00:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x3m4w3Pf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbgJGHqq (ORCPT + 99 others); Wed, 7 Oct 2020 03:46:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:50426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbgJGHqp (ORCPT ); Wed, 7 Oct 2020 03:46:45 -0400 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2932720870; Wed, 7 Oct 2020 07:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602056804; bh=R4+hRjeXx44BI8Hcdv5NdWTepbPaIEsQ9jUrvEd5YUk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=x3m4w3PfO9rY8rRGo1rQ1CjNzTrKpKQ2aeHGJ12WZoiDbP4hB6FBpIqezhvDckLa8 xmevP6p3xYTJjV16vCqm/G0s4vpHrdN3ZNNck4WfOqL2u5cY5Dx3YehHss9WItbnI3 ffUes45WIg6s14zBmdKxvmCiQ4DSzR/ESnm0GgRg= Received: by mail-ed1-f54.google.com with SMTP id b12so1110929edz.11; Wed, 07 Oct 2020 00:46:44 -0700 (PDT) X-Gm-Message-State: AOAM531s7OBuSS+VDNBAfpccWPr+kSLaFuQQHNZv3daIPO7gOEw3Srb2 sj87vQhcgJPT/6NL2Rshb40n6/sY8i3Y4Cn7PAc= X-Received: by 2002:a50:e78f:: with SMTP id b15mr2224622edn.104.1602056802570; Wed, 07 Oct 2020 00:46:42 -0700 (PDT) MIME-Version: 1.0 References: <20200924192455.2484005-1-j.neuschaefer@gmx.net> <20200925050818.2512375-1-j.neuschaefer@gmx.net> In-Reply-To: <20200925050818.2512375-1-j.neuschaefer@gmx.net> From: Krzysztof Kozlowski Date: Wed, 7 Oct 2020 09:46:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 7/7] ARM: dts: imx50-kobo-aura: Add Netronix embedded controller To: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= Cc: "linux-kernel@vger.kernel.org" , Lee Jones , Rob Herring , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Sep 2020 at 07:10, Jonathan Neusch=C3=A4fer wrote: > > Enable the Netronix EC on the Kobo Aura ebook reader. > > Several features are still missing: > - Frontlight/backlight. The vendor kernel drives the frontlight LED > using the PWM output of the EC and an additional boost pin that > increases the brightness. > - Battery monitoring > - Interrupts for RTC alarm and low-battery events > > Signed-off-by: Jonathan Neusch=C3=A4fer > --- > > v3: > - Remove interrupt-controller property from embedded-controller node > - subnodes of embedded-controller node in to the main node > > v2: > - https://lore.kernel.org/lkml/20200905144503.1067124-3-j.neuschaefer@gmx= .net/ > - Fix pwm-cells property (should be 2, not 1) > --- > arch/arm/boot/dts/imx50-kobo-aura.dts | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/im= x50-kobo-aura.dts > index a0eaf869b9135..2d1a59091a37c 100644 > --- a/arch/arm/boot/dts/imx50-kobo-aura.dts > +++ b/arch/arm/boot/dts/imx50-kobo-aura.dts > @@ -6,6 +6,7 @@ > /dts-v1/; > #include "imx50.dtsi" > #include > +#include > > / { > model =3D "Kobo Aura (N514)"; > @@ -135,10 +136,24 @@ &i2c3 { > pinctrl-0 =3D <&pinctrl_i2c3>; > status =3D "okay"; > > - /* TODO: embedded controller at 0x43 */ > + embedded-controller@43 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_ec>; > + compatible =3D "netronix,ntxec"; > + reg =3D <0x43>; > + system-power-controller; > + interrupts-extended =3D <&gpio4 11 IRQ_TYPE_EDGE_FALLING>= ; > + #pwm-cells =3D <2>; > + }; > }; > > &iomuxc { > + pinctrl_ec: ec { This should fail on dtschema check - pinctrl groups should end with "grp". Best regards, Krzysztof