Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp244657pxu; Wed, 7 Oct 2020 01:46:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4kC2QxEZACLhMdaSzpjH71crmBzhoH/LezMYrXBiwHjHcSOS5dMQdEtA/sygbzfWBrtkA X-Received: by 2002:a17:906:26ce:: with SMTP id u14mr2190608ejc.78.1602060397445; Wed, 07 Oct 2020 01:46:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602060397; cv=none; d=google.com; s=arc-20160816; b=MmVmMi5+t3utKnE5mLkG0WHCJU12Sswb4i7Q0iNmohSxgiJQHx+HX8i/SaIHxouLO+ 9WJtPeavUe4dcRayL43wKJ/oz/Q9f0QmoMHwBra/DES5oaKh485zli/sjM7OIU0MC4Uw 53edYbepKRZtXVbTzrwObc8UtIEgBUWch9SFVTE0tmTIZAumbn3oQYtqabF+OSYnpwsd cLrQSifeahKJqqqQJt8OaYRmxUc6R+ZKFPZQH5yNH5JT8ln6BXflzFyEMHHrv7Usidck Zwxdrx0Xn/m8kbHET8Zzydb8G7kL0kGHh4B7/g0/ma5goN9nX9U0sXNgwaKuIBEKM4eS c1xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=ZE1xMQfNmVybZkUhYsrtsUO9SldWP5ubPV2MgZ8O+LE=; b=UusQmXacFCAG4pAFtsF7J/MNLBsoGzDwpErDvxH7fMCyjqlDnTQDPd1tueTKhtavBB ROiN1nyvjR95r0C4w7ix+UrIkj/e9cfJ9K/aiPo+qQ3JXxjGnybgKt3wunpM2zZRQQu/ qwhWw+JHa1l5wtOEkxsDBDBW0n8YGERipFOf0qeTWv7KfwxiEW32r0wlaDm8/Tv3oDFv efJrqWO7Jtwjg865R5doZLU08Q72REdbaIksSeB25VXSM4Zo49B65UiTlcH9LTcGJ1rJ 9o65xFyfkJqGMy/2uueYMXK3AzU3Igw5VFUSCax2jGHXme9dKjFLHtz1DOkUXS/6ulSe ttXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rk14si1025665ejb.56.2020.10.07.01.46.13; Wed, 07 Oct 2020 01:46:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgJGIpN (ORCPT + 99 others); Wed, 7 Oct 2020 04:45:13 -0400 Received: from gentwo.org ([3.19.106.255]:50500 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727863AbgJGIpM (ORCPT ); Wed, 7 Oct 2020 04:45:12 -0400 Received: by gentwo.org (Postfix, from userid 1002) id 36BF23F0D9; Wed, 7 Oct 2020 08:45:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 34D473EC1B; Wed, 7 Oct 2020 08:45:10 +0000 (UTC) Date: Wed, 7 Oct 2020 08:45:10 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Dave Hansen cc: linux-kernel@vger.kernel.org, ben.widawsky@intel.com, rientjes@google.com, alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org, akpm@linux-foundation.org, ying.huang@intel.com, dan.j.williams@intel.com, cai@lca.pw, stable@vger.kernel.org Subject: Re: [RFC][PATCH 01/12] mm/vmscan: restore zone_reclaim_mode ABI In-Reply-To: <20201006205106.52F4D02E@viggo.jf.intel.com> Message-ID: References: <20201006205103.268F74A9@viggo.jf.intel.com> <20201006205106.52F4D02E@viggo.jf.intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Oct 2020, Dave Hansen wrote: > But, when the bit was removed (bit 0) the _other_ bit locations also > got changed. That's not OK because the bit values are documented to > mean one specific thing and users surely rely on them meaning that one > thing and not changing from kernel to kernel. The end result is that > if someone had a script that did: Exactly right. Sorry must have missed to review that patch. Acked-by: Christoph Lameter