Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp246133pxu; Wed, 7 Oct 2020 01:50:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU3I1BiY7LN2TPYq85jJjtdQot99tqm58XWY3dvt9xD1Exz57seydeReU1UVnzXP+IEs0I X-Received: by 2002:a05:6402:945:: with SMTP id h5mr2477909edz.6.1602060602621; Wed, 07 Oct 2020 01:50:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602060602; cv=none; d=google.com; s=arc-20160816; b=Qtjob1GrmahPzUmZfKDNMtOQsN1KtYm9X3gf4EAJBxCwcqLrw1mpj7nG0Rq3wxP/7Q dbf2GKJw/7NKPkieVUIX4TTjst+gxmOotOOdXu6v/NoUVdznY+Jxht1PYB6iRCwa/N4G QR9k6g7ByE/lZGuLAR64I72X4H6V7+Xl/UXlxRG1S/Dhqpq9lcgEwbzOvLZ5/cfO878u VNDPFgAe0uC9VPooGPMjjCI1QBVQJF6huV4oCNQwBZQF0NUBX4M8kX7+d42j+CzyaFQl qGUBL8cCXu3Rb8EPwrIC+3sKBcFO69CwKqvLmZ9iJoX/3yV/g3tjXLE5MFIgEq0l5a/6 X/eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BwAp6oWIbhPJ0Y92uIvOfYyvA58SH3atEk/9vrNdjBM=; b=EU9bWWc2hqIB5fQ9gWDkzBDcCdeR0X8sdkIfcE+fenHqnee4oUlJNg9krg9CGfIJlI qMOU3Cn1rcpwEPgxUeUJXKadpwzg1lEgSXx8ZqVtyyD5nZwT90vw2u33zF2xJ1zsU9e2 PM23YScs8HFp1YbKJyHsacCbTM2ARlBUhrQ9B5MTS/7PLhgt2OdH/UCNXwGK9OR96aXg ZuFdgMFzVSPCMd4r/DI36DlBE6o7L+JCjjbjCfPvB2wPOSuHFd0s5u8/birwpSxRYkm0 uhuJij9Exa7CV/udWMwavMYCEu/02OCg4sbQU+ez59UR+CnbhGmXewAxEo3nMvKdA+K6 eyOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hh2si1147642ejb.601.2020.10.07.01.49.38; Wed, 07 Oct 2020 01:50:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727878AbgJGIsn (ORCPT + 99 others); Wed, 7 Oct 2020 04:48:43 -0400 Received: from mailout01.rmx.de ([94.199.90.91]:33408 "EHLO mailout01.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbgJGIsn (ORCPT ); Wed, 7 Oct 2020 04:48:43 -0400 Received: from kdin02.retarus.com (kdin02.dmz1.retloc [172.19.17.49]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout01.rmx.de (Postfix) with ESMTPS id 4C5p065Bzjz2SV5X; Wed, 7 Oct 2020 10:48:38 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin02.retarus.com (Postfix) with ESMTPS id 4C5nz56Zb1z2TTLV; Wed, 7 Oct 2020 10:47:45 +0200 (CEST) Received: from N95HX1G2.wgnetz.xx (192.168.54.119) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 7 Oct 2020 10:46:56 +0200 From: Christian Eggers To: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , "David Laight" CC: Pengutronix Kernel Team , NXP Linux Team , , , , Christian Eggers , Krzysztof Kozlowski , Subject: [PATCH v5 2/3] i2c: imx: Check for I2SR_IAL after every byte Date: Wed, 7 Oct 2020 10:45:23 +0200 Message-ID: <20201007084524.10835-3-ceggers@arri.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201007084524.10835-1-ceggers@arri.de> References: <20201007084524.10835-1-ceggers@arri.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.54.119] X-RMX-ID: 20201007-104745-4C5nz56Zb1z2TTLV-0@kdin02 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arbitration Lost (IAL) can happen after every single byte transfer. If arbitration is lost, the I2C hardware will autonomously switch from master mode to slave. If a transfer is not aborted in this state, consecutive transfers will not be executed by the hardware and will timeout. Signed-off-by: Christian Eggers Tested (not extensively) on Vybrid VF500 (Toradex VF50): Tested-by: Krzysztof Kozlowski Cc: stable@vger.kernel.org --- drivers/i2c/busses/i2c-imx.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index cbdcab73a055..63575af41c09 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -490,6 +490,16 @@ static int i2c_imx_trx_complete(struct imx_i2c_struct *i2c_imx, bool atomic) dev_dbg(&i2c_imx->adapter.dev, "<%s> Timeout\n", __func__); return -ETIMEDOUT; } + + /* check for arbitration lost */ + if (i2c_imx->i2csr & I2SR_IAL) { + dev_dbg(&i2c_imx->adapter.dev, "<%s> Arbitration lost\n", __func__); + i2c_imx_clear_irq(i2c_imx, I2SR_IAL); + + i2c_imx->i2csr = 0; + return -EAGAIN; + } + dev_dbg(&i2c_imx->adapter.dev, "<%s> TRX complete\n", __func__); i2c_imx->i2csr = 0; return 0; -- Christian Eggers Embedded software developer Arnold & Richter Cine Technik GmbH & Co. Betriebs KG Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918 Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477 Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler