Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp261419pxu; Wed, 7 Oct 2020 02:20:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2oUX2IwZ64/ghRuN40yvaaeFm00T4fczph+ei0b0bb43kajHw6H3Omrw6MVGasxMJ+qZj X-Received: by 2002:a17:906:4151:: with SMTP id l17mr2523422ejk.83.1602062418078; Wed, 07 Oct 2020 02:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602062418; cv=none; d=google.com; s=arc-20160816; b=UkfLlZnXSiddxvHFaU5gbx98LXECMKMgkGS2MJefFiKemumSU9uPa1giUU+j09E4DR uizh5QYBQNHumaL/Zln/F2vvJcMIU4cANVKvfucmKxNavnmE4Rn7Eun38x1T6F67BRxd IIm6tqWdCff0ygPRRmQNeV6R/AJcX1tM5rYOmMrZr5djz1rcG/x2LMceeHwgeXlFCF0V AOTqMDV4sJ9i5lNzJDaOf/6GsDmhdnEN1bPFfOuUabY4KovWCpPY6UziVHHa+Yphtb1h N11EdeBVnc+AOPsH/Oo5Ov0VE0E2pMKESRFAETclCpIx9a52vaeNLhkfar9BYm9JiAx1 ar7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=8uGh7FwCQVsEaQRU10K3At5FG2/9JxC6uGho+Uy5WLc=; b=jxtZ5BN+ms0982vAcSu0zeri6X9YB6R/3jZqnaTMeN5T6Kw6Y1H3EESLb0PLuJBV0W XCHihhcZN0z5Qx2KTU7HKeNBf7fiHUs3N6DpfhrWhDtkznOi9uB+rIShQ+U3Si41jZQd nuG9b065rQjB9KlgrSSUyqoMzFC/+NBTw8wC97HHjEQnMWiBA1zShvbEARbpTHMlRpPC U7X9XI85rkUddQOxnMqZyhnT9pgefokT/CH5GpN0Iga+O5S56kdWYrQ2aDLVW7pCaWY8 NXIj8Z9HX7lIdOHBxFa35AanL7bYgwixF/Q5b4HSiDNuCqjZMTzS5snGUqO/SMPi2brr wKyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ZMS9/cve"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si1009978ejt.731.2020.10.07.02.19.54; Wed, 07 Oct 2020 02:20:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ZMS9/cve"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726854AbgJGJR4 (ORCPT + 99 others); Wed, 7 Oct 2020 05:17:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbgJGJRy (ORCPT ); Wed, 7 Oct 2020 05:17:54 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4815C0613D5 for ; Wed, 7 Oct 2020 02:17:53 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id a4so1207133lji.12 for ; Wed, 07 Oct 2020 02:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8uGh7FwCQVsEaQRU10K3At5FG2/9JxC6uGho+Uy5WLc=; b=ZMS9/cveuDXMSwvbiHVUdNS/sgKoK13pgzqeUFPU59/WIF9oXdaca+YvED7s3BfwzW 9UuBhNQoTOQPd9LrtPqbQUCI5PDAXN0pOGjko8yChPSAdQ1yjmpCxf+4yLx0E84c0Gi+ WwvhbqXrKCuLurT50RFhcAH6nlljW06Q+QCKzerzY9+cfMVPygmYKdIuohTS3WZRN1NZ FXCYzQ70GGKpk1N1JboJQ0CFkVSBlZSn1xFIVeqDWPBwXaZx3QX1OQFdFAdwEGkURHPs +cvrcW2BbRJWPD6ck611GV7NU1QoaLRP+0+AaYZELuUHw7WnkeaPvAjfcwp5R5oegfSQ xePA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8uGh7FwCQVsEaQRU10K3At5FG2/9JxC6uGho+Uy5WLc=; b=Ybur3EODwzVb6IRZnACnB0M8NxzHcQvRV3WDBhniYGy6L6qZJhJ9Wu7Etv+O6rozUW D4B9qcnGUAMrUporZdjt85BK85OU7OfuqWqO+03Bn0fLkt/x2SYP0Z7mJBOjVyVxJOCH rR/sYxn8D2vXB3SYbiHIsPVVP9asUwIRZwMsNvH+VLvvNHCAjLG1iJJ563beyjIoMvLS cPDErCAVXbkgMews/BIDIROFxYHdDGE+lLr+ATpSoO9FFJyU98obRp0wnEIx+8j+U2S8 k9cJ9bb89H6TtE5MvvMqUv489I++7rZ6LrXFO1EXVRUDH6qPenySlk1ACsDV0uNtN2TK vEUw== X-Gm-Message-State: AOAM532p6lFoJrCwr3CU5c5qtO9UKSAb+gBrImjt95jNxoEQ+QXm43Rg ZcUyuAR3x5p8oXkX+uGZ3re27mQqIiRxZKS08pAgvIr2a7UjHN2t X-Received: by 2002:a2e:9b0c:: with SMTP id u12mr767730lji.338.1602062272121; Wed, 07 Oct 2020 02:17:52 -0700 (PDT) MIME-Version: 1.0 References: <20201004162908.3216898-1-martin.blumenstingl@googlemail.com> In-Reply-To: <20201004162908.3216898-1-martin.blumenstingl@googlemail.com> From: Linus Walleij Date: Wed, 7 Oct 2020 11:17:41 +0200 Message-ID: Subject: Re: [RFC PATCH 0/3] GPIO support on the Etron EJ168/EJ188/EJ198 xHCI controllers To: Martin Blumenstingl , linux-usb Cc: linux-pci , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Rob Herring , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , Bjorn Helgaas , systemchip@etron.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl wrote: > The goal of this series to add support for the GPIO controller on the > Etron EJ168/EJ188/EJ198 controllers. This overall is a fine driver, but have you considered the option of just implementing the GPIO chip in drivers/usb/host/xhci-pci.c? There are several USB serial adapters that have a GPIO chip embedded and we just add the GPIO chip into the serial driver. I have done the same with some networking switches. It is perfectly fine for drivers outside of drivers/gpio to occasionally define a minor GPIO chip if GPIO is not their primary function. Please consider simply activating the XHCI driver and make it instantiate a GPIO chip if it happens to be an EJ168/EJ188/EJ198 controller. Yours, Linus Walleij