Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp279054pxu; Wed, 7 Oct 2020 02:56:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaBpSckLKlMYkM0lsAvnvyppZfMzekN5/Bcmzy/Az1rXIcFhyaaqVMmwlbFYug7SXp8fmp X-Received: by 2002:a17:906:82d5:: with SMTP id a21mr2499629ejy.548.1602064596360; Wed, 07 Oct 2020 02:56:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602064596; cv=none; d=google.com; s=arc-20160816; b=C4+eGiN7FjqYwcT6UOwQfdibJZ2H7OPFegZ6kGZgBJryUUy/iorOBzYNaulGhz+SVs PLLwt63/9RdP/PyRGTOxaTzMwjjqsKfL4OxJ//6B1O+v/dq7+JDcaFOsWWwWzk4y/una UzcY5BFPg4DjeEZWDchGlwkyKuN8GYlfh4F4aS7TNaqzK4cmaCEcXNDo9W+sDhy0oZxp 4pYH8YNZYet/XIYwkX9pwmlsdzMrPSqYiIQy2bWQy6u0194hpqZoOyTExotaKHMUDMOx /RMCwg+qhJ7Es+NuSCl4LThXtFb0becTDckIaSQpjwC8B0TLf5S4Hg1p5lEDfDmAf3i4 Y/GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v9YEdyVZwCu3c28PJPIbBnmYut5XP2GLOBi1ecqX5OY=; b=hYukDQ5WurHtDKbcnv/dZYssmjUZTUPw5uDhdclipBR/ogfrYb1G5to+5avGOxFxwb sVq/SPBrsfPcro7g5/ya0iHVl807cmFb9n9/cxpKXY48AfdOwHzdg7P1kcsv6SOXH8k7 xTXjJy3xOyi/knT7PnJ5H9dws3ZY52hDhj+vQwygo3yLswGhpkiF6vvyriF0lv+xQaQ8 ResxTU3++k9OlcmVpXdIpnWDCPQcam0UZ2krqSY4QArUrUeVQfYekMtnUNRnRqk8pVTV eAPGzne4xuVjtM903CVrmmhok30f8NHBYztNGA9BzTEubl0xIF9RARQ6mzyT5U2kCxpP I23w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=VOO4Zd2O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b19si1029180edw.132.2020.10.07.02.56.12; Wed, 07 Oct 2020 02:56:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=VOO4Zd2O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbgJGJwa (ORCPT + 99 others); Wed, 7 Oct 2020 05:52:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:55780 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbgJGJwa (ORCPT ); Wed, 7 Oct 2020 05:52:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602064349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9YEdyVZwCu3c28PJPIbBnmYut5XP2GLOBi1ecqX5OY=; b=VOO4Zd2OEcuuBxsAEhNXy3HuHnlW1KHS0EM09c25Ld3WP+Avp6xVS5wRejt2pM080TRg1h cLqfKxBecA2ENqliIXeqcsVhktSBxKv53lJasl1gyfhDpsjolxYoikzSzUvttgLxIfLhGb yHO4OUGhR92XtYkT/GNl9++IhBuz9ZI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E192AED9; Wed, 7 Oct 2020 09:52:29 +0000 (UTC) Date: Wed, 7 Oct 2020 11:52:25 +0200 From: Michal Hocko To: Dave Hansen Cc: linux-kernel@vger.kernel.org, npiggin@gmail.com, akpm@linux-foundation.org, willy@infradead.org, yang.shi@linux.alibaba.com, linux-mm@kvack.org Subject: Re: [RFC][PATCH 00/12] mm: tweak page cache migration Message-ID: <20201007095225.GH29020@dhcp22.suse.cz> References: <20201006205103.268F74A9@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201006205103.268F74A9@viggo.jf.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am I the only one missing patch 1-5? lore.k.o doesn't seem to link them under this message id either. On Tue 06-10-20 13:51:03, Dave Hansen wrote: > First of all, I think this little slice of code is a bit > under-documented. Perhaps this will help clarify things. > > I'm pretty confident the page_count() check in the first > patch is right, which is why I removed it outright. The > xas_load() check is a bit murkier, so I just left a > warning in for it. > > Cc: Nicholas Piggin > Cc: Andrew Morton > Cc: Matthew Wilcox (Oracle) > Cc: Yang Shi > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org -- Michal Hocko SUSE Labs