Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp308743pxu; Wed, 7 Oct 2020 03:50:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUxx6cERUBSkwKckPnGh/V7RuLgqVcuZKahw3W8eA3WgjCbFJ0oRZEhROH38hU8eKnU4ZG X-Received: by 2002:a17:906:ad5:: with SMTP id z21mr2572272ejf.461.1602067817677; Wed, 07 Oct 2020 03:50:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602067817; cv=none; d=google.com; s=arc-20160816; b=kQUa9weV9tFM1vJ61yZz9Qk49SJJTq6RGA2xUYHFWgHF1077QpT2/NA4rviF1Jy90T MW0X3pJLNI2ZuYzAFq1FjYLNB7yxfYWlp50T9e3/fG23MUYAE8anoYoxU+1XfSDPj2Y1 T+ENvnYA6Ir4dmg/FK+f4eOjv7szoLCmCeGFIXxKX/tNqPdLqLEpCn72wJEbqWfKay16 4Hmj3H545r874a90XdyfJ4iX5QjL1NllNTWJRtbneKWwBEKtrrWzYo1GV7YSS3dRAmxO jnINK8zFwkPuvEvd4OIHALxNjxDrU8v+p4sV5OlvrR71pEHZ3Y5rU7BgQHBQ3de0LZGq DLQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=Y10OUXTfQgXPU0A5oUJnDdIwLJs8VsupIA9eqLDtdXI=; b=RdlcHcv5e1FbtoQlT8TfudgxqlqlKSTta1ojvlOJtheIOM8Js7bAbl8yyiby78Bj5L HaAnIPvNuD0D5xpktxhALrWNQYWGlLsBofS0j2/Ru0GRkNNvhJ/BSdqDNIHB0EOgqcXy nHcx+mZIgvgw7GzZZ/yYzkRi28QnCSG+Bmi0uJuJpIKp1l8yBN+fk/2dQxCU2cuVJvlX CFb4rk/wGuWed2pKVz8CGIYGdnGwZJzES6yCaDqvO6ft7PUqOVgnJj0GDYXvJYBcMQ2r aM1RZuXMRJIeQ/KnuqWgFb22A0hAG94ndJ5qFapl0ntAhPzQJ3nHNrg/gV58ylVfQnSl M0xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu17si1160959ejb.24.2020.10.07.03.49.54; Wed, 07 Oct 2020 03:50:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728132AbgJGIrO (ORCPT + 99 others); Wed, 7 Oct 2020 04:47:14 -0400 Received: from gentwo.org ([3.19.106.255]:50540 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727940AbgJGIrN (ORCPT ); Wed, 7 Oct 2020 04:47:13 -0400 Received: by gentwo.org (Postfix, from userid 1002) id C22353F463; Wed, 7 Oct 2020 08:47:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id C10D83EC1B; Wed, 7 Oct 2020 08:47:11 +0000 (UTC) Date: Wed, 7 Oct 2020 08:47:11 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Dave Hansen cc: linux-kernel@vger.kernel.org, ben.widawsky@intel.com, alex.shi@linux.alibaba.com, tobin@kernel.org, akpm@linux-foundation.org, ying.huang@intel.com, dan.j.williams@intel.com, cai@lca.pw, dwagner@suse.de Subject: Re: [RFC][PATCH 03/12] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks In-Reply-To: <20201006205110.1E03E385@viggo.jf.intel.com> Message-ID: References: <20201006205103.268F74A9@viggo.jf.intel.com> <20201006205110.1E03E385@viggo.jf.intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Oct 2020, Dave Hansen wrote: > These zero checks are not great because it is not obvious what a zero > mode *means* in the code. Replace them with a helper which makes it > more obvious: node_reclaim_enabled(). Well it uselessly checks bits. But whatever. It will prevent future code removal. Acked-by: Christoph Lameter