Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH] scsi: qla2xxx: initialize value
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
In-Reply-To: <20201005144544.25335-1-trix@redhat.com>
Date:   Wed, 7 Oct 2020 08:32:42 -0500
Cc:     Nilesh Javali <njavali@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        natechancellor@gmail.com, ndesaulniers@google.com,
        GR-QLogic-Storage-Upstream@marvell.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <2E536F63-9F97-4B80-8538-D3176650CC70@oracle.com>
References: <20201005144544.25335-1-trix@redhat.com>
To:     trix@redhat.com
Precedence: bulk


> On Oct 5, 2020, at 9:45 AM, trix@redhat.com wrote:
>=20
> From: Tom Rix <trix@redhat.com>
>=20
> clang static analysis reports this problem:
>=20
> qla_nx2.c:694:3: warning: 6th function call argument is
>  an uninitialized value
>        ql_log(ql_log_fatal, vha, 0xb090,
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=20
> In qla8044_poll_reg(), when reading the reg fails, the
> error is reported by reusing the timeout error reporter.
> Because the value is unset, a garbage value will be
> reported.  So initialize the value.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_nx2.c =
b/drivers/scsi/qla2xxx/qla_nx2.c
> index 3a415b12dcec..01ccd4526707 100644
> --- a/drivers/scsi/qla2xxx/qla_nx2.c
> +++ b/drivers/scsi/qla2xxx/qla_nx2.c
> @@ -659,7 +659,7 @@ static int
> qla8044_poll_reg(struct scsi_qla_host *vha, uint32_t addr,
> 	int duration, uint32_t test_mask, uint32_t test_result)
> {
> -	uint32_t value;
> +	uint32_t value =3D 0;
> 	int timeout_error;
> 	uint8_t retries;
> 	int ret_val =3D QLA_SUCCESS;
> --=20
> 2.18.1
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering