Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH -next v2] scsi: qla2xxx: Convert to DEFINE_SHOW_ATTRIBUTE
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
In-Reply-To: <20200919025202.17531-1-miaoqinglang@huawei.com>
Date:   Wed, 7 Oct 2020 08:35:42 -0500
Cc:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <68C6E741-9A58-4E4E-B746-4E810EA7D651@oracle.com>
References: <20200919025202.17531-1-miaoqinglang@huawei.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>
Precedence: bulk


> On Sep 18, 2020, at 9:52 PM, Qinglang Miao <miaoqinglang@huawei.com> =
wrote:
>=20
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>=20
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> v2: based on linux-next(20200917), and can be applied to
>    mainline cleanly now.
>=20
> drivers/scsi/qla2xxx/qla_dfs.c | 68 ++++------------------------------
> 1 file changed, 8 insertions(+), 60 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_dfs.c =
b/drivers/scsi/qla2xxx/qla_dfs.c
> index e62b21152..9e49b47f6 100644
> --- a/drivers/scsi/qla2xxx/qla_dfs.c
> +++ b/drivers/scsi/qla2xxx/qla_dfs.c
> @@ -37,20 +37,7 @@ qla2x00_dfs_tgt_sess_show(struct seq_file *s, void =
*unused)
> 	return 0;
> }
>=20
> -static int
> -qla2x00_dfs_tgt_sess_open(struct inode *inode, struct file *file)
> -{
> -	scsi_qla_host_t *vha =3D inode->i_private;
> -
> -	return single_open(file, qla2x00_dfs_tgt_sess_show, vha);
> -}
> -
> -static const struct file_operations dfs_tgt_sess_ops =3D {
> -	.open		=3D qla2x00_dfs_tgt_sess_open,
> -	.read		=3D seq_read,
> -	.llseek		=3D seq_lseek,
> -	.release	=3D single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(qla2x00_dfs_tgt_sess);
>=20
> static int
> qla2x00_dfs_tgt_port_database_show(struct seq_file *s, void *unused)
> @@ -106,20 +93,7 @@ qla2x00_dfs_tgt_port_database_show(struct seq_file =
*s, void *unused)
> 	return 0;
> }
>=20
> -static int
> -qla2x00_dfs_tgt_port_database_open(struct inode *inode, struct file =
*file)
> -{
> -	scsi_qla_host_t *vha =3D inode->i_private;
> -
> -	return single_open(file, qla2x00_dfs_tgt_port_database_show, =
vha);
> -}
> -
> -static const struct file_operations dfs_tgt_port_database_ops =3D {
> -	.open		=3D qla2x00_dfs_tgt_port_database_open,
> -	.read		=3D seq_read,
> -	.llseek		=3D seq_lseek,
> -	.release	=3D single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(qla2x00_dfs_tgt_port_database);
>=20
> static int
> qla_dfs_fw_resource_cnt_show(struct seq_file *s, void *unused)
> @@ -154,20 +128,7 @@ qla_dfs_fw_resource_cnt_show(struct seq_file *s, =
void *unused)
> 	return 0;
> }
>=20
> -static int
> -qla_dfs_fw_resource_cnt_open(struct inode *inode, struct file *file)
> -{
> -	struct scsi_qla_host *vha =3D inode->i_private;
> -
> -	return single_open(file, qla_dfs_fw_resource_cnt_show, vha);
> -}
> -
> -static const struct file_operations dfs_fw_resource_cnt_ops =3D {
> -	.open           =3D qla_dfs_fw_resource_cnt_open,
> -	.read           =3D seq_read,
> -	.llseek         =3D seq_lseek,
> -	.release        =3D single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(qla_dfs_fw_resource_cnt);
>=20
> static int
> qla_dfs_tgt_counters_show(struct seq_file *s, void *unused)
> @@ -244,20 +205,7 @@ qla_dfs_tgt_counters_show(struct seq_file *s, =
void *unused)
> 	return 0;
> }
>=20
> -static int
> -qla_dfs_tgt_counters_open(struct inode *inode, struct file *file)
> -{
> -	struct scsi_qla_host *vha =3D inode->i_private;
> -
> -	return single_open(file, qla_dfs_tgt_counters_show, vha);
> -}
> -
> -static const struct file_operations dfs_tgt_counters_ops =3D {
> -	.open           =3D qla_dfs_tgt_counters_open,
> -	.read           =3D seq_read,
> -	.llseek         =3D seq_lseek,
> -	.release        =3D single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(qla_dfs_tgt_counters);
>=20
> static int
> qla2x00_dfs_fce_show(struct seq_file *s, void *unused)
> @@ -459,19 +407,19 @@ qla2x00_dfs_setup(scsi_qla_host_t *vha)
>=20
> create_nodes:
> 	ha->dfs_fw_resource_cnt =3D =
debugfs_create_file("fw_resource_count",
> -	    S_IRUSR, ha->dfs_dir, vha, &dfs_fw_resource_cnt_ops);
> +	    S_IRUSR, ha->dfs_dir, vha, &qla_dfs_fw_resource_cnt_fops);
>=20
> 	ha->dfs_tgt_counters =3D debugfs_create_file("tgt_counters", =
S_IRUSR,
> -	    ha->dfs_dir, vha, &dfs_tgt_counters_ops);
> +	    ha->dfs_dir, vha, &qla_dfs_tgt_counters_fops);
>=20
> 	ha->tgt.dfs_tgt_port_database =3D =
debugfs_create_file("tgt_port_database",
> -	    S_IRUSR,  ha->dfs_dir, vha, &dfs_tgt_port_database_ops);
> +	    S_IRUSR,  ha->dfs_dir, vha, =
&qla2x00_dfs_tgt_port_database_fops);
>=20
> 	ha->dfs_fce =3D debugfs_create_file("fce", S_IRUSR, ha->dfs_dir, =
vha,
> 	    &dfs_fce_ops);
>=20
> 	ha->tgt.dfs_tgt_sess =3D debugfs_create_file("tgt_sess",
> -		S_IRUSR, ha->dfs_dir, vha, &dfs_tgt_sess_ops);
> +		S_IRUSR, ha->dfs_dir, vha, &qla2x00_dfs_tgt_sess_fops);
>=20
> 	if (IS_QLA27XX(ha) || IS_QLA83XX(ha) || IS_QLA28XX(ha))
> 		ha->tgt.dfs_naqp =3D debugfs_create_file("naqp",
> --=20
> 2.23.0
>=20

Nice cleanup.=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering