Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp497439pxu; Wed, 7 Oct 2020 08:24:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOdnkwv3Wl8FtlCTd86z5s2EOiLO1NsY7QWTnhe0riH9rrlPIam917WMI00NhY04GGJMf6 X-Received: by 2002:a05:6402:2cf:: with SMTP id b15mr4091974edx.332.1602084282000; Wed, 07 Oct 2020 08:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602084281; cv=none; d=google.com; s=arc-20160816; b=NblGa9NJOkqzdKtY6VnXYKTprQ0bIBlPkdt77cLN6/Tv28NEPxqMIiOfmXkVtnzUjP ucr07Cu19Gd6PudpSw7wl98d/gzS1Lg+1DbwDKknGk0tzUChQHk4KLgF/CRfWk1ScTKC oBbLJLHxNh9Ihjm3C6kGH3W5BdcADqjLD62u+GeMafjkXDQ+Qlw9Ppn/a1VOwhqIu/C4 ZpmCwtT5ypCrcd70VtdzwO5Sm++h+umQ9Sd2Da/k6/lXcAkCmn1wD/3zJWfu3c2CvUSn um3IoKYW/EcyEzlIVPeZzp3gla6EjrTJtaw0W2Bg6pRYfTLRbv4UFq5IGBAOYPQJl0fp t/fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=z4VpTvoOOZp6qQHLtmXVaZGYtqgiD52MMsRvSIv4cjk=; b=NezYLc0Q6r9zRVPBJvySmpzGTgOIdgP2a/rR0+G29k9iv2qzc+LKJA71WvSV0tO/h3 cfNDBG1mTHtkBMpW5dUdltQloy3lQ7VsRFcC9yJLnDAkrutB+Ww12z0uwNiRGfiV6ucU 0IYvcUyHlBfD5rsvy0fX5v+Owf1bvktUt6BD5x3KKu/aHFihXrMecfhyMBcA3U1CvaZU xkRQ1M6BQ9/4BJST4y5N4myxkw77XEsyusLguYTN3KOLFixloeqdGZja8gQ68SIUcNs0 OzW5puR/5SyBUASBcPMfw+ltx/UAQ9G7yko/aP1R8Fp4XZIh326ZUraEOsGhYidFC9lo /Gew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=nzD+cJGi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b11si2074560ejz.700.2020.10.07.08.24.19; Wed, 07 Oct 2020 08:24:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=nzD+cJGi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgJGIE5 (ORCPT + 99 others); Wed, 7 Oct 2020 04:04:57 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:37132 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbgJGIE4 (ORCPT ); Wed, 7 Oct 2020 04:04:56 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09784mu1057707; Wed, 7 Oct 2020 03:04:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602057888; bh=z4VpTvoOOZp6qQHLtmXVaZGYtqgiD52MMsRvSIv4cjk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nzD+cJGiqOp91ekDNpfsxNGIs/X2hqgR1/2TScI6DWvMMAgMaouLaYfh54tgc78Xr xAbrdEc8GjzTncRCdVAnFpG6M5Jm7a4MsvIYZtOAcOIv0lKLkKhKRNbWcPcHoDP8VS rrijELMbgAPscIh5ozllkgblYPh6Hfc/1hEgPPwQ= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09784mQ8112342 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Oct 2020 03:04:48 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 7 Oct 2020 03:04:48 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 7 Oct 2020 03:04:48 -0500 Received: from [192.168.2.14] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09784j5R103861; Wed, 7 Oct 2020 03:04:46 -0500 Subject: Re: [PATCH] usb: cdns3: Add static to cdns3_gadget_exit function To: Pawel Laszczak , CC: , , , , , References: <20201007040230.25741-1-pawell@cadence.com> From: Roger Quadros Message-ID: <34195846-65f5-c3b3-b883-bed27a401814@ti.com> Date: Wed, 7 Oct 2020 11:04:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201007040230.25741-1-pawell@cadence.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/2020 07:02, Pawel Laszczak wrote: > Function cdns3_gadget_exit is used only in gadget.c file. > This patch removes declaration and definition of this > function from gadget-export.h file and makes it static. > > Signed-off-by: Pawel Laszczak Acked-by: Roger Quadros > --- > drivers/usb/cdns3/gadget-export.h | 3 --- > drivers/usb/cdns3/gadget.c | 2 +- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/cdns3/gadget-export.h b/drivers/usb/cdns3/gadget-export.h > index 577469eee961..702c5a267a92 100644 > --- a/drivers/usb/cdns3/gadget-export.h > +++ b/drivers/usb/cdns3/gadget-export.h > @@ -13,7 +13,6 @@ > #ifdef CONFIG_USB_CDNS3_GADGET > > int cdns3_gadget_init(struct cdns3 *cdns); > -void cdns3_gadget_exit(struct cdns3 *cdns); > #else > > static inline int cdns3_gadget_init(struct cdns3 *cdns) > @@ -21,8 +20,6 @@ static inline int cdns3_gadget_init(struct cdns3 *cdns) > return -ENXIO; > } > > -static inline void cdns3_gadget_exit(struct cdns3 *cdns) { } > - > #endif > > #endif /* __LINUX_CDNS3_GADGET_EXPORT */ > diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c > index 692acf7b9b14..6ff3aa3db497 100644 > --- a/drivers/usb/cdns3/gadget.c > +++ b/drivers/usb/cdns3/gadget.c > @@ -3069,7 +3069,7 @@ static void cdns3_gadget_release(struct device *dev) > kfree(priv_dev); > } > > -void cdns3_gadget_exit(struct cdns3 *cdns) > +static void cdns3_gadget_exit(struct cdns3 *cdns) > { > struct cdns3_device *priv_dev; > > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki