Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 07 Oct 2020 17:31:29 +0200
Message-ID: <s5h5z7m129a.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jian-Hong Pan <jhp@endlessos.org>
Cc:     Takashi Iwai <tiwai@suse.com>, Kailang Yang <kailang@realtek.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linux@endlessm.com
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887
In-Reply-To: <20201007052224.22611-1-jhp@endlessos.org>
References: <s5hmu0z5ypi.wl-tiwai@suse.de>
        <20201007052224.22611-1-jhp@endlessos.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 07 Oct 2020 07:22:25 +0200,
Jian-Hong Pan wrote:
> 
> The ASUS D700SA desktop's audio (1043:2390) with ALC887 cannot detect
> the headset microphone and another headphone jack until
> ALC887_FIXUP_ASUS_HMIC and ALC887_FIXUP_ASUS_AUDIO quirks are applied.
> The NID 0x15 maps as the headset microphone and NID 0x19 maps as another
> headphone jack. Also need the function like alc887_fixup_asus_jack to
> enable the audio jacks.
> 
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> Signed-off-by: Kailang Yang <kailang@realtek.com>
> ---
> v2:
>  - Change the magic numbers to meaningful macros.
>  - Change snd_hda_codec_write to snd_hda_set_pin_ctl and
>    snd_hda_set_pin_ctl_cache accroding to Takashi's suggestion

Thanks, applied.


Takashi