Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201007035108.31078-1-david.e.box@linux.intel.com> <20201007035108.31078-3-david.e.box@linux.intel.com>
In-Reply-To: <20201007035108.31078-3-david.e.box@linux.intel.com>
From:   Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
Date:   Wed, 7 Oct 2020 11:47:02 -0400
Message-ID: <CAE2upjSbSw1cbR3oThQ-Tc4nR6-bbDvtUU28rkE9iD3vWsY9Jg@mail.gmail.com>
Subject: Re: [PATCH 2/4] platform/x86: intel_pmc_core: Add Intel RocketLake
 (RKL) support
To:     "David E. Box" <david.e.box@linux.intel.com>
Cc:     david.e.box@intel.com, dvhart@infradead.org, andy@infradead.org,
        gayatri.kammela@intel.com, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Rui Zhang <rui.zhang@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 6, 2020 at 11:51 PM David E. Box
<david.e.box@linux.intel.com> wrote:
>
> From: Gayatri Kammela <gayatri.kammela@intel.com>
>
> Add RocketLake to the list of the platforms that intel_pmc_core driver
> supports for pmc_core device. RocketLake reuses all the TigerLake PCH IPs.

Just a nit here - I guess the convention was to leave a space in IP
names such as "Tiger Lake", "Rocket Lake" like it's done in previous
patches too. I am not sure whether it's a new convention but it's good
to be consistent throughout the series.

Other than that, the series is:
Reviewed-by: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>

>
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: David E. Box <david.e.box@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Rui Zhang <rui.zhang@intel.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
>  drivers/platform/x86/intel_pmc_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index d959fa698ec5..f0347ee8a4d6 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -1155,6 +1155,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
>         X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,           &tgl_reg_map),
>         X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT,        &tgl_reg_map),
>         X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,      &icl_reg_map),
> +       X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE,          &tgl_reg_map),
>         {}
>  };
>
> --
> 2.20.1
>


-- 
Thanks,
Rajneesh