Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fs: use correct parameter in notes of
 generic_file_llseek_size()
To:     Tianxianting <tian.xianting@h3c.com>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Cc:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20200905071525.12259-1-tian.xianting@h3c.com>
 <3808373d663146c882c22397a1d6587f@h3c.com>
 <07de1867-e61c-07fb-8809-91d5e573329b@infradead.org>
 <e028ff27412d4a80aa273320482a801d@h3c.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <b2bd4f65-3054-3c08-807f-f1e800c122ed@infradead.org>
Date:   Wed, 7 Oct 2020 09:50:00 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <e028ff27412d4a80aa273320482a801d@h3c.com>
Content-Type: text/plain; charset=gbk
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/7/20 8:20 AM, Tianxianting wrote:
> hi,
> 
> thanks Randy
> 
> I checked the latest code, seems this patch not applied currently.

Hi--

Please don't send html email.
I'm pretty sure that the mailing list has dropped (discarded) your email
because it was html.

Probably only Al and I received your email.

Al- Would you prefer that fs/ documentation patches go to someone else
for merging?  maybe Andrew?

Thanks.

PS: I can't tell if I am writing an html email or not... :(


> ________________________________
> ??????: Randy Dunlap <rdunlap@infradead.org>
> ????ʱ??: Friday, September 11, 2020 10:57:24 AM
> ?ռ???: tianxianting (RD); viro@zeniv.linux.org.uk
> ????: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org
> ????: Re: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()
> 
> On 9/10/20 7:06 PM, Tianxianting wrote:
>> Hi viro,
>> Could I get your feedback?
>> This patch fixed the build warning, I think it can be applied, thanks :)
>>
>> -----Original Message-----
>> From: tianxianting (RD)
>> Sent: Saturday, September 05, 2020 3:15 PM
>> To: viro@zeniv.linux.org.uk
>> Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) <tian.xianting@h3c.com>
>> Subject: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()
>>
>> Fix warning when compiling with W=1:
>> fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size'
>> fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size'
>>
>> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Thanks.
> 
>> ---
>>  fs/read_write.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/read_write.c b/fs/read_write.c
>> index 5db58b8c7..058563ee2 100644
>> --- a/fs/read_write.c
>> +++ b/fs/read_write.c
>> @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos);
>>   * @file:    file structure to seek on
>>   * @offset:  file offset to seek to
>>   * @whence:  type of seek
>> - * @size:    max size of this file in file system
>> + * @maxsize: max size of this file in file system
>>   * @eof:     offset used for SEEK_END position
>>   *
>>   * This is a variant of generic_file_llseek that allows passing in a custom
>>
> 
> 
> --
> ~Randy
> 

-- 
~Randy