Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp569829pxu; Wed, 7 Oct 2020 10:04:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8IqwwZ5E0GXKVmCmd8boJEnMATujejUv/UcHcwY12exBl8AI7d95rABwP674LTfZlTGQQ X-Received: by 2002:a50:9e6a:: with SMTP id z97mr4848525ede.32.1602090286568; Wed, 07 Oct 2020 10:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602090286; cv=none; d=google.com; s=arc-20160816; b=de/KTZlC/wkYrP0hDC+BJN71Dypf0CQWr2fXYmHQN10cKevNI5yMvbi+xx/f/UswOj TVxjb9xUF72uqItj1rclWtqoiGeQgJp18i7z4S8wZ36w875IOiemZDQq4ys6fLx7CqFF 3Rl99Sedf2XIO5c5uAiWUnAo03rlc1Qm3pZhnSgME/vQOYIsTU/wrpibJuN9ze9zU+jp ejCLPTqD1tGVgB0fYj6So62+0BXicIkhZaC5AXGpH+RzLA4UoigMHb/5XqqwwkmT5Gxt Jj+scQ1pkF2jYpS0D5J357Y+COqhLzVxKDaJ1+oHAwn+Ke0r9O9VR4YqmGJEKpO1NUCj Fx2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=uGLqe4D4Pdgjs0FfCRH8TIwDpofHT3tZXnON5CQi8fk=; b=YAiazYdw/Rl0/gw54tK4kAvh7kdek2TB6IZmm8BkxzXEfPdYZbEtcnZ10TGDy5xfmq ySGWisQylLVSX+pY7FHuHBlE8OK4OSSIm4jnUfLJkpcvFM1i9FT3KhSMQFaWiA6wjdF9 MEwwEl35p5MtDcfJv9f2Be/eAk+4SHCf7ZrYd7Ub01nN3m/R2iP6N3E4e+S7fFrFXzri Oh1wwLHqgphJczvO5ihpTLBRswxil5gHgdbEvswCQMvfDO3HwIKsAoDGIZioUta3lX0W Hwu/wTA8RVDB0vw3usl6omUY8ec8MPq5RKbLcEckVMXH7XYkqgbv7CD+HhkcrEz9LiR2 tyRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bHoWK5AL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si1785151eje.690.2020.10.07.10.04.14; Wed, 07 Oct 2020 10:04:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bHoWK5AL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728124AbgJGKpF (ORCPT + 99 others); Wed, 7 Oct 2020 06:45:05 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44564 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbgJGKpF (ORCPT ); Wed, 7 Oct 2020 06:45:05 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 097AP6ng163964; Wed, 7 Oct 2020 06:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=uGLqe4D4Pdgjs0FfCRH8TIwDpofHT3tZXnON5CQi8fk=; b=bHoWK5AL8LoORqDMNDXnRDcIthU3aL4z/MHFUpqaErqK5HanCDRdhCGhjckdIcb68KUg N/dFYY32i9nMxiUcOcbSGjMphGz6w32BzTtJOFiatCTcN7z4guyfkrWJ3ctLqDfjKTcj i6HbUZbdIc0OcYdTQnvdtK4wIMj/E6PafcmZ6PHi7EtWWpk9Hbfr+hohEa3aQi/g3rNm AEmRoaXuCPOMUllj1XPA5GIc5utxjiaN/ep2JqoJdURwn9vGS5d5OtmhEtkt4oLyBowU Y1rRs2xeR/y7tMzkK7/kpdyooRtEdq26ehbaReoulT62Ox0tNKQ4QMnewWh/YTVZ5efe Rw== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 341bwdgjub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Oct 2020 06:45:01 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 097AgZ9w021674; Wed, 7 Oct 2020 10:44:59 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma05fra.de.ibm.com with ESMTP id 33xgx826af-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Oct 2020 10:44:58 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 097AiuJI32112962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Oct 2020 10:44:56 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 273C0A404D; Wed, 7 Oct 2020 10:44:56 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC30FA4053; Wed, 7 Oct 2020 10:44:55 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.145.175.219]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 7 Oct 2020 10:44:55 +0000 (GMT) Subject: Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls To: Christoph Hellwig Cc: Stefan Haberland , axboe@kernel.dk, hoeppner@linux.ibm.com, linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com, gor@linux.ibm.com, linux-kernel@vger.kernel.org References: <20200519142259.102279-1-sth@linux.ibm.com> <20200519142259.102279-3-sth@linux.ibm.com> <5c815b8a-7d77-5c69-9191-d09cc433f5ff@de.ibm.com> <20201007103936.GA24327@lst.de> From: Christian Borntraeger Autocrypt: addr=borntraeger@de.ibm.com; prefer-encrypt=mutual; keydata= xsFNBE6cPPgBEAC2VpALY0UJjGmgAmavkL/iAdqul2/F9ONz42K6NrwmT+SI9CylKHIX+fdf J34pLNJDmDVEdeb+brtpwC9JEZOLVE0nb+SR83CsAINJYKG3V1b3Kfs0hydseYKsBYqJTN2j CmUXDYq9J7uOyQQ7TNVoQejmpp5ifR4EzwIFfmYDekxRVZDJygD0wL/EzUr8Je3/j548NLyL 4Uhv6CIPf3TY3/aLVKXdxz/ntbLgMcfZsDoHgDk3lY3r1iwbWwEM2+eYRdSZaR4VD+JRD7p8 0FBadNwWnBce1fmQp3EklodGi5y7TNZ/CKdJ+jRPAAnw7SINhSd7PhJMruDAJaUlbYaIm23A +82g+IGe4z9tRGQ9TAflezVMhT5J3ccu6cpIjjvwDlbxucSmtVi5VtPAMTLmfjYp7VY2Tgr+ T92v7+V96jAfE3Zy2nq52e8RDdUo/F6faxcumdl+aLhhKLXgrozpoe2nL0Nyc2uqFjkjwXXI OBQiaqGeWtxeKJP+O8MIpjyGuHUGzvjNx5S/592TQO3phpT5IFWfMgbu4OreZ9yekDhf7Cvn /fkYsiLDz9W6Clihd/xlpm79+jlhm4E3xBPiQOPCZowmHjx57mXVAypOP2Eu+i2nyQrkapaY IdisDQfWPdNeHNOiPnPS3+GhVlPcqSJAIWnuO7Ofw1ZVOyg/jwARAQABzUNDaHJpc3RpYW4g Qm9ybnRyYWVnZXIgKDJuZCBJQk0gYWRkcmVzcykgPGJvcm50cmFlZ2VyQGxpbnV4LmlibS5j b20+wsF5BBMBAgAjBQJdP/hMAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQEXu8 gLWmHHy/pA/+JHjpEnd01A0CCyfVnb5fmcOlQ0LdmoKWLWPvU840q65HycCBFTt6V62cDljB kXFFxMNA4y/2wqU0H5/CiL963y3gWIiJsZa4ent+KrHl5GK1nIgbbesfJyA7JqlB0w/E/SuY NRQwIWOo/uEvOgXnk/7+rtvBzNaPGoGiiV1LZzeaxBVWrqLtmdi1iulW/0X/AlQPuF9dD1Px hx+0mPjZ8ClLpdSp5d0yfpwgHtM1B7KMuQPQZGFKMXXTUd3ceBUGGczsgIMipZWJukqMJiJj QIMH0IN7XYErEnhf0GCxJ3xAn/J7iFpPFv8sFZTvukntJXSUssONnwiKuld6ttUaFhSuSoQg OFYR5v7pOfinM0FcScPKTkrRsB5iUvpdthLq5qgwdQjmyINt3cb+5aSvBX2nNN135oGOtlb5 tf4dh00kUR8XFHRrFxXx4Dbaw4PKgV3QLIHKEENlqnthH5t0tahDygQPnSucuXbVQEcDZaL9 WgJqlRAAj0pG8M6JNU5+2ftTFXoTcoIUbb0KTOibaO9zHVeGegwAvPLLNlKHiHXcgLX1tkjC DrvE2Z0e2/4q7wgZgn1kbvz7ZHQZB76OM2mjkFu7QNHlRJ2VXJA8tMXyTgBX6kq1cYMmd/Hl OhFrAU3QO1SjCsXA2CDk9MM1471mYB3CTXQuKzXckJnxHkHOwU0ETpw8+AEQAJjyNXvMQdJN t07BIPDtbAQk15FfB0hKuyZVs+0lsjPKBZCamAAexNRk11eVGXK/YrqwjChkk60rt3q5i42u PpNMO9aS8cLPOfVft89Y654Qd3Rs1WRFIQq9xLjdLfHh0i0jMq5Ty+aiddSXpZ7oU6E+ud+X Czs3k5RAnOdW6eV3+v10sUjEGiFNZwzN9Udd6PfKET0J70qjnpY3NuWn5Sp1ZEn6lkq2Zm+G 9G3FlBRVClT30OWeiRHCYB6e6j1x1u/rSU4JiNYjPwSJA8EPKnt1s/Eeq37qXXvk+9DYiHdT PcOa3aNCSbIygD3jyjkg6EV9ZLHibE2R/PMMid9FrqhKh/cwcYn9FrT0FE48/2IBW5mfDpAd YvpawQlRz3XJr2rYZJwMUm1y+49+1ZmDclaF3s9dcz2JvuywNq78z/VsUfGz4Sbxy4ShpNpG REojRcz/xOK+FqNuBk+HoWKw6OxgRzfNleDvScVmbY6cQQZfGx/T7xlgZjl5Mu/2z+ofeoxb vWWM1YCJAT91GFvj29Wvm8OAPN/+SJj8LQazd9uGzVMTz6lFjVtH7YkeW/NZrP6znAwv5P1a DdQfiB5F63AX++NlTiyA+GD/ggfRl68LheSskOcxDwgI5TqmaKtX1/8RkrLpnzO3evzkfJb1 D5qh3wM1t7PZ+JWTluSX8W25ABEBAAHCwV8EGAECAAkFAk6cPPgCGwwACgkQEXu8gLWmHHz8 2w//VjRlX+tKF3szc0lQi4X0t+pf88uIsvR/a1GRZpppQbn1jgE44hgF559K6/yYemcvTR7r 6Xt7cjWGS4wfaR0+pkWV+2dbw8Xi4DI07/fN00NoVEpYUUnOnupBgychtVpxkGqsplJZQpng v6fauZtyEcUK3dLJH3TdVQDLbUcL4qZpzHbsuUnTWsmNmG4Vi0NsEt1xyd/Wuw+0kM/oFEH1 4BN6X9xZcG8GYUbVUd8+bmio8ao8m0tzo4pseDZFo4ncDmlFWU6hHnAVfkAs4tqA6/fl7RLN JuWBiOL/mP5B6HDQT9JsnaRdzqF73FnU2+WrZPjinHPLeE74istVgjbowvsgUqtzjPIG5pOj cAsKoR0M1womzJVRfYauWhYiW/KeECklci4TPBDNx7YhahSUlexfoftltJA8swRshNA/M90/ i9zDo9ySSZHwsGxG06ZOH5/MzG6HpLja7g8NTgA0TD5YaFm/oOnsQVsf2DeAGPS2xNirmknD jaqYefx7yQ7FJXXETd2uVURiDeNEFhVZWb5CiBJM5c6qQMhmkS4VyT7/+raaEGgkEKEgHOWf ZDP8BHfXtszHqI3Fo1F4IKFo/AP8GOFFxMRgbvlAs8z/+rEEaQYjxYJqj08raw6P4LFBqozr nS4h0HDFPrrp1C2EMVYIQrMokWvlFZbCpsdYbBI= Message-ID: Date: Wed, 7 Oct 2020 12:44:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201007103936.GA24327@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-07_05:2020-10-06,2020-10-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 mlxscore=0 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=953 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070066 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.10.20 12:39, Christoph Hellwig wrote: > On Wed, Oct 07, 2020 at 11:34:17AM +0200, Christian Borntraeger wrote: >> >> On 19.05.20 16:22, Stefan Haberland wrote: >>> The IBM partition parser requires device type specific information only >>> available to the DASD driver to correctly register partitions. The >>> current approach of using ioctl_by_bdev with a fake user space pointer >>> is discouraged. >>> >>> Fix this by replacing IOCTL calls with direct in-kernel function calls. >>> >>> Suggested-by: Christoph Hellwig >>> Signed-off-by: Stefan Haberland >>> Reviewed-by: Jan Hoeppner >>> Reviewed-by: Peter Oberparleiter >> >> FWIW, this broken the ibm-partition code for virtio-blk, when CONFIG_DASD=m. > > What are the symptoms? During boot I normally have [ 0.930231] virtio_blk virtio1: [vda] 5409180 4096-byte logical blocks (22.2 GB/20.6 GiB) [ 0.930233] vda: detected capacity change from 0 to 22156001280 [ 0.932806] vda:VOL1/ 0X3333: vda1 vda2 vda3 With this change, the last line is no longer there (if CONFIG_DASD=m) and this also reflects itself in /proc/partitions. The partitions are no longer detected.