Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Oct 2020 14:48:42 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Paul Bolle <pebolle@tiscali.nl>,
        Richard Weinberger <richard.weinberger@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Richard Weinberger <richard@nod.at>,
        Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Nick Hu <nickhu@andestech.com>,
        Greentime Hu <green.hu@gmail.com>,
        Vincent Chen <deanbo422@gmail.com>
Subject: Re: Build regressions/improvements in v5.9-rc8
Message-ID: <20201007134842.GA1869@infradead.org>
References: <20201005093024.16032-1-geert@linux-m68k.org>
 <CAMuHMdVqpgro9Qzn39fK9R2-2xDm6LDe6uOB5gSTrdRxbecNXQ@mail.gmail.com>
 <20201005125840.GP3956970@smile.fi.intel.com>
 <d1457a75d5f38002c063c3801af7819af43e0bfc.camel@tiscali.nl>
 <CAFLxGvyvgSvcizZFZxezFKhZCP79yyMuM7izFbcUtzRTpiOb6A@mail.gmail.com>
 <5f5c303d30eaa32c21131502cc6f28db9d655329.camel@tiscali.nl>
 <20201007130241.GA4077@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201007130241.GA4077@smile.fi.intel.com>
Precedence: bulk

On Wed, Oct 07, 2020 at 04:02:41PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 07, 2020 at 02:45:30PM +0200, Paul Bolle wrote:
> > Richard Weinberger schreef op wo 07-10-2020 om 14:08 [+0200]:
> > > UML has no ia32 emulation and therefore no in_ia32_syscall().
> > > Maybe you can check for CONFIG_IA32_EMULATION too?
> > 
> > The pending fix is:
> >     #if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
> > 
> > Since this check guards in_ia32_syscall() just checking CONFIG_IA32_EMULATION
> > should do too.
> > 
> > (Way outside my limited expertise, but anyway: is does look odd to see a call
> > to in_ia32_syscall() in drivers/. All other calls are in arch/x86/. Isn't this
> > a bit too x86 specific for an arch independent driver?)
> 
> According to Arnd who suggested that fix the problem is basically appears on
> x86. He also mentioned the new approach that Christoph Hellwig is working on.
> But we decided to go the ifdeffery for better backporting.

linux-next has compat_need_64bit_alignment_fixup(), which is the
proper thing to use.  But for now you'll need the ifdef mess.