Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp619012pxu; Wed, 7 Oct 2020 11:15:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEX6C1O3TNAKYRKkq5Hb/o+Q88VTpckpIOBbXJhhs928afqrXtHGG6lzN9VMPSPuzgbFAM X-Received: by 2002:a05:6402:b0e:: with SMTP id bm14mr4914492edb.19.1602094548113; Wed, 07 Oct 2020 11:15:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602094548; cv=none; d=google.com; s=arc-20160816; b=gK6y6Q9zBymc0csZXeVy7fPpWw0Vn8/EPoRaVC+sgLPHYC9sL9ZSLajqy0x97613oR Qz1VbQ/hnswfYYvx+mZxbMZHpc8/Kscpk9hlN6oqAQSK4OQMes+5rnCEi4qX1zVOGN8C oXxVov/eoXa3GVxGI2uyQP8sBWQBJxIuUD8Aas5eMiMaRUI5q4gfqlktaJZpdarMmaey p+xH93DfrR6YnHw6FbwjDXZBeCyp+WDfjw5V8VUuImfm0DcTKOkeRGHsNE/2PgmkIaM4 jRHIMjYjwpTW2z63eT+maLbu33QeEHfPo08s6amTunay8qpEK82vMbbwUooQJdC7lro+ gQZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=WD7AvrZGYpLFK/U5aqrNMVal8DD23I37slU+OojZ1cA=; b=QVeFim958bDv+/EfLDm/WsncNXZa5X7NNvxdQUsSS2K/Tt8Eo+6Ccj0d4vTwBH+YDE 5h1nz6ef6WpekLEIm7uCE9z+DXzjC5RjWQJ2Lfb33mbya28EgKGN4/J4sHym1dwzweAv n7cLL+EU/neNtXc6XzSY1FWYREILaTu2jRqm/EAVdt76TOQfXgrahrcb1fE4kKorDGdF jb2N2vtw8hdRIIF148vv/m1GrpN+Bpr5gvGsCZsoXV8iI472vCcsFjAV6t84da5vJWxk l4fuDpV1i06EGgXzsnNBdGgM7y2PLouo6YN1Tse4IqWy3WmxpcU5pFZOJeIFcO2nLM24 xUJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=fMd0Vwgw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=marvell.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lo12si2017210ejb.355.2020.10.07.11.15.23; Wed, 07 Oct 2020 11:15:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=fMd0Vwgw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbgJGRNB (ORCPT + 99 others); Wed, 7 Oct 2020 13:13:01 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:57386 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726707AbgJGRNB (ORCPT ); Wed, 7 Oct 2020 13:13:01 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 097HA0PT015296; Wed, 7 Oct 2020 10:12:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : in-reply-to : message-id : references : mime-version : content-type; s=pfpt0220; bh=WD7AvrZGYpLFK/U5aqrNMVal8DD23I37slU+OojZ1cA=; b=fMd0VwgwLSpwdHrCKXGb4kP1Erqjklh9FRVQpAZ3UkwvIdDNXKO69BBtv8NFKnAqkEuB SK/GlSSQdh/NZ/Bgf7DKCVdeR1ymVTJOvNVsMznrCSnP663N19U2clSs6wLYVf6Mcm+j CvRGa1pHB60BQqy3pwk2TivD5BDnlWJIIS/4sQkWQFLH59X5TKELkPx7pK7SLJAKOOmw PktQl0Q9XikusehSsAFEJOn2zUjR+GrCXys60u5Hx1RvD2v0RhM5ZWF6+DvRIRKhWy0S uip7TotJnE6S4rO+GHiL9dES9/9bp/MD1qXoWt/t/whgA+po+oqpvZweJO4qulRxEhTx 1Q== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 33xpnpwqva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 07 Oct 2020 10:12:51 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 10:12:50 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 10:12:49 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 7 Oct 2020 10:12:49 -0700 Received: from irv1user01.caveonetworks.com (unknown [10.104.116.179]) by maili.marvell.com (Postfix) with ESMTP id 6C31D3F703F; Wed, 7 Oct 2020 10:12:49 -0700 (PDT) Received: from localhost (aeasi@localhost) by irv1user01.caveonetworks.com (8.14.4/8.14.4/Submit) with ESMTP id 097HCmxc031270; Wed, 7 Oct 2020 10:12:49 -0700 X-Authentication-Warning: irv1user01.caveonetworks.com: aeasi owned process doing -bs Date: Wed, 7 Oct 2020 10:12:48 -0700 From: Arun Easi X-X-Sender: aeasi@irv1user01.caveonetworks.com To: Qinglang Miao CC: Nilesh Javali , , "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH -next v2] scsi: qla2xxx: Convert to DEFINE_SHOW_ATTRIBUTE In-Reply-To: <20200919025202.17531-1-miaoqinglang@huawei.com> Message-ID: References: <20200919025202.17531-1-miaoqinglang@huawei.com> User-Agent: Alpine 2.21.9999 (LRH 334 2019-03-29) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-07_10:2020-10-07,2020-10-07 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Sep 2020, 7:52pm, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao > --- > v2: based on linux-next(20200917), and can be applied to > mainline cleanly now. > > drivers/scsi/qla2xxx/qla_dfs.c | 68 ++++------------------------------ > 1 file changed, 8 insertions(+), 60 deletions(-) > Looks good. Thanks Qinglang. Regards, -Arun