Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp623159pxu; Wed, 7 Oct 2020 11:22:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaVZhTC4FpW0stQrp1MxBpyivkaLitqMZx2RZvNBhBySWjKxS0ZMgZbbf1FYLZFT1REkxO X-Received: by 2002:a05:6402:2073:: with SMTP id bd19mr4846365edb.127.1602094951709; Wed, 07 Oct 2020 11:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602094951; cv=none; d=google.com; s=arc-20160816; b=w1OxzaG7M/jRYUCMXOluOqtI4I+7c3NA/+0dOcTE93RCFYJPyx9FKL22PxTtIaes3v OTBsHPdWB1/imV+N8fPoHXvansWWwFGLDrVdwVwl9dncSntkkMNlFJxl8QYarutdUgNv BMTCufjVmoO/pHiXqmoiGLxP2WQcjJ2n0wxqSdfQd62GaH1fgnhAyt8DCFOz1RZZAcHQ 2FxpM/d0g83YTr/gXzPr2ZuIwz1GiPzZC0Qu+YPskjKn3dkucLTmSlOkO15TM81V7v1l mas+epO/1j/yS6F+w0sbF7876X15oGLqPYZV4yx7tJFTz9Q7cvXnfQJDCYUHCEXLfOgG ngGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=vH9Kiij2/aTW7bWMoqRFax1aZ04huQLmyjYHxGrPQdc=; b=jzrt2xzYtSyHKz1c+u7k0ijOvCZxCksvSkTuuCcXGZo8616fAM4paFC3pKJtBnMnOa T0DOethn36FemHPmsP0JwZRUM8oy/ozOXSDamh57ms27jTjGvQTVJs0n5AMNlBSOztqF oFMNrvwghTFSxJl6cTFuE8kbkuHU52d3QGnWHsm4Tg2kNtMrT9lshhBl30TWjhz0XBhW Hm1FO13VT7q8G7g9ZxXnhFKiAjgoYCFjpG6qUhxllGGT8RW7PD8Okle9bgAU2MhR6dpc WcsFgcrmjg7zC367CBlixthZ2nTRF3MIX8H5rIoO3TBaVW6FikE6Db4JY46URHZ3/2Yc hA7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gwcSMHn/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si1910026eds.162.2020.10.07.11.22.08; Wed, 07 Oct 2020 11:22:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gwcSMHn/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728535AbgJGRyP (ORCPT + 99 others); Wed, 7 Oct 2020 13:54:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54258 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728298AbgJGRyP (ORCPT ); Wed, 7 Oct 2020 13:54:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602093253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vH9Kiij2/aTW7bWMoqRFax1aZ04huQLmyjYHxGrPQdc=; b=gwcSMHn/mz5vSFmSFe7vF2VMI4cHqidCfotrtNmbSA9NulzboVkajfawf0tDcI9HlSRA+b JxLWnqTchoSK/bcC2KN758G+7OtMTdeMafjskYXXMKQ64nnjbhyHlTrPPxSj3LvXSf7uth 8BmrKO3Yay5f8T16O2cDIvnYp5a9FCw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-LUgFd02kOkKXt201YjT0yA-1; Wed, 07 Oct 2020 13:54:11 -0400 X-MC-Unique: LUgFd02kOkKXt201YjT0yA-1 Received: by mail-wr1-f72.google.com with SMTP id l15so1702018wro.10 for ; Wed, 07 Oct 2020 10:54:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vH9Kiij2/aTW7bWMoqRFax1aZ04huQLmyjYHxGrPQdc=; b=rqZ3Q7sKbWCooyQPoNFvqK6en1N5qSpykRxmC9paIwnnLZM/kdiAqzGxUH3xgxBVJs wptCbZr4g45fRtRjswNjKugAroLMxbGZ68KHIVt+CHwhwgo68iQsbws4guHUHWd77AIk TGkTyva1PAigYyUMwxIttx1uRNSC8dYd6acPzOUXNMlA4f+80UbURs5+vjUs1SQvbFnW IbqoksvItTm8ufYs/UdAKZUOzaN+/rcsA/qzSnjl2/9apqfaz2xKg3sag8PgrY6Sa/jC 2+vMSkkgpTzWKpwpDVHUG4sGLGlGYBc0cxTc7RecZF3apcy7DdbT+6YzlfRZAxTt3yM0 HiLQ== X-Gm-Message-State: AOAM533Z/wuvw654XHQokHdFCoQa7QlZDk92CWi/vMeGWveUsDVTIybd pyP6SiRcUS2iQwxIiLf9nMo7jdug237CpvSEHjcug8wyBL9y+9G7zq4itgJdfOIRU2goXYcVnyH hMYvFR6PN8lsCZGOuJqr/tMfU X-Received: by 2002:a1c:3105:: with SMTP id x5mr4237279wmx.143.1602093250497; Wed, 07 Oct 2020 10:54:10 -0700 (PDT) X-Received: by 2002:a1c:3105:: with SMTP id x5mr4237182wmx.143.1602093249068; Wed, 07 Oct 2020 10:54:09 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:d2f4:5943:190c:39ff? ([2001:b07:6468:f312:d2f4:5943:190c:39ff]) by smtp.gmail.com with ESMTPSA id 67sm3587452wmb.31.2020.10.07.10.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2020 10:54:08 -0700 (PDT) Subject: Re: [PATCH 15/22] kvm: mmu: Support changed pte notifier in tdp MMU To: Ben Gardon Cc: LKML , kvm , Cannon Matthews , Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-16-bgardon@google.com> <622ffc59-d914-c718-3f2f-952f714ac63c@redhat.com> <7636707a-b622-90a3-e641-18662938f6dd@redhat.com> From: Paolo Bonzini Message-ID: <5bb8168c-e4a2-6365-f220-13b67c9c375d@redhat.com> Date: Wed, 7 Oct 2020 19:54:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/20 19:30, Ben Gardon wrote: >> Well that's not easy if you have to think of which functions have to be >> called. >> >> I'll take a closer look at the access tracking and dirty logging cases >> to try and understand what those bugs can be. Apart from that I have my >> suggested changes and I can probably finish testing them and send them >> out tomorrow. > Awesome, thank you. I'll look forward to seeing them. Will you be > applying those changes to the tdp_mmu branch you created as well? > No, only to the rebased version. Paolo